VSadov/Satori
1
0
Fork 0
mirror of https://github.com/VSadov/Satori.git synced 2025-06-12 02:30:29 +09:00
Code Activity

Clarified documentation regarding building the Core_Root. (#72560)

Browse source 
* Added a note emphasizing Libraries have to be built in Release mode to generate the Core_Root.

* Corrected a statement regarding libraries' configuration.

Co-authored-by: Seeker186 <101211595+Seeker186@users.noreply.github.com>
This commit is contained in:
Ivan Diaz Sanchez 2022-07-21 14:01:45 -07:00 • committed by GitHub
parent 2f02f1241c
commit cd24e183a1
Signed by: github
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
docs/workflow/building/coreclr/linux-instructions.md
View file

@ -87,8 +87,9 @@ After the build is completed, there should some files placed in `artifacts/bin/c
Create the Core_Root
===================
The Core_Root folder will contain the built binaries, generated by `build.sh`, as well as the library packages required to run tests. Note that you need to build
the libraries subset (`-subset libs`) before this command can be run.
The Core_Root folder will contain the built binaries, generated by `build.sh`, as well as the library packages required to run tests. It is required that you build
the libraries subset (`-subset libs`) before this command can be run. Note that this by default searches the libraries in Release mode, regardless of the runtime
configuration you specify. If you built your libs in another configuration, then you have to pass down the appropriate flag `/p:LibrariesConfiguration=<your_config>`.
```
./src/tests/build.sh generatelayoutonly

4
docs/workflow/building/coreclr/osx-instructions.md
View file

@ -26,7 +26,9 @@ After the build has completed, there should some files placed in `artifacts/bin/
Create the Core_Root
===================
The Core_Root folder will have the built binaries, from `src/coreclr/build.sh` and it will also include the CoreFX packages required to run tests.
The Core_Root folder will contain the built binaries, generated by `build.sh`, as well as the library packages required to run tests. It is required that you build
the libraries subset (`-subset libs`) before this command can be run. Note that this by default searches the libraries in Release mode, regardless of the runtime
configuration you specify. If you built your libs in another configuration, then you have to pass down the appropriate flag `/p:LibrariesConfiguration=<your_config>`.
```
./src/tests/build.sh generatelayoutonly