From cd24e183a1549c3f70f532079fce925c3ee6552e Mon Sep 17 00:00:00 2001 From: Ivan Diaz Sanchez Date: Thu, 21 Jul 2022 14:01:45 -0700 Subject: [PATCH] Clarified documentation regarding building the Core_Root. (#72560) * Added a note emphasizing Libraries have to be built in Release mode to generate the Core_Root. * Corrected a statement regarding libraries' configuration. Co-authored-by: Seeker186 <101211595+Seeker186@users.noreply.github.com> --- docs/workflow/building/coreclr/linux-instructions.md | 5 +++-- docs/workflow/building/coreclr/osx-instructions.md | 4 +++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/docs/workflow/building/coreclr/linux-instructions.md b/docs/workflow/building/coreclr/linux-instructions.md index f4166f0f0e4..dac415c3da1 100644 --- a/docs/workflow/building/coreclr/linux-instructions.md +++ b/docs/workflow/building/coreclr/linux-instructions.md @@ -87,8 +87,9 @@ After the build is completed, there should some files placed in `artifacts/bin/c Create the Core_Root =================== -The Core_Root folder will contain the built binaries, generated by `build.sh`, as well as the library packages required to run tests. Note that you need to build -the libraries subset (`-subset libs`) before this command can be run. +The Core_Root folder will contain the built binaries, generated by `build.sh`, as well as the library packages required to run tests. It is required that you build +the libraries subset (`-subset libs`) before this command can be run. Note that this by default searches the libraries in Release mode, regardless of the runtime +configuration you specify. If you built your libs in another configuration, then you have to pass down the appropriate flag `/p:LibrariesConfiguration=`. ``` ./src/tests/build.sh generatelayoutonly diff --git a/docs/workflow/building/coreclr/osx-instructions.md b/docs/workflow/building/coreclr/osx-instructions.md index 41e8d87de1a..283dab9ac68 100644 --- a/docs/workflow/building/coreclr/osx-instructions.md +++ b/docs/workflow/building/coreclr/osx-instructions.md @@ -26,7 +26,9 @@ After the build has completed, there should some files placed in `artifacts/bin/ Create the Core_Root =================== -The Core_Root folder will have the built binaries, from `src/coreclr/build.sh` and it will also include the CoreFX packages required to run tests. +The Core_Root folder will contain the built binaries, generated by `build.sh`, as well as the library packages required to run tests. It is required that you build +the libraries subset (`-subset libs`) before this command can be run. Note that this by default searches the libraries in Release mode, regardless of the runtime +configuration you specify. If you built your libs in another configuration, then you have to pass down the appropriate flag `/p:LibrariesConfiguration=`. ``` ./src/tests/build.sh generatelayoutonly