1
0
Fork 0
mirror of https://github.com/ppy/osu-tools.git synced 2025-06-07 23:07:01 +09:00
Commit graph

945 commits

Author SHA1 Message Date
Dan Balasescu
68994d6395
Merge pull request #207 from stanriders/add-leaderboard-scores
Add an option to view all calculated scores in Leaderboard screen
2024-07-16 12:07:24 +09:00
StanR
656dcdbc43 Add an option to view all calculated scores in Leaderboard screen 2024-07-13 23:41:31 +05:00
Givikap120
925b8f5461
Merge branch 'ppy:master' into better_accuracy_estimator 2024-06-28 23:16:09 +03:00
Dan Balasescu
179c0bda1c
Merge pull request #206 from stanriders/fix-object-inspectors
Fix GUI object inspectors, update packages
2024-06-26 10:03:19 +09:00
StanR
430fe6ef0f usings 2024-06-25 23:32:55 +05:00
StanR
26bf2b6f93 Update packages, address warnings 2024-06-25 23:21:26 +05:00
StanR
c67393ddef Fix object inspectors not working 2024-06-25 23:19:35 +05:00
Dan Balasescu
d74593a183
Merge pull request #205 from bdach/legacy-score-performance-command-is-doing-things
Fix `performance legacy-score` command doing things it doesn't need to
2024-05-28 07:41:57 +09:00
Bartłomiej Dach
2b16421461
Fix performance legacy-score command doing things it doesn't need to
I'm not exactly sure when or how this happened because I tested this
previously (did some web change cause this?), but the `performance
legacy-score` command is:

- doubly-applying the classic mod
- needlessly marking the score as legacy
- incorrectly copying the post-conversion recalculated total score into
  `LegacyTotalScore`

while all it needs to be doing is reading what it is given from the API.
All of the data it needs is already there, in a form ready for
consumption.
2024-05-27 14:41:45 +02:00
Dan Balasescu
d63c2d301f
Merge pull request #203 from Syriiin/fix/mania-hitresult-algorithm
Fix mania GenerateHitResults() bugs
2024-05-03 18:08:36 +09:00
Samuel Cattini-Schultz
cd89fa3041 Simplify divmod
https://github.com/ppy/osu-tools/pull/203#discussion_r1586313994
2024-05-02 21:37:31 +10:00
Dan Balasescu
25ca400c5d
Merge pull request #204 from bdach/fix-broken-online-difficulty-attribute-lookup
Fix online attribute flag in score performance command not retrieving full difficulty attributes
2024-05-01 04:36:51 +09:00
Bartłomiej Dach
d6cf8dca1a
Fix online attribute flag in score performance command not retrieving full difficulty attributes
Found when investigating https://github.com/ppy/osu/issues/28006.

If the `performance score` command is given the `-a` flag, it is
supposed to use the current online beatmap difficulty attributes. It
does so by querying API, which queries `osu-beatmap-difficulty-cache`.

Problem is, that some of the difficulty attributes, namely the ones that
are already present on `APIBeatmap`, are not serialised out by
`osu-beatmap-difficulty-cache`:

	db22033682/BeatmapDifficultyLookupCache/DifficultyCache.cs (L125-L128)

`osu-tools` is blissfully unaware of this, and as such attempts to
deserialise the difficulty attributes returned from cache-then-web raw,
which leads to it just using the default values (e.g. zeroes) for
attributes that the difficulty lookup cache does not serialise out. This
leads to obviously bogus results.

To fix, retrieve the `APIBeatmap` manually and do some (admittedly
gnarly) grafting in order to produce a fully populated object. It's a
bit ugly but it works locally without further changes so maybe fine?
2024-04-29 09:14:57 +02:00
Samuel Cattini-Schultz
76f18b886e Fix code style 2024-04-25 00:53:21 +10:00
Samuel Cattini-Schultz
a025b5f204 Fix mania GenerateHitResults() bugs
1. An odd number of great/perfect hits would drop a hit and throw off
calculations.
2. Oks were duplicated as Mehs
2024-04-25 00:46:33 +10:00
Dan Balasescu
c3cbe410bb
Merge pull request #200 from MaxOhn/catch-hitresults
Fix maxFruits count
2024-03-04 13:36:07 +09:00
MaxOhn
cb9b28073f Fix maxFruits count 2024-02-16 18:29:00 +01:00
Dean Herbert
64a3f1783a
Merge pull request #199 from FamousPig/update-launch-json
Update VS Code configuration to point to `net8.0` directory
2024-02-16 21:12:55 +08:00
Leon Gebler
8c56181bd4 Point launch.json to new build directory 2024-02-15 23:37:31 +01:00
Givikap120
54088b5943 Added VERY detailed commentaries on algorithm 2024-02-14 21:24:46 +02:00
Givikap120
7ed7b944d0 Update RulesetHelper.cs 2024-02-14 20:16:50 +02:00
Dean Herbert
bfe1d342a7
Merge pull request #195 from smoogipoo/new-scores-command
Add support for computing performance of non-legacy scores
2024-02-11 15:59:54 +08:00
Dan Balasescu
408b1271b6
Fix querying imported legacy scores having duplicate stats 2024-02-08 01:32:51 +09:00
Dan Balasescu
cb6095105f
Merge branch 'master' into new-scores-command 2024-02-08 01:29:11 +09:00
Dan Balasescu
47b22ddc82
Link implementation to osu-queue-score-statistics 2024-02-06 17:39:33 +09:00
Dan Balasescu
11e674b2f7
Merge pull request #197 from bdach/update-readme-net8
Update readme after .NET 8 bump
2024-02-05 17:57:18 +09:00
Bartłomiej Dach
379e1fcacb
Update readme after .NET 8 bump 2024-02-05 09:50:29 +01:00
Dean Herbert
b7e5db7bad
Merge pull request #196 from smoogipoo/net8
Update to .NET 8 + R# 2023.3.3
2024-02-04 18:17:57 +08:00
Dan Balasescu
a096b827d9
Fix inspection 2024-02-04 17:21:34 +09:00
Dan Balasescu
76100a481e
Merge branch 'master' into net8 2024-02-04 17:20:55 +09:00
Dean Herbert
b2a9f49a9f
Merge branch 'master' into new-scores-command 2024-02-04 15:29:07 +08:00
Dean Herbert
3a1832b455
Merge pull request #194 from bdach/conversion-testbench
Implement command for testing legacy score total conversion
2024-02-04 15:25:20 +08:00
Dean Herbert
a0cd2bf395
Attempt to via nvika failure 2024-02-04 11:57:05 +08:00
Dan Balasescu
ea86ddfafd
Actually add the subcommand 2024-02-03 05:49:54 +09:00
Dan Balasescu
f0de373eaf
Merge branch 'master' into new-scores-command 2024-02-03 05:47:35 +09:00
Dan Balasescu
1a0016dbbe
Adjust CI workflow + use R# 2023.3.3 2024-02-03 01:19:01 +09:00
Dan Balasescu
9001cd8925
Remove use of System.ComponentModel.DataAnnotations
`[Argument]` implies use. Turns out the `System` namespace added a
conflicting `[AllowedValues]` attribute that I don't want to deal with.
2024-02-03 01:12:14 +09:00
Dan Balasescu
3f7164d3af
Update to .NET 8 2024-02-03 01:09:50 +09:00
Dan Balasescu
2d74ad6086
Merge branch 'master' into conversion-testbench 2024-01-31 23:22:42 +09:00
Dan Balasescu
fb1ca042e3
Merge pull request #193 from bdach/update-after-standardised-changes
Update commands after game-side changes to accuracy/rank calculation
2024-01-31 23:21:11 +09:00
Bartłomiej Dach
9873820439
Use async overload with cancellation where possible 2024-01-30 12:42:26 +01:00
Bartłomiej Dach
00b002b72a
Fix oversight in GUI implementation 2024-01-30 12:28:40 +01:00
Bartłomiej Dach
f09215d3c9
Simplify reference 2024-01-30 12:28:30 +01:00
Bartłomiej Dach
e11a856909
Update game packages 2024-01-30 12:28:25 +01:00
Dan Balasescu
ea6ac6c23d
Add support for computing performance of non-legacy scores 2024-01-30 14:12:55 +09:00
Bartłomiej Dach
8a681e11bc
Implement command for testing legacy score total conversion
Comes in handy when needing to quickly diagnose failures in score
importers without having to fabricate a replay or import data locally or
do other similar shenanigans.
2024-01-29 23:10:34 +01:00
Bartłomiej Dach
38cfa02cee
Rename legacy-score command slug to distinguish from new command 2024-01-29 22:47:30 +01:00
Bartłomiej Dach
9012dea523
Update commands after game-side changes to accuracy/rank calculation 2024-01-29 22:12:49 +01:00
Dean Herbert
c9208d7d2d
Merge pull request #192 from stanriders/update-packages-2024121
Update packages
2024-01-23 22:15:51 +09:00
StanR
2fc3bbbc54 Update packages 2024-01-23 17:00:07 +06:00