osu/osu-tools
1
0
Fork 0
mirror of https://github.com/ppy/osu-tools.git synced 2025-06-08 07:17:01 +09:00
Code Activity

Fix various inspections

Browse source
This commit is contained in:
Dean Herbert 2022-07-24 23:27:38 +09:00
parent 256d10f96c
commit 39857a4f2c
9 changed files with 20 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

2
PerformanceCalculatorGUI/AttributeConversion.cs
View file

@ -29,7 +29,7 @@ namespace PerformanceCalculatorGUI
{
var dictionary = ToDictionary(attributes);
return string.Join("\n", dictionary.Select(x=> $"{x.Key}: {x.Value:N2}"));
return string.Join("\n", dictionary.Select(x => $"{x.Key}: {x.Value:N2}"));
}
}
}

3
PerformanceCalculatorGUI/Components/BeatmapCard.cs
View file

@ -32,7 +32,8 @@ namespace PerformanceCalculatorGUI.Components
[Resolved]
private LargeTextureStore textures { get; set; }
public BeatmapCard(ProcessorWorkingBeatmap beatmap) : base(HoverSampleSet.Button)
public BeatmapCard(ProcessorWorkingBeatmap beatmap)
: base(HoverSampleSet.Button)
{
this.beatmap = beatmap;
RelativeSizeAxes = Axes.X;

2
PerformanceCalculatorGUI/Components/ScreenSelectionButton.cs
View file

@ -17,7 +17,7 @@ namespace PerformanceCalculatorGUI.Components
{
}
public override LocalisableString TooltipText { get; }
public override LocalisableString TooltipText => string.Empty;
}
internal class ScreenSelectionButton : ToolbarButton

2
PerformanceCalculatorGUI/Components/StrainVisualizer.cs
View file

@ -128,7 +128,7 @@ namespace PerformanceCalculatorGUI.Components
strainLists.Add(skillStrainList.ToArray());
}
var strainMaxValue = strainLists.Max(x => x.Max(x => x.val));
var strainMaxValue = strainLists.Max(list => list.Max(x => x.val));
for (int i = 0; i < skills.Length; i++)
{

12
PerformanceCalculatorGUI/ExtendedDifficultyCalculator.cs
View file

@ -25,7 +25,8 @@ namespace PerformanceCalculatorGUI
{
private Skill[] skills;
public ExtendedOsuDifficultyCalculator(IRulesetInfo ruleset, IWorkingBeatmap beatmap) : base(ruleset, beatmap)
public ExtendedOsuDifficultyCalculator(IRulesetInfo ruleset, IWorkingBeatmap beatmap)
: base(ruleset, beatmap)
{
}
@ -43,7 +44,8 @@ namespace PerformanceCalculatorGUI
{
private Skill[] skills;
public ExtendedTaikoDifficultyCalculator(IRulesetInfo ruleset, IWorkingBeatmap beatmap) : base(ruleset, beatmap)
public ExtendedTaikoDifficultyCalculator(IRulesetInfo ruleset, IWorkingBeatmap beatmap)
: base(ruleset, beatmap)
{
}
@ -61,7 +63,8 @@ namespace PerformanceCalculatorGUI
{
private Skill[] skills;
public ExtendedCatchDifficultyCalculator(IRulesetInfo ruleset, IWorkingBeatmap beatmap) : base(ruleset, beatmap)
public ExtendedCatchDifficultyCalculator(IRulesetInfo ruleset, IWorkingBeatmap beatmap)
: base(ruleset, beatmap)
{
}
@ -79,7 +82,8 @@ namespace PerformanceCalculatorGUI
{
private Skill[] skills;
public ExtendedManiaDifficultyCalculator(IRulesetInfo ruleset, IWorkingBeatmap beatmap) : base(ruleset, beatmap)
public ExtendedManiaDifficultyCalculator(IRulesetInfo ruleset, IWorkingBeatmap beatmap)
: base(ruleset, beatmap)
{
}

4
PerformanceCalculatorGUI/PerformanceCalculatorSceneManager.cs
View file

@ -144,10 +144,10 @@ namespace PerformanceCalculatorGUI
Height = 100,
Alpha = 0
}
}
}
}
}
}
}
}
}
};

2
PerformanceCalculatorGUI/Screens/ObjectInspection/ObjectInspectionPanel.cs
View file

@ -44,7 +44,7 @@ namespace PerformanceCalculatorGUI.Screens.ObjectInspection
public void AddParagraph(string text, int fontSize = 10)
{
textFlow.AddParagraph(text, p => p.Font = OsuFont.GetFont(size: fontSize-3));
textFlow.AddParagraph(text, p => p.Font = OsuFont.GetFont(size: fontSize - 3));
}
}
}

5
PerformanceCalculatorGUI/Screens/ObjectInspection/ObjectInspector.cs
View file

@ -125,7 +125,7 @@ namespace PerformanceCalculatorGUI.Screens.ObjectInspection
new Drawable[]
{
new TimeInfoContainer { RelativeSizeAxes = Axes.Both },
new SummaryTimeline { RelativeSizeAxes = Axes.Both,},
new SummaryTimeline { RelativeSizeAxes = Axes.Both },
new PlaybackControl { RelativeSizeAxes = Axes.Both },
},
}
@ -161,7 +161,8 @@ namespace PerformanceCalculatorGUI.Screens.ObjectInspection
{
RelativeSizeAxes = Axes.Both,
Margin = new MarginPadding(10) { Bottom = bottom_bar_height },
Child = new TaikoObjectInspectorRuleset(rulesetInstance, playableBeatmap, modifiedMods, difficultyCalculator.Value as ExtendedTaikoDifficultyCalculator, processorBeatmap.Track.Rate)
Child = new TaikoObjectInspectorRuleset(rulesetInstance, playableBeatmap, modifiedMods, difficultyCalculator.Value as ExtendedTaikoDifficultyCalculator,
processorBeatmap.Track.Rate)
{
RelativeSizeAxes = Axes.Both,
Clock = clock,

3
PerformanceCalculatorGUI/Screens/SimulateScreen.cs
View file

@ -322,10 +322,9 @@ namespace PerformanceCalculatorGUI.Screens
Child = userModsSelectOverlay = new ExtendedUserModSelectOverlay
{
RelativeSizeAxes = Axes.Both,
//AutoSizeAxes = Axes.Y,
Anchor = Anchor.TopLeft,
Origin = Anchor.TopLeft,
IsValidMod = (mod) => mod.HasImplementation && ModUtils.FlattenMod(mod).All(m => m.UserPlayable),
IsValidMod = mod => mod.HasImplementation && ModUtils.FlattenMod(mod).All(m => m.UserPlayable),
SelectedMods = { BindTarget = appliedMods }
}
}