Relations | Redesign | Item height on different screens (#1895)

core-ui/src/main/java/com/anytypeio/anytype/core_ui/features/editor/holders/ext/EditorHolderExtensions.kt

@@ -12,6 +12,10 @@ import com.anytypeio.anytype.presentation.editor.editor.model.BlockView
 
 fun RelationViewHolder.setup(adapter: BlockAdapter): RelationViewHolder {
     with(itemView) {
+        findViewById<ViewGroup?>(R.id.itemContainer)?.updatePadding(
+            top = dimen(R.dimen.relation_view_padding_top),
+            bottom = dimen(R.dimen.relation_view_padding_bottom)
+        )
         val paddingStart = context.dimen(R.dimen.default_document_content_padding_start)
         val paddingEnd = context.dimen(R.dimen.default_document_content_padding_end)
         findViewById<ViewGroup>(R.id.content).apply {

core-ui/src/main/java/com/anytypeio/anytype/core_ui/features/editor/slash/SlashRelationsAdapter.kt

@@ -3,6 +3,7 @@ package com.anytypeio.anytype.core_ui.features.editor.slash
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
+import androidx.core.view.updatePadding
 import androidx.recyclerview.widget.DiffUtil
 import androidx.recyclerview.widget.RecyclerView
 import com.anytypeio.anytype.core_ui.R
@@ -10,6 +11,7 @@ import com.anytypeio.anytype.core_ui.features.editor.holders.relations.RelationV
 import com.anytypeio.anytype.core_ui.features.editor.slash.holders.RelationNewHolder
 import com.anytypeio.anytype.core_ui.features.editor.slash.holders.RelationsSubheaderMenuHolder
 import com.anytypeio.anytype.core_utils.diff.DefaultDiffUtil
+import com.anytypeio.anytype.core_utils.ext.dimen
 import com.anytypeio.anytype.core_utils.ext.gone
 import com.anytypeio.anytype.core_utils.ext.visible
 import com.anytypeio.anytype.presentation.editor.editor.slash.SlashItem

core-ui/src/main/java/com/anytypeio/anytype/core_ui/features/relations/DocumentRelationAdapter.kt

@@ -3,12 +3,15 @@ package com.anytypeio.anytype.core_ui.features.relations
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
+import androidx.core.view.updatePadding
 import androidx.recyclerview.widget.DiffUtil
 import androidx.recyclerview.widget.RecyclerView
 import com.anytypeio.anytype.core_ui.R
 import com.anytypeio.anytype.core_utils.diff.DefaultDiffUtil
+import com.anytypeio.anytype.core_utils.ext.dimen
 import com.anytypeio.anytype.presentation.relations.DocumentRelationView
 import com.anytypeio.anytype.presentation.relations.RelationListViewModel
+import kotlinx.android.synthetic.main.item_document_relation_default.view.*
 import kotlinx.android.synthetic.main.item_relation_list_section.view.*
 import timber.log.Timber
 import com.anytypeio.anytype.core_ui.features.editor.holders.relations.RelationViewHolder as ViewHolder

core-ui/src/main/res/layout/item_document_relation_checkbox.xml

@@ -3,9 +3,7 @@
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
-    android:orientation="horizontal"
-    android:paddingTop="@dimen/relation_view_padding_top"
-    android:paddingBottom="@dimen/relation_view_padding_bottom">
+    android:orientation="horizontal">
 
     <TextView
         android:id="@+id/tvRelationTitle"

core-ui/src/main/res/layout/item_document_relation_default.xml

@@ -1,11 +1,10 @@
 <?xml version="1.0" encoding="utf-8"?>
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:tools="http://schemas.android.com/tools"
+    android:id="@+id/itemContainer"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
-    android:orientation="horizontal"
-    android:paddingTop="@dimen/relation_view_padding_top"
-    android:paddingBottom="@dimen/relation_view_padding_bottom">
+    android:orientation="horizontal">
 
     <TextView
         android:id="@+id/tvRelationTitle"

core-ui/src/main/res/layout/item_document_relation_file.xml

@@ -3,9 +3,7 @@
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
-    xmlns:app="http://schemas.android.com/apk/res-auto"
-    android:paddingTop="@dimen/relation_view_padding_top"
-    android:paddingBottom="@dimen/relation_view_padding_bottom">
+    xmlns:app="http://schemas.android.com/apk/res-auto">
 
     <androidx.constraintlayout.widget.Guideline
         android:id="@+id/guideline3"

core-ui/src/main/res/layout/item_document_relation_object.xml

@@ -3,9 +3,7 @@
     xmlns:app="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
-    android:layout_height="wrap_content"
-    android:paddingTop="@dimen/relation_view_padding_top"
-    android:paddingBottom="@dimen/relation_view_padding_bottom">
+    android:layout_height="wrap_content">
 
     <TextView
         android:id="@+id/tvRelationTitle"

core-ui/src/main/res/layout/item_document_relation_status.xml

@@ -3,9 +3,7 @@
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
-    android:orientation="horizontal"
-    android:paddingTop="@dimen/relation_view_padding_top"
-    android:paddingBottom="@dimen/relation_view_padding_bottom">
+    android:orientation="horizontal">
 
     <TextView
         android:id="@+id/tvRelationTitle"

core-ui/src/main/res/layout/item_document_relation_tag.xml

@@ -4,9 +4,7 @@
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
-    android:orientation="horizontal"
-    android:paddingTop="@dimen/relation_view_padding_top"
-    android:paddingBottom="@dimen/relation_view_padding_bottom">
+    android:orientation="horizontal">
 
     <androidx.constraintlayout.widget.Guideline
         android:id="@+id/guideline3"

core-ui/src/main/res/layout/item_relation_list_relation_checkbox.xml

@@ -1,10 +1,12 @@
 <?xml version="1.0" encoding="utf-8"?>
 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
     android:background="@drawable/default_ripple"
+    android:id="@+id/itemContainer"
     android:layout_width="match_parent"
-    android:layout_height="wrap_content">
+    android:layout_height="48dp">
 
     <LinearLayout
+        android:layout_gravity="center_vertical"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:orientation="horizontal">

core-ui/src/main/res/layout/item_relation_list_relation_default.xml

@@ -1,10 +1,11 @@
 <?xml version="1.0" encoding="utf-8"?>
 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
     android:layout_width="match_parent"
-    android:layout_height="wrap_content"
+    android:layout_height="48dp"
     android:background="@drawable/default_ripple">
 
     <LinearLayout
+        android:layout_gravity="center_vertical"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:orientation="horizontal">
@@ -40,11 +41,12 @@
     </LinearLayout>
 
     <include
+        android:layout_marginTop="12dp"
         android:id="@+id/divider"
         layout="@layout/view_divider"
         android:layout_width="match_parent"
         android:layout_height="0.5dp"
-        android:layout_gravity="bottom"
-        android:visibility="gone" />
+        android:visibility="gone"
+        android:layout_gravity="bottom" />
 
 </FrameLayout>

core-ui/src/main/res/layout/item_relation_list_relation_file.xml

@@ -1,10 +1,12 @@
 <?xml version="1.0" encoding="utf-8"?>
 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    android:id="@+id/itemContainer"
     android:layout_width="match_parent"
-    android:layout_height="wrap_content"
+    android:layout_height="48dp"
     android:background="@drawable/default_ripple">
 
     <LinearLayout
+        android:layout_gravity="center_vertical"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:orientation="horizontal">

core-ui/src/main/res/layout/item_relation_list_relation_object.xml

@@ -1,10 +1,12 @@
 <?xml version="1.0" encoding="utf-8"?>
 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
     android:background="@drawable/default_ripple"
+    android:id="@+id/itemContainer"
     android:layout_width="match_parent"
-    android:layout_height="wrap_content">
+    android:layout_height="48dp">
 
     <LinearLayout
+        android:layout_gravity="center_vertical"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:orientation="horizontal">

core-ui/src/main/res/layout/item_relation_list_relation_status.xml

@@ -1,10 +1,12 @@
 <?xml version="1.0" encoding="utf-8"?>
 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    android:id="@+id/itemContainer"
     android:background="@drawable/default_ripple"
     android:layout_width="match_parent"
-    android:layout_height="wrap_content">
+    android:layout_height="48dp">
 
     <LinearLayout
+        android:layout_gravity="center_vertical"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:orientation="horizontal">

core-ui/src/main/res/layout/item_relation_list_relation_tag.xml

@@ -1,10 +1,12 @@
 <?xml version="1.0" encoding="utf-8"?>
 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    android:id="@+id/itemContainer"
     android:background="@drawable/default_ripple"
     android:layout_width="match_parent"
-    android:layout_height="wrap_content">
+    android:layout_height="48dp">
 
     <LinearLayout
+        android:layout_gravity="center_vertical"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:orientation="horizontal">

core-ui/src/main/res/values/dimens.xml

@@ -194,5 +194,6 @@
     <dimen name="list_item_object_half_text_margin_start">72dp</dimen>
     <dimen name="list_item_object_half_text_margin_end">20dp</dimen>
     <dimen name="default_cover_height">200dp</dimen>
+    <dimen name="dp_14">14dp</dimen>
 
 </resources>