From 6906c5e9f5c65bed6ec37c144bad4a77a622da81 Mon Sep 17 00:00:00 2001 From: Sergey Date: Tue, 29 Apr 2025 14:57:35 +0200 Subject: [PATCH] GO-5297: Fix tests --- core/acl/aclservice.go | 5 ----- core/acl/aclservice_test.go | 21 +------------------ .../aclobjectmananger_test.go | 6 +++++- 3 files changed, 6 insertions(+), 26 deletions(-) diff --git a/core/acl/aclservice.go b/core/acl/aclservice.go index 0e5b7f8d2..30df9d270 100644 --- a/core/acl/aclservice.go +++ b/core/acl/aclservice.go @@ -38,11 +38,6 @@ type NodeConfGetter interface { GetNodeConf() (conf nodeconf.Configuration) } -type pushService interface { - CreateSpace(ctx context.Context, spaceId string) (err error) - SubscribeToTopics(ctx context.Context, spaceId string, topic []string) -} - type AccountPermissions struct { Account crypto.PubKey Permissions model.ParticipantPermissions diff --git a/core/acl/aclservice_test.go b/core/acl/aclservice_test.go index 9ebdb5e41..627997f98 100644 --- a/core/acl/aclservice_test.go +++ b/core/acl/aclservice_test.go @@ -63,24 +63,6 @@ func (c *mockConfig) GetNodeConf() (conf nodeconf.Configuration) { return c.Config } -type pushServiceDummy struct { -} - -func (p *pushServiceDummy) Init(a *app.App) (err error) { - return nil -} - -func (p *pushServiceDummy) Name() (name string) { - return "pushServiceDummy" -} - -func (p *pushServiceDummy) CreateSpace(ctx context.Context, spaceId string) (err error) { - return nil -} - -func (p *pushServiceDummy) SubscribeToTopics(ctx context.Context, spaceId string, topic []string) { -} - type fixture struct { *aclService a *app.App @@ -124,8 +106,7 @@ func newFixture(t *testing.T) *fixture { Register(testutil.PrepareMock(ctx, fx.a, fx.mockInviteService)). Register(testutil.PrepareMock(ctx, fx.a, fx.mockCoordinatorClient)). Register(fx.mockConfig). - Register(fx.aclService). - Register(&pushServiceDummy{}) + Register(fx.aclService) require.NoError(t, fx.a.Start(ctx)) return fx } diff --git a/space/internal/components/aclobjectmanager/aclobjectmananger_test.go b/space/internal/components/aclobjectmanager/aclobjectmananger_test.go index b3815a158..30693b0d9 100644 --- a/space/internal/components/aclobjectmanager/aclobjectmananger_test.go +++ b/space/internal/components/aclobjectmanager/aclobjectmananger_test.go @@ -48,7 +48,11 @@ func (s *pushNotificationServiceDummy) SubscribeToTopics(ctx context.Context, sp } -func (s pushNotificationServiceDummy) BroadcastKeyUpdate(spaceId string, aclState *list.AclState) error { +func (s *pushNotificationServiceDummy) CreateSpace(ctx context.Context, spaceId string) (err error) { + return nil +} + +func (s *pushNotificationServiceDummy) BroadcastKeyUpdate(spaceId string, aclState *list.AclState) error { return nil }