From 27a18f408165f901252e37e171592bcb56b7dc97 Mon Sep 17 00:00:00 2001 From: kirillston Date: Tue, 25 Apr 2023 18:17:59 +0200 Subject: [PATCH] GO-1322 Introduce constants --- cmd/logdecode/main.go | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/cmd/logdecode/main.go b/cmd/logdecode/main.go index 8a61b68b1..0c5e5d27f 100644 --- a/cmd/logdecode/main.go +++ b/cmd/logdecode/main.go @@ -11,14 +11,21 @@ import ( "os" ) +const ( + argsLenWithFile = 2 + fileArgNumber = 1 + stdinSizeOnLinux = 4092 + bufferSize = 1024 +) + func main() { var ( err error reader io.Reader file = os.Stdin ) - if len(os.Args) == 2 { - if file, err = os.Open(os.Args[1]); err != nil { + if len(os.Args) == argsLenWithFile { + if file, err = os.Open(os.Args[fileArgNumber]); err != nil { fmt.Println("Error opening file:", err) return } @@ -33,7 +40,7 @@ func main() { if err != nil { fmt.Println("Error decoding base64:", err) // On some OS stdin is limited with 4092 bytes - if errors.Is(err, base64.CorruptInputError(4092)) { + if errors.Is(err, base64.CorruptInputError(stdinSizeOnLinux)) { fmt.Println("Try to pass base64 in a file. Filename should be the argument of the program") } return @@ -49,7 +56,7 @@ func main() { } result := "" - buf := make([]byte, 1024) + buf := make([]byte, bufferSize) for { n, err := reader.Read(buf) result += string(buf[:n])