anyproto/anytype-heart
1
0
Fork 0
mirror of https://github.com/anyproto/anytype-heart.git synced 2025-06-08 05:47:07 +09:00
Code Activity

Merge pull request #2428 from anyproto/go-5663-fix-race-condition-in-addmessage

Browse source 
GO-5663: Chats: AddMessage: fix events race condition
This commit is contained in:
Sergey 2025-05-21 13:00:07 +02:00 • committed by GitHub
commit 131ebc7882
Signed by: github
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
core/block/chats/chatsubscription/manager.go
View file

@ -157,7 +157,6 @@ func (s *subscriptionManager) Flush() {
if s.sessionContext != nil {
s.sessionContext.SetMessages(s.chatId, events)
s.eventSender.BroadcastToOtherSessions(s.sessionContext.ID(), ev)
s.sessionContext = nil
} else if s.IsActive() {
s.eventSender.Broadcast(ev)
}

7
core/block/editor/chatobject/chatobject.go
View file

@ -217,7 +217,14 @@ func (s *storeObject) AddMessage(ctx context.Context, sessionCtx session.Context
return "", fmt.Errorf("create chat: %w", err)
}
s.subscription.Lock()
s.subscription.SetSessionContext(sessionCtx)
s.subscription.Unlock()
defer func() {
s.subscription.Lock()
s.subscription.SetSessionContext(nil)
s.subscription.Unlock()
}()
messageId, err := s.storeSource.PushStoreChange(ctx, source.PushStoreChangeParams{
Changes: builder.ChangeSet,
State: s.store,