From fac7c4f8fbd3dfa8c55d9e09f470e2d563b4ade6 Mon Sep 17 00:00:00 2001 From: AnastasiaShemyakinskaya Date: Fri, 23 Aug 2024 12:06:11 +0200 Subject: [PATCH] GO-3921: fix comments Signed-off-by: AnastasiaShemyakinskaya --- nodeconf/service.go | 8 ++++---- nodeconf/service_test.go | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/nodeconf/service.go b/nodeconf/service.go index c2cf3b77..274051e5 100644 --- a/nodeconf/service.go +++ b/nodeconf/service.go @@ -112,7 +112,7 @@ func (s *service) updateConfiguration(ctx context.Context) (err error) { return err } - if err = s.updateCompatibilityStatus(ctx, err); err != nil { + if err = s.updateCompatibilityStatus(ctx); err != nil { return err } @@ -123,7 +123,7 @@ func (s *service) updateConfiguration(ctx context.Context) (err error) { return nil } -func (s *service) updateCompatibilityStatus(ctx context.Context, err error) error { +func (s *service) updateCompatibilityStatus(ctx context.Context) error { needsUpdate, checkErr := s.networkProtoVersionChecker.IsNetworkNeedsUpdate(ctx) if checkErr != nil { return checkErr @@ -131,9 +131,9 @@ func (s *service) updateCompatibilityStatus(ctx context.Context, err error) erro if needsUpdate { s.setCompatibilityStatus(NetworkCompatibilityStatusNeedsUpdate) } else { - s.setCompatibilityStatusByErr(err) + s.setCompatibilityStatus(NetworkCompatibilityStatusOk) } - return err + return nil } func (s *service) saveAndSetLastConfiguration(ctx context.Context, last Configuration) error { diff --git a/nodeconf/service_test.go b/nodeconf/service_test.go index fafd56d5..90e0e280 100644 --- a/nodeconf/service_test.go +++ b/nodeconf/service_test.go @@ -68,7 +68,7 @@ func TestService_NetworkCompatibilityStatus(t *testing.T) { defer fx.finish(t) fx.run(t) time.Sleep(time.Millisecond * 10) - assert.Equal(t, NetworkCompatibilityStatusError, fx.NetworkCompatibilityStatus()) + assert.Equal(t, NetworkCompatibilityStatusOk, fx.NetworkCompatibilityStatus()) }) }