mirror of
https://github.com/VSadov/Satori.git
synced 2025-06-09 17:44:48 +09:00
458bb9efd1
If for a source project a contract project exists, then the contract project's TargetPath should be passed to the compiler. This is handled by the SDK by default when `ProduceReferenceAssembly` is true. As dotnet/runtime doesn't use the `ProduceReferenceAssembly` feature yet, a custom target adds the necessary `ReferenceAssembly` metadata to the `TargetPathWithTargetPlatformMoniker` item which then is transformed to references for the compiler. That works fine on the CLI as the `GetTargetPathWithTargetPlatformMoniker` target runs after the ProjectReference to the ContractProject is resolved and its target path is available. Inside VS the target ordering is different and the `ResolvedMatchingContract` item was empty as the ProjectReference to the contract wasn't yet resolved. The fix for that is to add a dependency onto the `ResolveProjectReferences` target to guarantee that the `ResolvedMatchingContract` item is populated in time. Noticed this when the build of System.ComponentModel.Composition.Registration failed because the implementation assembly of System.ComponentModel.Composition was passed to the compiler instead of the reference assembly.
55 lines
3.9 KiB
XML
55 lines
3.9 KiB
XML
<Project>
|
|
<PropertyGroup>
|
|
<!-- Use implementation referencepath if no contract dependency path is set.
|
|
This item transform is executed at the time this property is evaluated in the API Compat targets. -->
|
|
<ContractDependencyPaths Condition="'$(ContractDependencyPaths)' == ''">@(ReferencePath->'%(RelativeDir)'->Distinct())</ContractDependencyPaths>
|
|
<!-- Fall back to the targeting pack dir for NetCoreAppCurrent to avoid passing through dependencies from ref to src. -->
|
|
<ContractDependencyPaths Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', '$(NetCoreAppCurrent)'))">$(ContractDependencyPaths);$(MicrosoftNetCoreAppRefPackRefDir)</ContractDependencyPaths>
|
|
</PropertyGroup>
|
|
|
|
<PropertyGroup Condition="'$(IsSourceProject)' == 'true'">
|
|
<ContractProject Condition="'$(ContractProject)' == ''">$(LibrariesProjectRoot)$(MSBuildProjectName)\ref\$(MSBuildProjectName).csproj</ContractProject>
|
|
<HasMatchingContract Condition="'$(HasMatchingContract)' == '' and Exists('$(ContractProject)')">true</HasMatchingContract>
|
|
<!-- Disable API compat if the project doesn't have reference assembly -->
|
|
<RunApiCompat Condition="'$(HasMatchingContract)' != 'true'">false</RunApiCompat>
|
|
</PropertyGroup>
|
|
|
|
<ItemGroup Condition="'$(HasMatchingContract)' == 'true' and '$(ContractProject)' != '' and '@(ResolvedMatchingContract)' == ''">
|
|
<ProjectReference Include="$(ContractProject)" ReferenceOutputAssembly="false" OutputItemType="ResolvedMatchingContract" />
|
|
<!-- We aren't referencing the contract, but make sure it's considered as an input to Compile so that if it changes we rebuild and rerun API compat -->
|
|
<ProjectReference Include="$(ContractProject)" ReferenceOutputAssembly="false" OutputItemType="CustomAdditionalCompileInputs" />
|
|
</ItemGroup>
|
|
<!-- intentionally empty since we no longer need a target -->
|
|
<Target Name="ResolveMatchingContract" />
|
|
|
|
<!-- Allow P2Ps that target a source project to build against the corresponding ref project. -->
|
|
<Target Name="AnnotateTargetPathWithTargetPlatformMonikerWithReferenceAssembly"
|
|
Condition="'$(HasMatchingContract)' == 'true'"
|
|
DependsOnTargets="ResolveProjectReferences"
|
|
AfterTargets="GetTargetPathWithTargetPlatformMoniker">
|
|
<ItemGroup>
|
|
<TargetPathWithTargetPlatformMoniker ReferenceAssembly="@(ResolvedMatchingContract)" />
|
|
</ItemGroup>
|
|
</Target>
|
|
|
|
<Target Name="HandleReferenceAssemblyAttributeForProjectReferences"
|
|
AfterTargets="ResolveProjectReferences"
|
|
BeforeTargets="FindReferenceAssembliesForReferences"
|
|
Condition="'@(ProjectReference)' != '' and '@(_ResolvedProjectReferencePaths)' != ''">
|
|
<!-- If we have a ProjectReference to CoreLib, we need to compile against implementation assemblies. -->
|
|
<PropertyGroup Condition="@(_ResolvedProjectReferencePaths->AnyHaveMetadataValue('MSBuildSourceProjectFile', '$(CoreLibProject)'))">
|
|
<CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies>
|
|
</PropertyGroup>
|
|
<!-- Clear the ReferenceAssembly attribute on resolved P2Ps that set SkipUseReferenceAssembly to true. -->
|
|
<ItemGroup>
|
|
<_resolvedP2PFiltered Include="@(ProjectReference)">
|
|
<ProjectReferenceItemSpec>$([System.IO.Path]::GetFullPath('%(ProjectReference.Identity)'))</ProjectReferenceItemSpec>
|
|
<SkipUseReferenceAssembly>%(ProjectReference.SkipUseReferenceAssembly)</SkipUseReferenceAssembly>
|
|
</_resolvedP2PFiltered>
|
|
<_ResolvedProjectReferencePaths Update="@(_resolvedProjectReferenceFiltred)"
|
|
Condition="'%(_resolvedP2PFiltered.ProjectReferenceItemSpec)' == '%(_resolvedP2PFiltered.MSBuildSourceProjectFile)' and
|
|
'%(_resolvedP2PFiltered.SkipUseReferenceAssembly)' == 'true'"
|
|
ReferenceAssembly="" />
|
|
</ItemGroup>
|
|
</Target>
|
|
</Project>
|