1
0
Fork 0
mirror of https://github.com/VSadov/Satori.git synced 2025-06-08 11:37:04 +09:00
Commit graph

51 commits

Author SHA1 Message Date
Alexander Köplinger
c6eac1f2d5
Cleanup old corefx/coreclr GitHub issue links (#40286)
Replace them with the current URL after the redirect.

Similar to https://github.com/dotnet/runtime/pull/2063.

Co-authored-by: Steve Pfister <steve.pfister@microsoft.com>
2020-08-13 23:13:51 +02:00
Stephen Toub
e7204f5d6f
Use T? for unconstrained nullable types (#40197)
* Temporarily upgrade compiler version for T? support

* Use T? for unconstrained nullable types
2020-08-07 11:25:42 -04:00
Viktor Hofer
b7f809d7e3
Update docs for packaging and other nits (#40134)
* Update docs for packaging and other nits
2020-07-30 15:29:30 +02:00
Viktor Hofer
809a06f451
Remove depprojs in favor of PackageReferences (#35606)
- Remove depprojs which currently binplace external references into the RefPath folders in favor of PackageReference and PackageDownload items.
- Build all configurations by default when building an individual project (either on the CLI or inside VS) same as with the official SDK. This enables .NETFramework Test Explorer support.
- Centrally define libraries that compose the shared framework instead of in each Directory.Build.props file to be able to build the targeting pack first and consume it in the OOB libraries.
- Use ProjectReferences to reference OOB projects. Compile against the reference assembly but use the implementation assembly app-local during runtime.
- Remove OOBs from the testhost and remove the testhost folder for .NETFramework as it isn't required anymore.
- Only binplace for $(NetCoreAppCurrent) to compose a) the targeting pack, b) the runtime pack, c) the testhost, d) a full closure for the shims.
- Use Targeting Packs for OOB projects (with their implicit assembly references) but still explicitly define granular references for .NETCoreApp configurations (DisableImplicitAssemblyReferences switch). Use the implicit targeting pack references in some Microsoft.Extensions.* cases.
- Remove placeholder configurations as they aren't needed anymore with explicit P2Ps vs Targeting Pack references.
- Remove implicit assembly references (ie for .NETFramework, mscorlib)
- Remove AssemblySearchPath hacks that were introduced with b7c4cb7 as the targeting pack is now used by default.
- Reduce unnecessary .NETFramework configurations that were added to run tests in favor of the already existing ref&src configurations.
- Stop hardcoding the paths for wasm assemblies and use the returned TargetPath of the ProjectReferences.
- Addressed formatting (ItemGroups, References at the bottom of the project file, ordering of references, use LibrariesProjectRoot instead of a relative path, unnecessary AssemblyName and RootNamespace properties which are identical to the project name, ordering of tfms)
- Revert "fix clean (#33758)"
2020-07-23 17:20:26 +02:00
xtqqczze
4fdf9ff881
Markdown: Close anchor tags correctly (#38619) 2020-06-30 10:37:30 -07:00
Stephen Toub
3c9fcce29d
Disable P/Invoke analyzer (#38550) 2020-06-29 18:06:21 -04:00
Stephen Toub
3c278a3862
Update nullability.md 2020-06-25 11:21:14 -04:00
Stephen Toub
802103929a
Update nullability.md 2020-06-25 10:57:12 -04:00
Zoltán Lehóczky
54de085c2c
Fix typo in Framework Design Guidelines - Digest (#38307) 2020-06-23 17:04:00 -07:00
Larry Ewing
03b1ea75f3 Fix typo 2020-06-17 17:49:53 -05:00
Rich Lander
5018a64db8
Add proposal for breaking changes (#37779)
* Add proposal for breaking changes

Co-authored-by: Stephen Toub <stoub@microsoft.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Dan Moseley <danmose@microsoft.com>
2020-06-17 10:42:52 -07:00
Michal Strehovský
2a4284b9f3
Update steps to rebuild System.Runtime ref source (#38020)
Fixes #37966.
2020-06-17 05:48:07 -07:00
Steven Yeh
a589a173b4
Add Or int? (#37225) 2020-05-31 17:17:52 -04:00
Jeremy Koritzinsky
f62e93416a
Remove built-in WinRT support from the runtime (#36715) 2020-05-29 17:37:12 -07:00
Eirik Tsarpalis
1692e34e41
Document disabling ApiCompat checks (#37011)
* Document disabling ApiCompat checks
2020-05-26 18:50:18 +02:00
buyaa-n
abfdb542e8
Add NotNullIfNotNull, MemberNotNull attributes to doc (#36856) 2020-05-22 12:49:42 -07:00
Anirudh Agnihotry
322257f778
Use already defined generateAssemblyReferenceSource rather defining a new target (#35818)
* use arcade target

* extra space

* fixes generation of reference src from runtime projects

* run target to get genapi

* use referencePath to get references

* adding  GenerateReferenceSource target

* added the target name
2020-05-11 13:59:11 -07:00
Viktor Hofer
2cda9035cb
Use TargetFramework conditions consistently in libraries (#35956)
* Use TargetFramework condition consistently in libs

* Add docs section to describe the guideline

* Update Microsoft.Extensions.DependencyInjection.csproj

* Outline TargetFramework DesingTimeBuild issue

* Update Microsoft.Extensions.DependencyInjection.csproj
2020-05-11 11:00:11 -07:00
Viktor Hofer
000046f6c8
Change netcoreapp5.0 to net5.0 (#35176)
* Change netcoreapp5.0 to net5.0

* Remove tfm downgrades

* Rename S.R.CS.Unsfae include folder
2020-05-06 13:53:21 +02:00
Stephen Toub
3359a27075
Update nullability.md with note about Try methods and [NotNullWhen(true)] (#35711) 2020-05-01 11:56:39 -04:00
Jeremy Barton
0b32ef51dd
Update link from corefx to runtime (#35633) 2020-04-29 21:23:33 -04:00
Dan Moseley
ed6f88a734
Merge pinvoke guidelines into interop guidelines (#34833) 2020-04-10 16:46:56 -07:00
Viktor Hofer
42183b1b86
Enable restore for ref and src projects in libs (#33553)
- Use RestoreUseStaticGraphEvaluation which improves no-op restore by 10-15x down to 10-20 seconds.
- .builds msbuild files renamed to .proj as RestoreUseStaticGraphEvaluation throws for non .proj files without an env var set.
- Introducing subsets for libraries and mono and replacing -buildtests switch which was only working for libraries in favor of the subset switch -subset tests which works consistently.
- Fixing the Microsoft.DotNet.CodeAnalysis analyzer which wasn't running and adding missing exclusions.
- Separating restore and build phases in different parts in the repo (ie for installer.tasks) as generated props and targets need to be imported which requires a reevaluation in the build phase.
- Fix eng/docker/build-docker-sdk.ps1 by using the official build entrypoints (cc @alnikola)
- Remove a few depprojs in favor of project restore (faster restore :))
- Fix root code coverage measurement not working correctly
- Traversal support instead of dir.traversal.targets or manual build target defines.
- Introduce a root Build.proj entrypoint which is responsible for building and restoring the repository. This is necessary to enable the new NuGet fast restore which works best and fastest with a single entrypoint.
- Avoid binclashes in libraries and between libraries and installer (netstandard.depproj vs netstandard.csproj)
- Upgrading the SDK to 5.0 latest
- Code cleanup
2020-04-06 11:54:10 +02:00
Marcus Turewicz
59ec53edbc
Adds scripting guide doc (#34539)
Scripting guide for Shell, PowerShell and CMD files for styling or other guidance.

Fixes #9317
2020-04-04 20:13:17 -07:00
Borislav Ivanov
97b95ad197
Update formatting (#34538) 2020-04-04 09:28:45 -07:00
Jan Kotas
19c7f5a704
Rename ArchGroup -> TargetArchitecture (#34260)
Most places use TargetArchitecture already. These two properties seems to be always set to the same value.
2020-03-29 17:20:20 -07:00
Jan Kotas
479067315a
.NET Core to .NET branding changes (#33694)
Contributes to #33680
2020-03-28 07:00:19 -07:00
Viktor Hofer
73268c790b
Revert "Enable restore for ref and src projects in libraries (#33242)" (#33437)
This reverts commit 981cc64bc4.
2020-03-10 21:33:27 +01:00
Viktor Hofer
981cc64bc4
Enable restore for ref and src projects in libraries (#33242)
* Enable restore for projects in libraries

Enabling project restore for ref and src projects

* Remove winrt.depproj

* Remove tools.depproj

* Enable upfront restore

* Fix casing of PInvokeAnalyzerException file

* Remove harvestPackages.depproj and refactoring

Removing havestPackages.depproj in favor of a target that is hooked
into Arcade's repo restore phase in Tools.props.

Additionally moving common properties that are used both in Arcade and
the repo inside Configurations.props. Before they were scattered around
multiple places (Versions.props, Subsets.props).

* Set ilasm/ildasm RID for restore

* Sequence restore into steps out of upfront restore

* Fix docker entrypoints by using build.cmd/sh
2020-03-10 13:48:20 +01:00
Anirudh Agnihotry
fef9ca70f6
Replacing OSGroup with TargetOS for coreclr, libraries and installer (#32833)
* Remove OSGroup from coreclr and corefx

* remove from installer

* fixing coreclr tests

* Some documentation changes

Co-Authored-By: Viktor Hofer <viktor.hofer@microsoft.com>

* moving buildos calculation to config.props

* BuildOS -> TargetOS

* remove osgroup suffix

* removing comment and correcting typo

* dotnet msbuild -> dotnet build at relevant places in docs

* moving more properties to configuration.props

* refactoring properties

* moving TargetArchitecture property to loveBuildd.Targets

* adding configuration.props to signing

* Fix installer build

* BuildOS -> Target os and removing slash

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
2020-03-05 07:51:06 -08:00
Viktor Hofer
33f2807fc6
Remove BuildAndTest and RebuildAndTest target in favor of Test (#33151)
* Implicitly build when invoking the test target

To get closer to the VSTest behavior this changes the Test target to
implicitly invoke the Build target unless /p:TestNoBuild is passed in.
(VSTest uses VSTestNoBuild which is controlled by the
dotnet test --no-build flag)

* Fix error logging for test outputs

* Update dotnet msbuild to build docs

* Update ReportGenerator global tool version

Updating ReportGenerator's version to 4.5.0 which removes unnecessary
logging (args passed in).
2020-03-04 19:40:19 +01:00
Dan Moseley
8497763bbf
Fix another 58 URL's (#33003) 2020-02-28 18:54:32 -08:00
Anirudh Agnihotry
86a086377b
updating docs and removing BuildConfiguration and ConfigurationGroup (#32062)
* build config and update docs

* remove configurationGroup and update docs

* addressing feedback

* viktor comments
2020-02-20 14:39:38 -08:00
Levi Broderick
e9c8f6a778
Fix broken MSDN blogs links (#32273) 2020-02-14 08:34:15 -08:00
Jan Kotas
8911889d8b
Cleanup outdated docs (#21915)
* Delete outdated redundant PR docs

* Delete outdated docs

* Delete portability analyzer docs

Outdates and redundant with official documentation
2020-01-31 08:00:05 -08:00
Santiago Fernandez Madero
0515878d1e
Remove workarounds in build scripts for netcoreapp and netfx versionless (#1841)
* Remove workarounds in build scripts for netcoreapp and netfx versionless

* Don't pass down netcoreapp in yml builds

* PR Feedback and condition passing -framework arg when not empty in yml files

* Condition TargetGroup global property in helix.yml

* PR Feedback to not use targetgroup for allconfigurations in sendtohelix

* Change from PackageTesting to BuildAllConfigurations
2020-01-27 12:13:14 -08:00
Youssef Victor
8f2404db61 corefx => runtime (#2068)
* corefx => runtime

* Update adding-api-guidelines.md

* Update adding-api-guidelines.md
2020-01-24 09:30:18 -08:00
Santiago Fernandez Madero
66148892f1 Merge remote-tracking branch 'dotnet/master' into RemoveNetcoreappNetfxBuildScripts 2020-01-23 10:30:39 -08:00
Youssef Victor
1d84023aec Use 4 spaces in coding-style.md examples (#2066) 2020-01-23 05:52:33 -08:00
Santiago Fernandez Madero
6b101e01c3 Remove workarounds in build scripts for netcoreapp and netfx versionless 2020-01-16 15:21:43 -08:00
Carlos Sanchez Lopez
3ad3b6fe71 Add documentation guidelines when adding new APIs (#1335)
* Add documentation guidelines when adding new APIs

* Update docs/coding-guidelines/adding-api-guidelines.md

Co-Authored-By: Dan Moseley <danmose@microsoft.com>

* Update docs/coding-guidelines/adding-api-guidelines.md

Co-Authored-By: Dan Moseley <danmose@microsoft.com>

* Update docs/coding-guidelines/adding-api-guidelines.md

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

* Update docs/coding-guidelines/adding-api-guidelines.md

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

* Update docs/coding-guidelines/adding-api-guidelines.md

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

Co-authored-by: Dan Moseley <danmose@microsoft.com>
Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
2020-01-06 16:57:05 -05:00
Dan Moseley
9900dfb4b2
Organize some markdowns and fix links (#1159)
* Move files into hierarchy

* fix more links

* Fix botr and features links

* Remove bad apostrophe

* spelling

* Apply suggestions from code review

Co-Authored-By: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>

* Update docs/coding-guidelines/package-projects.md

Co-Authored-By: Jan Kotas <jkotas@microsoft.com>

Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
2019-12-26 15:22:57 -08:00
Stephen Toub
d605591504 Revert workarounds for IEquatable and nullable (#795)
Roslyn now special-cases IEquatable to be contravariant for nullable, so we can remove our workarounds.
2019-12-13 12:51:34 -06:00
Stephen Toub
5e67c2480d
Update nullability.md 2019-12-11 21:21:23 -05:00
Stephen Toub
1af1d3d3fa
Update nullability.md 2019-12-11 21:04:55 -05:00
Roman Marusyk
00813dfd30 Update links (#537) 2019-12-06 10:22:40 +01:00
Stephen Toub
d47a8eb541
Update nullability.md 2019-12-04 22:00:49 -05:00
Stephen Toub
5adc310324
Update nullability.md with notes on disposal 2019-12-04 22:00:14 -05:00
Youssef Victor
15b5c33507 corefx -> runtime (#407) 2019-11-30 09:41:17 -05:00
Drew Noakes
12894380bb Remove references to gender (#262) 2019-11-26 15:33:12 +01:00