VSadov/Satori
1
0
Fork 0
mirror of https://github.com/VSadov/Satori.git synced 2025-06-09 17:44:48 +09:00
Code Activity
129510 commits 55 branches 3 tags 788 MiB
Commit graph

174 commits

Author SHA1 Message Date
Jackson Schuster
f3e6b1bbe3
[ComInterfaceGenerator] Recommend [In] and [Out] attributes on array parameters (#91094) 
Recommend that methods with array parameters use [In] or [Out] attributes if there are none already, and the parameter is not in, ref, or out.
 2023-08-25 16:04:13 -07:00
Layomi Akinrinade
a5ff66c825
Use Roslyn interceptors feature in binder gen (#90340) 
* Use Roslyn interceptors feature in binder gen

* Fix polymorphic issue and address feedback

* Fix source build issue

* Revert changes to options gen

* Fix
 2023-08-19 09:16:49 -07:00
Tarek Mahmoud Sayed
9d747c9e7f
Limit language version on Logger and Options source gens (#90654) 2023-08-16 16:55:41 -07:00
Jackson Schuster
531ad9596f
Add Info warning for int return values (#89601) 
Adds an 'info' level diagnostic if a GeneratedComInterface method returns int, enum, or a type name "HR" or "HResult" to tell the user that the generated code will put the managed return value as an 'out' parameter on the COM definition.

Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
 2023-08-01 16:15:21 -07:00
Eirik Tsarpalis
84873e6c4e
Ensure System.Text.Json SG diagnostics don't use Location values from referenced assemblies. (#89518) 2023-07-27 13:13:27 +01:00
Eirik Tsarpalis
5bc100ed64
Emit a diagnostic when attributes deriving from JsonConverterAttribute are being used. (#89199) 
* Emit a diagnostic when attributes deriving from JsonConverterAttribute are being used.

* Address feedback.
 2023-07-21 17:23:44 +01:00
Tarek Mahmoud Sayed
24150b3a6d
Fix options source gen with non-accessible validation attributes (#88613) 2023-07-11 16:55:43 -07:00
Eirik Tsarpalis
24d7f5a58a
Extend JsonIncludeAttribute and JsonConstructorAttribute support to internal and private members (#88452) 
* Relax JsonIncludeAttribute to also support private or internal members.

* Relax JsonConstructorAttribute to include internal or private constructors (where applicable).
 2023-07-07 12:40:29 +01:00
Nikita Balabaev
779d53611e
Fix OptionsValidator source-gen to skip static and const members (#88254) 
Co-authored-by: Nikita Balabaev <nbalabaev@microsoft.com>
 2023-07-02 11:37:07 -07:00
Eirik Tsarpalis
dbf3a16dba
Document new STJ diagnostics and fix diagnostic id conflicts. (#87980) 2023-06-26 16:38:12 +01:00
Tarek Mahmoud Sayed
de6f07edd2
Options validation source generator (#87587) 2023-06-20 14:56:21 -07:00
Jackson Schuster
6ea11b5578
Add marshalling tests and warn if interface is not partial (#87146) 
Adds tests that marshal different types to and from native, and adds a warning if the interface or any containing types are not marked partial.
 2023-06-09 15:25:44 -07:00
Jeremy Koritzinsky
4d52032d95
Add analyzers and code-fixes to help adoption of source-generated COM (#87223) 
* Add first pass of the "convert to generated COM interface" analyzer and add tests for the various other analyzers we are going to introduce.

* Get all analyzer-specific components of the "convert" tests passing.

* Implement all interface-attribute-level changes in the code fixer.

* Add bool marshalling insertion logic to the fixer.

* Add support for removing shadowing members from interfaces.

* Rename fixer

* ActiveIssue the new tests

* Implement basic AddGeneratedComClass analyzer/fixer

* Add ComHosting + GeneratedComInterface analyzer implementation.

* Implement the "runtime COM APIs with source-generated COM types" analyzer.

* Factor out a base class from the ConvertToLibraryImportFixer so we can share it with the ComInterfaceGenerator-family of fixers.

* Move more of the ConvertToLibraryImportFixer to use SyntaxGenerator APIs instead of dropping to C#-specific syntax APIs (improves consistency throughout our code fixes)

* Move support for specifying explicit boolean marshalling rules up to the base class.

* Move the code fixes in ComInterfaceGenerator over to using the ConvertToSourceGeneratedInteropFixer base type.

* Remove use of multicasted delegates and use a more traditional "array of delegates" model.

* Do some refactoring to move more into the new fixer base class.

* Remove custom CodeAction-derived types now that we have a record type to represent fixes from the subclasses.

* Make sure we make types and containing types partial

* Fix negative test.

* Add tests for transitive interface inheritance and add iids.

* Change bool parsing for internal parsing and add warning annotation text. Update diagnostics list md.
 2023-06-08 20:36:25 -07:00
Sven Boemer
56c427bb4d
Don't enable ILLink analyzers for unsupported TFMs (#87071) 
* Don't enable ILLink analyzers for unsupported TFMs

This adds a condition to EnableSingleFileAnalyzer to prevent it from requiring
the ILLink pack that is only supported on netcoreapp3.0 and above.

Adding a condition on the TFM requires moving the setting into a targets file.

Also consolidates more of the analyzer logic into this file.

---------

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
 2023-06-08 10:10:58 -07:00
Layomi Akinrinade
ac5febd6b7
Update binder gen parser to issue diagnostics for invalid input types (#86856) 
* Update binder gen parser to issue diagnostics for invalid input types

* Address feedback; tests for more invalid types; fix failing CI test
 2023-06-01 09:33:36 -07:00
Kevin Jones
04a1fe3059
Implement AesGcm constructors accepting a tag size and obsolete the existing ones 2023-05-15 13:28:00 -04:00
Bonuspunkt
a15eaf7440
link to the latest version of Framework Design Guidelines (#86216) 
also added Jeremy Barton because he was inconsistently mentioned
 2023-05-15 09:58:01 -04:00
github-actions[bot]
5eef91d51a
[main] Servicing docs improvements (#85855) 
* Servicing docs improvements

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>

* Apply suggestions from code review

* Update .github/workflows/check-service-labels.yml

* Update .github/workflows/check-service-labels.yml

---------

Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
Co-authored-by: Juan Hoyos <19413848+hoyosjs@users.noreply.github.com>
 2023-05-08 17:38:34 -06:00
Stephen Toub
6887fc439b
Obsolete some protected, unused members of Regex{Runner} (#84812) 2023-04-20 06:14:25 -04:00
Sergio Pedri
1079a04a76
Include Include ADO azure-feed:// URI in dogfooding docs (#84844) 2023-04-14 17:46:36 +02:00
Jeremy Koritzinsky
e4743ec947
Move our RHEL7-based runtime dependencies packages to instead be built for CentOS Stream/OracleLinux/RHEL 8. (#84805) 2023-04-13 16:53:05 -07:00
Levi Broderick
1487522704
Obsolete most of the remaining legacy serialization APIs (#84383) 
- Move BinaryFormatter obsoletions to type-level
- Introduce SYSLIB0050 and SYSLIB0051 obsoletion waves
- Remove some dead code

Ref: https://github.com/dotnet/designs/pull/293
 2023-04-10 22:52:15 -07:00
Levi Broderick
dd44d52b91
Reserving two diagnostic codes for serialization work (#84439) 2023-04-06 14:01:00 -07:00
Jeff Handley
0f41c072d7
Update API Review Process doc with updated link and blurb (#84133) 2023-03-30 16:23:45 -04:00
Eirik Tsarpalis
e43ddbf9dc
Revert #80698 and obsolete JsonSerializerOptions.AddContext (#84022) 
* Revert 9a6686be5d.

* Obsolete JsonSerializerOptions.AddContext
 2023-03-30 12:40:48 +01:00
Layomi Akinrinade
9111203d54
Set minimum language version allowed by config binding generator (#83996) 
* Set minimum language version allowed by config binding generator

* Address feedback; use correct diagnostic severity
 2023-03-28 21:47:17 -07:00
Carlos Sánchez López
531bf3c02c
Update backport template and servicing docs (#83795) 
* Update backport template to indicate new staging branches rule.

* Update library servicing.
 2023-03-28 10:34:21 -06:00
Layomi Akinrinade
be8d451636
Create source generator for configuration binding (#82179) 
* Create source generator for configuration binding

* Add baseline tests

* Rename test project folders

* Avoid passing entire compilation to generator execute method

* Enable nullable

* Add logic to include generator in nuget package and enable it conditionally

* Address feedback
 2023-03-16 14:42:38 -07:00
Adeel Mujahid
3b63eb1346
Replace remaining instances of COMPlus with DOTNET (#82985) 
* Replace remaining instances of COMPlus with DOTNET

* Fix heading in RyuJIT tutorial
 2023-03-05 08:40:20 -08:00
Kasper Fabæch Brandt
38b6c82216
Glossary: Change SoS link to documentation and describe origin in description. (Was: Change source for SoS to Wayback Machine link) (#81178) 
* Glossary: Change source for SoS to Wayback Machine link

The page seems to have disappeared in the currently archived version of Jason Zander's blog at https://learn.microsoft.com/en-us/archive/blogs/jasonz/ - so replace it with a Wayback Machine link to an archived version.

* Link to official documentation for SOS instead and mention origin of name in the description.
 2023-03-02 11:32:01 -05:00
Jeremy Koritzinsky
0717edad58
Create skeleton for the ComInterfaceGenerator (#80887) 
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
 2023-02-15 13:03:41 -08:00
Jeff Tyson
725de9e7bb
Add additional case where public signing cannot be used (#77998) 2023-02-10 18:11:36 -08:00
Allan Targino
8521541d63
diagnostic to detect malformed format strings in lsg template message (#81503) 
fix https://github.com/dotnet/runtime/issues/52226
 2023-02-05 11:19:43 -08:00
Jeff Handley
89fe29a717
Fix formatting in list-of-diagnostics.md (#81396) 
* Fix formatting in list-of-diagnostics.md

I noticed the page currently renders with dangling `_` characters. This change cleans up the markdown formatting, changing the redundant `*_` to `_` and ensuring each is paried correctly.

I also improved alignment of the suppression table columns.

* Update docs/project/list-of-diagnostics.md

---------

Co-authored-by: Stephen Toub <stoub@microsoft.com>
 2023-01-31 11:23:29 -05:00
Youssef Victor
1b22d373f2
Update analyzers.md (#79768) 
* Update analyzers.md

* Apply suggestions from code review

* Update analyzers.md

* Apply suggestions from code review

Co-authored-by: Stephen Toub <stoub@microsoft.com>

* Apply suggestions from code review

---------

Co-authored-by: Stephen Toub <stoub@microsoft.com>
 2023-01-27 10:53:39 -05:00
Jackson Schuster
1630725383
Create analyzer in ComInterfaceGenerator to enforce the generator is used with IUnknown only (#78189) 
Creates an analyzer that warns if the GeneratedComInterfaceAttribute is
used with InterfaceTypeAttribute that has an argument that is not
'InterfaceIsIUnknown'
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
Co-authored-by: Elinor Fung <elfung@microsoft.com>
 2023-01-12 11:48:25 -08:00
Allan Targino
fd9f52098b
Adds diagnostics to detect duplicated event names in LSG (#80460) 
fixes https://github.com/dotnet/runtime/issues/64667
 2023-01-11 07:29:18 -08:00
Allan Targino
71bb0d4810
Adds diagnostic for out parameter in LSG (#80458) 
fixes https://github.com/dotnet/runtime/issues/64665
 2023-01-10 15:45:30 -08:00
Adam Sitnik
b577e6b514
perfcollect docs: run two commands instead of three (#76325) 2023-01-09 19:53:02 +01:00
Rich Lander
7f83765928
Update copyright guidance for Creative Commons (#80272) 
* Update copyright guidance

* Update link

* Remove space

* Add public domain link

* Update CONTRIBUTING.md

* Update docs/project/copyright.md

Co-authored-by: Theodore Tsirpanis <teo@tsirpanis.gr>

* Update per feedback

* Address linter error

* Clean up wording

* Update links

* Clean up wording

Co-authored-by: Theodore Tsirpanis <teo@tsirpanis.gr>
 2023-01-06 14:04:02 -08:00
Dan Moseley
734cd446f8
Update api-review-process.md (#77860) 
* Update api-review-process.md

* Update docs/project/api-review-process.md

Co-authored-by: Stephen Toub <stoub@microsoft.com>

Co-authored-by: Stephen Toub <stoub@microsoft.com>
 2022-11-04 11:25:42 -04:00
Egor Bogatov
9e7a8a1b31
Add "_generated.*" suffix to some auto-generated files (#77083) 
* Add _generated.h to src\coreclr\jit\ICorJitInfo_API_names.h

* Add _generated.h to src\coreclr\jit\ICorJitInfo_API_wrapper.hpp

* renamed src\coreclr\tools\Common\JitInterface\CorInfoBase.cs

* fix ThunkGenerator (it used to insert two empty lines)

* CorInfoBase_generated.cs -> CorInfoImpl_generated.cs

* Drop _API_ part

* Rename icorjitinfo.cpp

* jitinterface.h -> _generated

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
 2022-10-15 17:49:12 -07:00
Robin Lindner
d653f2bb39
Obsolete RSA.EncryptValue and RSA.DecryptValue 2022-10-05 10:38:59 -07:00
Jan Kotas
32ac664fca
Replace net7 with net8 in dogfooding and workflow docs (#75453) 2022-09-12 20:40:44 -07:00
N0D4N
126045ca05
Repoint urls in docs (#73766) 2022-08-14 18:56:07 -06:00
Levi Broderick
d2afae4fb0
Obsolete XmlSecureResolver (#73676) 
- Add XmlResolver.ThrowingResolver
- Migrate all call sites to the new API
- Improve error messages on failure

Resolves CVE-2022-34716.
 2022-08-12 12:55:05 -07:00
Jeff Handley
ad7feeb55b
Rename 'up-for-grabs' label to 'help wanted' (#73810) 2022-08-12 13:20:59 -06:00
Pavel Savara
222da17b8d
[wasm] JSImport generator AllowUnsafeBlocks diagnostic (#72996) 
- added `JSImportAttribute requires unsafe code` + unit test
- fixed Diagnostic IDs + reservation
- moved System.Runtime.InteropServices.JavaScript.UnitTests to subfolder
 2022-07-29 19:48:06 +02:00
Anton Lapounov
d365ff2e86
Implement ControlledExecution API (#71661) 2022-07-27 23:38:38 -07:00
Adeel Mujahid
b0090d0a4f
Rename [RegexGenerator] to [GeneratedRegex] (#72434) 
Co-authored-by: Jose Perez Rodriguez <joperezr@microsoft.com>
 2022-07-27 17:14:53 -07:00