1
0
Fork 0
mirror of https://github.com/VSadov/Satori.git synced 2025-06-12 10:40:30 +09:00

Add forward-focused comments per review

Commit migrated from 4650eed868
This commit is contained in:
Davis Goodin 2019-06-26 10:07:13 -05:00
parent 9f361272eb
commit ce70fc8243
4 changed files with 13 additions and 5 deletions

View file

@ -19,7 +19,10 @@
<!--
Arcade specifies a default en-US NeutralLanguage, which creates a
System.Resources.NeutralResourcesLanguageAttribute that doesn't compile with existing
references for PlatformAbstractions on netstandard1.3. Remove it for now.
references for PlatformAbstractions on netstandard1.3. Clearing NeutralLanguage removes it.
If this Arcade SDK feature is desired in the future, this will need to be worked through. No
issue tracks this as of writing.
-->
<NeutralLanguage></NeutralLanguage>
</PropertyGroup>

View file

@ -198,7 +198,8 @@
<!--
Ensure the pkgproj is already built. This isn't a real ProjectReference because the SDK doesn't
seem to handle pkgproj nicely for Publish. For now we're using its nupkg directly.
seem to handle pkgproj nicely for Publish. For now, we're using its nupkg directly. In the
future, this will be handled in shared tooling to generate shared frameworks in the Arcade SDK.
-->
<Target Name="BuildPkgProjectReferences">
<MSBuild Projects="@(PkgProjectReference)" Targets="Build" />

View file

@ -4,7 +4,10 @@
<SfxIdentity>Microsoft.NETCore.App</SfxIdentity>
<SfxPackageIdentity>$(SfxIdentity).Internal</SfxPackageIdentity>
<!-- Lay out the sfx in the legacy location for old packaging to keep working for now. -->
<!--
Lay out the sfx in the legacy location for old packaging to keep working for now. This can be
removed when the legacy infra is phased out.
-->
<SharedFrameworkLayoutDir>$(SharedFrameworkPublishDir)</SharedFrameworkLayoutDir>
<GenerateRuntimeGraph>true</GenerateRuntimeGraph>
@ -22,7 +25,8 @@
<!--
Make sure the installer file is generated with the old infra's name and location. This allows
the existing infra to bundle it without any changes.
the existing infra to bundle it without any changes. This can be removed when the legacy infra
is phased out.
-->
<Target Name="PutSharedFrameworkMsiInLegacyLocation"
DependsOnTargets="GetInstallerLocations"

View file

@ -38,7 +38,7 @@
<Reference Include="System.IO.Compression" />
</ItemGroup>
<!-- Remove source that require BuildTools to compile. -->
<!-- TODO: (arcade) Add this back, needed for publishing. Removed because it requires BuildTools to compile. -->
<ItemGroup>
<Compile Remove="FinalizeBuild.cs" />
</ItemGroup>