VSadov/Satori
1
0
Fork 0
mirror of https://github.com/VSadov/Satori.git synced 2025-06-09 17:44:48 +09:00
Code Activity

React to APICompat changes enabling reverse APICompat for facades (dotnet/corefx#37375)

Browse source 
* React to APICompat changes enabling reverse APICompat for facades

* Fix UAP and NETFX reverse APICompat issues

* Fix reverse APICompat baseline for allconfigurations build

* Manually update to latest APICompat

* Manually update to latest CoreCLR and fix issues

* Baseline System.Threading.Tasks

* Revert "Manually update to latest CoreCLR and fix issues"

This partially reverts commit dotnet/corefx@ee800617b6.

I'm keeping the baseline changes which will be needed when we get a new update.

* Temporarily baseline DiagnosticCounter API gaps

This can be removed when get a new CoreCLR

That's currently blocked due to regressions in tests.


Commit migrated from 035343743c
This commit is contained in:
Eric StJohn 2019-05-07 19:46:58 -07:00 • committed by GitHub
parent 6652110901
commit afd313db03
30 changed files with 284 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

15
eng/resolveContract.targets
View file

@ -2,7 +2,10 @@
<PropertyGroup Condition="'$(IsSourceProject)' == 'true'">
<ContractProject Condition="'$(ContractProject)' == ''">$(SourceDir)/$(MSBuildProjectName)/ref/$(MSBuildProjectName).csproj</ContractProject>
<HasMatchingContract Condition="'$(HasMatchingContract)' == '' and Exists('$(ContractProject)')">true</HasMatchingContract>
<ContractAssemblyPath Condition="'$(ContractAssemblyPath)' == ''">$(ContractOutputPath)/$(MSBuildProjectName).dll</ContractAssemblyPath>
<ContractAssemblyPath Condition="'$(ContractAssemblyPath)' == ''">$(RefPath)/$(MSBuildProjectName).dll</ContractAssemblyPath>
<!-- Disable API compat if the project doesn't have reference assembly -->
<RunApiCompat Condition="'$(HasMatchingContract)' != 'true'">false</RunApiCompat>
</PropertyGroup>
<ItemGroup Condition="'$(HasMatchingContract)' == 'true'">
@ -17,7 +20,13 @@
<!-- intentionally empty since we no longer need a target -->
<Target Name="ResolveMatchingContract" />
<Target Name="VerifyMatchingContract" AfterTargets="ResolveReferences">
<Error Condition="'$(HasMatchingContract)' == 'true' and !Exists('%(ResolvedMatchingContract.Identity)')" Text="ResolveMatchingContract could not find a matching contract '%(ResolvedMatchingContract.Identity)' not found." />
<!-- Disable matching ref API compat for aot runtime refencing libs, these have a lot of public API
only by implementation and we don't intend to start new API development on AOT -->
<Target Name="DisableRunMatchingRefApiCompat"
BeforeTargets="CoreCompile"
Condition="'$(TargetsAot)' == 'true' AND '@(ReferenceFromRuntime)' != ''">
<PropertyGroup>
<RunMatchingRefApiCompat>False</RunMatchingRefApiCompat>
</PropertyGroup>
</Target>
</Project>