VSadov/Satori
1
0
Fork 0
mirror of https://github.com/VSadov/Satori.git synced 2025-06-09 17:44:48 +09:00
Code Activity

System.Runtime.Serialization.Formatters: fix target framework check for source-build. (#104735)

Browse source 
* System.Runtime.Serialization.Formatters: fix target framework check for source-build.

The inbox implementation should no longer include a working binary formatter.

The check used to build a working formatter was '$(TargetFramework)' == '$(NetCoreAppMinimum)'.

Because NetCoreAppMinimum gets set to TargetFramework in the source-build configuration,
the source-build configuration unintentionally included a working binary formatter.

* Don't build the net8.0 target when DotNetBuildSourceOnly.

* Join lines.
This commit is contained in:
Tom Deseyn 2024-07-12 11:46:35 +02:00 • committed by GitHub
parent 42b2b19e88
commit 9b09bcfada
Signed by: github
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/libraries/System.Runtime.Serialization.Formatters/src/System.Runtime.Serialization.Formatters.csproj
View file

@ -12,7 +12,7 @@
<PropertyGroup> <PropertyGroup>
<NoWarn>$(NoWarn);CA1822;IDE0060</NoWarn> <NoWarn>$(NoWarn);CA1822;IDE0060</NoWarn>
<FunctioningBinaryFormatter Condition="'$(TargetFramework)' == '$(NetCoreAppMinimum)'">true</FunctioningBinaryFormatter> <FunctioningBinaryFormatter Condition="'$(TargetFramework)' == '$(NetCoreAppMinimum)' and '$(DotNetBuildSourceOnly)' != 'true'">true</FunctioningBinaryFormatter>
<!-- The GenerateNuspec target fails if this property is keyed off of FunctioningBinaryFormatter, so keep it logically in sync --> <!-- The GenerateNuspec target fails if this property is keyed off of FunctioningBinaryFormatter, so keep it logically in sync -->
<IncludeBuildOutput Condition="'$(TargetFramework)' == '$(NetCoreAppCurrent)'">false</IncludeBuildOutput> <IncludeBuildOutput Condition="'$(TargetFramework)' == '$(NetCoreAppCurrent)'">false</IncludeBuildOutput>
<SuppressDependenciesWhenPacking Condition="'$(FunctioningBinaryFormatter)' != 'true'">true</SuppressDependenciesWhenPacking> <SuppressDependenciesWhenPacking Condition="'$(FunctioningBinaryFormatter)' != 'true'">true</SuppressDependenciesWhenPacking>