VSadov/Satori
1
0
Fork 0
mirror of https://github.com/VSadov/Satori.git synced 2025-06-12 02:30:29 +09:00
Code Activity

Globally disable implicit namespaces (#56348)

Browse source
This commit is contained in:
Santiago Fernandez Madero 2021-07-26 23:22:08 -07:00 • committed by GitHub
parent 08605bf193
commit 7545f986f9
Signed by: github
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Directory.Build.props
View file

@ -280,6 +280,9 @@
<AppDesignerFolder>Properties</AppDesignerFolder> <AppDesignerFolder>Properties</AppDesignerFolder>
<!-- By default the SDK produces ref assembly for 5.0 or later --> <!-- By default the SDK produces ref assembly for 5.0 or later -->
<ProduceReferenceAssembly>false</ProduceReferenceAssembly> <ProduceReferenceAssembly>false</ProduceReferenceAssembly>
<!-- We have very special projects that don't always contain default references. We also build MSBuild Tasks
and there are some implicit namespaces that clash, i.e System.Threading.Tasks. -->
<DisableImplicitNamespaceImports>true</DisableImplicitNamespaceImports>
</PropertyGroup> </PropertyGroup>
<PropertyGroup> <PropertyGroup>

1
src/coreclr/tools/Directory.Build.props
View file

@ -4,7 +4,6 @@
<IsShipping>false</IsShipping> <IsShipping>false</IsShipping>
<SignAssembly>false</SignAssembly> <SignAssembly>false</SignAssembly>
<RunAnalyzers>false</RunAnalyzers> <RunAnalyzers>false</RunAnalyzers>
<DisableImplicitNamespaceImports_DotNet>true</DisableImplicitNamespaceImports_DotNet>
</PropertyGroup> </PropertyGroup>
<!-- MSBuild doesn't understand the Checked configuration --> <!-- MSBuild doesn't understand the Checked configuration -->

4
src/libraries/Directory.Build.targets
View file

@ -59,10 +59,6 @@
'$(DisableImplicitFrameworkReferences)' != 'true' and '$(DisableImplicitFrameworkReferences)' != 'true' and
'$(TargetFrameworkIdentifier)' == '.NETCoreApp' and '$(TargetFrameworkIdentifier)' == '.NETCoreApp' and
('$(IsReferenceAssembly)' == 'true' or '$(IsSourceProject)' == 'true')">true</DisableImplicitAssemblyReferences> ('$(IsReferenceAssembly)' == 'true' or '$(IsSourceProject)' == 'true')">true</DisableImplicitAssemblyReferences>
<!-- When we disable implicit assembly references disabling namespace imports is not handled by the SDK as this is our custom
way to disable assembly references for OOBs. -->
<DisableImplicitNamespaceImports Condition="'$(DisableImplicitAssemblyReferences)' == 'true'">true</DisableImplicitNamespaceImports>
</PropertyGroup> </PropertyGroup>
<Import Project="$(RepositoryEngineeringDir)versioning.targets" /> <Import Project="$(RepositoryEngineeringDir)versioning.targets" />