From 45f69528832f3c1076bf990d3a599580aed762e0 Mon Sep 17 00:00:00 2001 From: Ahmet Ibrahim Aksoy Date: Thu, 1 Aug 2024 13:50:19 +0200 Subject: [PATCH] Fix condition to run CertificateCallbackThrowPropagates test on msquic 2.4 and higher (#105789) * Fix condition * Apply suggestions from code review Co-authored-by: Radek Zikmund <32671551+rzikm@users.noreply.github.com> --------- Co-authored-by: Radek Zikmund <32671551+rzikm@users.noreply.github.com> --- .../System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs b/src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs index 77acbfa2e4f..2bcdad52c83 100644 --- a/src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs +++ b/src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs @@ -52,7 +52,7 @@ namespace System.Net.Quic.Tests { private static byte[] s_data = "Hello world!"u8.ToArray(); readonly CertificateSetup _certificates; - static bool SupportsAsyncCertValidation => QuicTestCollection.MsQuicVersion >= new Version(2, 4); + static bool DoesNotSupportAsyncCertValidation => QuicTestCollection.MsQuicVersion < new Version(2, 4); public MsQuicTests(ITestOutputHelper output, CertificateSetup setup) : base(output) { @@ -354,7 +354,7 @@ namespace System.Net.Quic.Tests } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/99074", typeof(MsQuicTests), nameof(SupportsAsyncCertValidation))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/99074", typeof(MsQuicTests), nameof(DoesNotSupportAsyncCertValidation))] public async Task CertificateCallbackThrowPropagates() { using CancellationTokenSource cts = new CancellationTokenSource(PassingTestTimeout);