VSadov/Satori
1
0
Fork 0
mirror of https://github.com/VSadov/Satori.git synced 2025-06-08 03:27:04 +09:00
Code Activity

Remove BuildAndTest and RebuildAndTest target in favor of Test (#33151)

Browse source 
* Implicitly build when invoking the test target

To get closer to the VSTest behavior this changes the Test target to
implicitly invoke the Build target unless /p:TestNoBuild is passed in.
(VSTest uses VSTestNoBuild which is controlled by the
dotnet test --no-build flag)

* Fix error logging for test outputs

* Update dotnet msbuild to build docs

* Update ReportGenerator global tool version

Updating ReportGenerator's version to 4.5.0 which removes unnecessary
logging (args passed in).
This commit is contained in:
Viktor Hofer 2020-03-04 19:40:19 +01:00 • committed by GitHub
parent a648aa1499
commit 33f2807fc6
Signed by: github
GPG key ID: 4AEE18F83AFDEB23
25 changed files with 69 additions and 72 deletions
Download patch file Download diff file Expand all files Collapse all files

4
docs/coding-guidelines/adding-api-guidelines.md
View file

@ -33,12 +33,12 @@ should be added to `netcoreapp5.0`. [More Information on TargetFrameworks](https
- If changing the target framework
- Update `SupportedFramework` metadata on the ref ProjectReference to declare the set of concrete platforms you expect your library to support. (see [Specific platform mappings][net-standard table]). Generally will be a combination of netcoreapp2.x, netfx46x, and/or `$(AllXamarinFrameworks)`.
- If assembly or package version is updated the package index needs to be updated by running
`dotnet msbuild <Library>/pkg/<Library>.pkgproj /t:UpdatePackageIndex`
`dotnet build <Library>/pkg/<Library>.pkgproj /t:UpdatePackageIndex`
**Update tests**
- Add new `TargetFramework` to the ```TargetFrameworks```.
- Add new test code following [conventions](project-guidelines.md#code-file-naming-conventions) for new files to that are specific to the new target framework.
- To run just the new test targetFramework run `dotnet build <Library>.csproj -f <TargetFramework> /t:RebuildAndTest`. TargetFramework should be chosen only from supported TargetFrameworks.
- To run just the new test targetFramework run `dotnet build <Library>.csproj -f <TargetFramework> /t:Test`. TargetFramework should be chosen only from supported TargetFrameworks.
## Documentation