1
0
Fork 0
mirror of https://github.com/VSadov/Satori.git synced 2025-06-10 18:11:04 +09:00

Fix failures in unloadability tests

The assert in EEClass::Destroy is invalid after a change #1201 that has
removed ArrayTypeDesc. It was causing failures of a large portion of the
coreclr tests.

There were also three tests that were failing due to test
incompatibilities with unloadability, so I am marking them as such.
This commit is contained in:
Jan Vorlicek 2020-04-23 22:32:43 +02:00
parent dc3c4dc076
commit 09c54dc15c
4 changed files with 10 additions and 3 deletions

View file

@ -87,9 +87,6 @@ void EEClass::Destruct(MethodTable * pOwningMT)
#ifndef CROSSGEN_COMPILE
// Not expected to be called for array EEClass
_ASSERTE(!pOwningMT->IsArray());
#ifdef _DEBUG
_ASSERTE(!IsDestroyed());
SetDestroyed();

View file

@ -3,6 +3,8 @@
<OutputType>Exe</OutputType>
<!-- Test unsupported outside of windows -->
<TestUnsupportedOutsideWindows>true</TestUnsupportedOutsideWindows>
<!-- Native COM interfaces left alive at the test exit -->
<UnloadabilityIncompatible>true</UnloadabilityIncompatible>
<DisableProjectBuild Condition="'$(TargetsWindows)' != 'true'">true</DisableProjectBuild>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
</PropertyGroup>

View file

@ -1,4 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<!-- TestAssemblyLoadContext.Load called from the finalizer -->
<UnloadabilityIncompatible>true</UnloadabilityIncompatible>
</PropertyGroup>
<ItemGroup>
<Compile Include="BinderTracingTest.Basic.cs" />
<Compile Include="BinderTracingTest.DefaultProbing.cs" />

View file

@ -1,4 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<!-- Test creates non-collectible AssemblyLoadContext -->
<UnloadabilityIncompatible>true</UnloadabilityIncompatible>
</PropertyGroup>
<ItemGroup>
<Compile Include="BinderTracingTest.EventHandlers.cs" />
<Compile Include="BinderTracingTest.ResolutionFlow.cs" />