1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-08 05:27:14 +09:00
ladybird/Libraries/LibJS/Runtime/MapIterator.cpp
Aliaksandr Kalenik f405d71657 LibJS: Disable optimization in IteratorNextUnpack if next() is redefined
81b6a11 regressed correctness by always bypassing the `next()` method
resolution for built-in iterators, causing incorrect behavior when
`next()` was redefined on built-in prototypes. This change fixes the
issue by storing a flag on built-in prototypes indicating whether
`next()` has ever been redefined.
2025-05-12 07:41:29 -04:00

66 lines
1.7 KiB
C++

/*
* Copyright (c) 2021, Idan Horowitz <idan.horowitz@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibJS/Runtime/Array.h>
#include <LibJS/Runtime/MapIterator.h>
#include <LibJS/Runtime/MapIteratorPrototype.h>
namespace JS {
GC_DEFINE_ALLOCATOR(MapIterator);
GC::Ref<MapIterator> MapIterator::create(Realm& realm, Map& map, Object::PropertyKind iteration_kind)
{
return realm.create<MapIterator>(map, iteration_kind, realm.intrinsics().map_iterator_prototype());
}
MapIterator::MapIterator(Map& map, Object::PropertyKind iteration_kind, Object& prototype)
: Object(ConstructWithPrototypeTag::Tag, prototype)
, m_map(map)
, m_iteration_kind(iteration_kind)
, m_iterator(static_cast<Map const&>(map).begin())
{
auto& map_iterator_prototype = as<MapIteratorPrototype>(prototype);
m_next_method_was_redefined = map_iterator_prototype.next_method_was_redefined();
}
void MapIterator::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_map);
}
ThrowCompletionOr<void> MapIterator::next(VM& vm, bool& done, Value& value)
{
if (m_done) {
done = true;
value = js_undefined();
return {};
}
if (m_iterator.is_end()) {
m_done = true;
done = true;
value = js_undefined();
return {};
}
auto entry = *m_iterator;
++m_iterator;
if (m_iteration_kind == Object::PropertyKind::Key) {
value = entry.key;
return {};
}
if (m_iteration_kind == Object::PropertyKind::Value) {
value = entry.value;
return {};
}
value = Array::create_from(*vm.current_realm(), { entry.key, entry.value });
return {};
}
}