mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-06-08 05:27:14 +09:00
f405d71657
81b6a11 regressed correctness by always bypassing the `next()` method
resolution for built-in iterators, causing incorrect behavior when
`next()` was redefined on built-in prototypes. This change fixes the
issue by storing a flag on built-in prototypes indicating whether
`next()` has ever been redefined.
46 lines
1.2 KiB
C++
46 lines
1.2 KiB
C++
/*
|
|
* Copyright (c) 2020, Matthew Olsson <mattco@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <LibJS/Runtime/Iterator.h>
|
|
#include <LibJS/Runtime/Object.h>
|
|
|
|
namespace JS {
|
|
|
|
class ArrayIterator final : public Object
|
|
, public BuiltinIterator {
|
|
JS_OBJECT(ArrayIterator, Object);
|
|
GC_DECLARE_ALLOCATOR(ArrayIterator);
|
|
|
|
public:
|
|
static GC::Ref<ArrayIterator> create(Realm&, Value array, Object::PropertyKind iteration_kind);
|
|
|
|
virtual ~ArrayIterator() override = default;
|
|
|
|
BuiltinIterator* as_builtin_iterator_if_next_is_not_redefined() override
|
|
{
|
|
if (m_next_method_was_redefined)
|
|
return nullptr;
|
|
return this;
|
|
}
|
|
ThrowCompletionOr<void> next(VM&, bool& done, Value& value) override;
|
|
|
|
private:
|
|
ArrayIterator(Value array, Object::PropertyKind iteration_kind, Object& prototype);
|
|
|
|
virtual bool is_array_iterator() const override { return true; }
|
|
virtual void visit_edges(Cell::Visitor&) override;
|
|
|
|
Value m_array;
|
|
Object::PropertyKind m_iteration_kind;
|
|
size_t m_index { 0 };
|
|
};
|
|
|
|
template<>
|
|
inline bool Object::fast_is<ArrayIterator>() const { return is_array_iterator(); }
|
|
|
|
}
|