mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-06-12 10:40:39 +09:00
69f96122b6
The `[[GetOwnProperty]]` internal method invocation in `OrdinarySetWithOwnDescriptor` was being invocated again with the same parameters in the `[[DefineOwnProperty]]` internal method that is also later called in `OrdinarySetWithOwnDescriptor`. The `PlatformObject.[[DefineOwnProperty]]` has similair logic. This change adds an optional parameter to the `[[DefineOwnProperty]]` internal method so the results of the previous `[[GetOwnProperty]]` internal method invocation can be re-used.
43 lines
1.3 KiB
C++
43 lines
1.3 KiB
C++
/*
|
|
* Copyright (c) 2020, Andreas Kling <andreas@ladybird.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <LibJS/Runtime/Object.h>
|
|
|
|
namespace JS {
|
|
|
|
class StringObject : public Object {
|
|
JS_OBJECT(StringObject, Object);
|
|
JS_DECLARE_ALLOCATOR(StringObject);
|
|
|
|
public:
|
|
[[nodiscard]] static NonnullGCPtr<StringObject> create(Realm&, PrimitiveString&, Object& prototype);
|
|
|
|
virtual void initialize(Realm&) override;
|
|
virtual ~StringObject() override = default;
|
|
|
|
PrimitiveString const& primitive_string() const { return m_string; }
|
|
PrimitiveString& primitive_string() { return m_string; }
|
|
|
|
protected:
|
|
StringObject(PrimitiveString&, Object& prototype);
|
|
|
|
private:
|
|
virtual ThrowCompletionOr<Optional<PropertyDescriptor>> internal_get_own_property(PropertyKey const&) const override;
|
|
virtual ThrowCompletionOr<bool> internal_define_own_property(PropertyKey const&, PropertyDescriptor const&, Optional<PropertyDescriptor>* precomputed_get_own_property = nullptr) override;
|
|
virtual ThrowCompletionOr<MarkedVector<Value>> internal_own_property_keys() const override;
|
|
|
|
virtual bool is_string_object() const final { return true; }
|
|
virtual void visit_edges(Visitor&) override;
|
|
|
|
NonnullGCPtr<PrimitiveString> m_string;
|
|
};
|
|
|
|
template<>
|
|
inline bool Object::fast_is<StringObject>() const { return is_string_object(); }
|
|
|
|
}
|