1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-08 05:27:14 +09:00
ladybird/Libraries/LibJS/Runtime/SetIterator.h
Aliaksandr Kalenik 285bc005cb LibJS: Do more comprehensive check if next() fast path is possible
Before this change each built-in iterator object has a boolean
`m_next_method_was_redefined`. If user code later changed the iterator’s
prototype (e.g. `Object.setPrototypeOf()`), we still believed the
built-in fast-path was safe and skipped the user supplied override,
producing wrong results.

With this change
`BuiltinIterator::as_builtin_iterator_if_next_is_not_redefined()` looks
up the current `next` property and verifies that it is still the
built-in native function.
2025-06-02 00:15:36 +02:00

41 lines
1 KiB
C++

/*
* Copyright (c) 2021, Idan Horowitz <idan.horowitz@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#pragma once
#include <LibJS/Runtime/Iterator.h>
#include <LibJS/Runtime/Object.h>
#include <LibJS/Runtime/Set.h>
namespace JS {
class SetIterator final : public Object
, public BuiltinIterator {
JS_OBJECT(SetIterator, Object);
GC_DECLARE_ALLOCATOR(SetIterator);
public:
static GC::Ref<SetIterator> create(Realm&, Set& set, Object::PropertyKind iteration_kind);
virtual ~SetIterator() override = default;
BuiltinIterator* as_builtin_iterator_if_next_is_not_redefined(IteratorRecord const&) override;
ThrowCompletionOr<void> next(VM&, bool& done, Value& value) override;
private:
friend class SetIteratorPrototype;
explicit SetIterator(Set& set, Object::PropertyKind iteration_kind, Object& prototype);
virtual void visit_edges(Cell::Visitor&) override;
GC::Ref<Set> m_set;
bool m_done { false };
Object::PropertyKind m_iteration_kind;
Map::ConstIterator m_iterator;
};
}