1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-08 13:37:10 +09:00
ladybird/Libraries/LibJS/Runtime/StringIterator.h
Aliaksandr Kalenik 285bc005cb LibJS: Do more comprehensive check if next() fast path is possible
Before this change each built-in iterator object has a boolean
`m_next_method_was_redefined`. If user code later changed the iterator’s
prototype (e.g. `Object.setPrototypeOf()`), we still believed the
built-in fast-path was safe and skipped the user supplied override,
producing wrong results.

With this change
`BuiltinIterator::as_builtin_iterator_if_next_is_not_redefined()` looks
up the current `next` property and verifies that it is still the
built-in native function.
2025-06-02 00:15:36 +02:00

39 lines
927 B
C++

/*
* Copyright (c) 2020, Matthew Olsson <mattco@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#pragma once
#include <AK/String.h>
#include <AK/Utf8View.h>
#include <LibJS/Runtime/Iterator.h>
#include <LibJS/Runtime/Object.h>
namespace JS {
class StringIterator final : public Object
, public BuiltinIterator {
JS_OBJECT(StringIterator, Object);
GC_DECLARE_ALLOCATOR(StringIterator);
public:
static GC::Ref<StringIterator> create(Realm&, String string);
virtual ~StringIterator() override = default;
BuiltinIterator* as_builtin_iterator_if_next_is_not_redefined(IteratorRecord const&) override;
ThrowCompletionOr<void> next(VM&, bool& done, Value& value) override;
private:
explicit StringIterator(String string, Object& prototype);
friend class StringIteratorPrototype;
String m_string;
Utf8CodePointIterator m_iterator;
bool m_done { false };
};
}