Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-09 09:34:57 +09:00
Code Activity

LibJS: Don't start rendering thread for a navigable created for SVG

Browse source 
Traversable navigable created for rendering svg element doesn't perform
any actual rendering, so there is no need to spawn a rendering thread.
This commit is contained in:
Aliaksandr Kalenik 2025-06-05 19:58:53 +02:00 • committed by Alexander Kalenik
parent 39fff3cf8a
commit ed1337add1
Notes: github-actions[bot] 2025-06-06 01:58:02 +00:00
2 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/HTML/RenderingThread.cpp
View file

@ -28,7 +28,9 @@ RenderingThread::~RenderingThread()
{
// Note: Promise rejection is expected to signal the thread to exit.
m_main_thread_exit_promise->reject(Error::from_errno(ECANCELED));
(void)m_thread->join();
if (m_thread) {
(void)m_thread->join();
}
}
void RenderingThread::start(DisplayListPlayerType display_list_player_type)

8
Libraries/LibWeb/HTML/TraversableNavigable.cpp
View file

@ -61,9 +61,11 @@ TraversableNavigable::TraversableNavigable(GC::Ref<Page> page)
skia_player = make<Painting::DisplayListPlayerSkia>();
}
m_rendering_thread.set_skia_player(move(skia_player));
m_rendering_thread.set_skia_backend_context(m_skia_backend_context);
m_rendering_thread.start(display_list_player_type);
if (!page->client().is_svg_page_client()) {
m_rendering_thread.set_skia_player(move(skia_player));
m_rendering_thread.set_skia_backend_context(m_skia_backend_context);
m_rendering_thread.start(display_list_player_type);
}
}
TraversableNavigable::~TraversableNavigable() = default;