Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-11 18:20:43 +09:00
Code Activity

Userland: Make IPC results with one return value available directly

Browse source 
This changes client methods so that they return the IPC response's
return value directly - instead of the response struct - for IPC
methods which only have a single return value.
This commit is contained in:
Gunnar Beutner 2021-05-03 13:55:29 +02:00 • committed by Andreas Kling
parent 5bb79ea0a7
commit eb21aa65d1
Notes: sideshowbarker 2024-07-18 18:44:27 +09:00
18 changed files with 58 additions and 111 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Userland/DevTools/IPCCompiler/main.cpp
View file

@ -491,8 +491,12 @@ public:
auto do_implement_proxy = [&](String const& name, Vector<Parameter> const& parameters, bool is_synchronous) {
String return_type = "void";
if (is_synchronous && !message.outputs.is_empty())
return_type = message_name(endpoint.name, message.name, true);
if (is_synchronous) {
if (message.outputs.size() == 1)
return_type = message.outputs[0].type;
else if (!message.outputs.is_empty())
return_type = message_name(endpoint.name, message.name, true);
}
message_generator.set("message.name", message.name);
message_generator.set("message.complex_return_type", return_type);
message_generator.set("async_prefix_maybe", is_synchronous ? "" : "async_");
@ -516,8 +520,10 @@ public:
if (is_synchronous) {
if (return_type != "void") {
message_generator.append(R"~~~(
return move(*)~~~");
} else{
return )~~~");
if (message.outputs.size() != 1)
message_generator.append(" move(*");
} else {
message_generator.append(R"~~~(
)~~~");
}
@ -545,9 +551,17 @@ public:
message_generator.append(")");
}
message_generator.append(R"~~~();
if (message.outputs.size() == 1) {
message_generator.append("->");
message_generator.append(message.outputs[0].name);
message_generator.append("()");
} else
message_generator.append(")");
message_generator.append(R"~~~(;
}
)~~~");
} else {
message_generator.append(R"~~~( });
}