Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-10 01:51:03 +09:00
Code Activity

AK: Simplify constructors and conversions from nullptr_t

Browse source 
Problem:
- Many constructors are defined as `{}` rather than using the ` =
  default` compiler-provided constructor.
- Some types provide an implicit conversion operator from `nullptr_t`
  instead of requiring the caller to default construct. This violates
  the C++ Core Guidelines suggestion to declare single-argument
  constructors explicit
  (https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c46-by-default-declare-single-argument-constructors-explicit).

Solution:
- Change default constructors to use the compiler-provided default
  constructor.
- Remove implicit conversion operators from `nullptr_t` and change
  usage to enforce type consistency without conversion.
This commit is contained in:
Lenny Maiorani 2021-01-10 16:29:28 -07:00 • committed by Andreas Kling
parent 9dc44bf8c4
commit e6f907a155
Notes: sideshowbarker 2024-07-18 23:54:24 +09:00
105 changed files with 300 additions and 244 deletions
Download patch file Download diff file Expand all files Collapse all files

2
AK/FlyString.h
View file

@ -32,7 +32,7 @@ namespace AK {
class FlyString {
public:
FlyString() { }
FlyString() = default;
FlyString(const FlyString& other)
: m_impl(other.impl())
{