Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-11 18:20:43 +09:00
Code Activity

LibWeb: Protect XMLHttpRequest from GC in special circumstances

Browse source 
The XHR gives us a set of conditions where XHR objects must survive
garbage collection, even when there are no pointers to them on the heap.
This patch implements those conditions using the new cell
self-protection mechanism in LibJS.
This commit is contained in:
Andreas Kling 2022-10-24 14:57:28 +02:00
parent e0a08f2ab0
commit e448c74736
Notes: sideshowbarker 2024-07-18 04:46:35 +09:00
2 changed files with 35 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

34
Userland/Libraries/LibWeb/XHR/XMLHttpRequest.cpp
View file

@ -51,6 +51,7 @@ XMLHttpRequest::XMLHttpRequest(HTML::Window& window)
, m_window(window)
, m_response_type(Bindings::XMLHttpRequestResponseType::Empty)
{
set_overrides_must_survive_garbage_collection(true);
set_prototype(&Bindings::cached_web_prototype(window.realm(), "XMLHttpRequest"));
}
@ -587,4 +588,37 @@ WebIDL::ExceptionOr<void> XMLHttpRequest::set_timeout(u32 timeout)
// https://xhr.spec.whatwg.org/#dom-xmlhttprequest-timeout
u32 XMLHttpRequest::timeout() const { return m_timeout; }
// https://xhr.spec.whatwg.org/#garbage-collection
bool XMLHttpRequest::must_survive_garbage_collection() const
{
// An XMLHttpRequest object must not be garbage collected
// if its state is either opened with the send() flag set, headers received, or loading,
// and it has one or more event listeners registered whose type is one of
// readystatechange, progress, abort, error, load, timeout, and loadend.
if ((m_ready_state == ReadyState::Opened && m_send)
|| m_ready_state == ReadyState::HeadersReceived
|| m_ready_state == ReadyState::Loading) {
if (has_event_listener(EventNames::readystatechange))
return true;
if (has_event_listener(EventNames::progress))
return true;
if (has_event_listener(EventNames::abort))
return true;
if (has_event_listener(EventNames::error))
return true;
if (has_event_listener(EventNames::load))
return true;
if (has_event_listener(EventNames::timeout))
return true;
if (has_event_listener(EventNames::loadend))
return true;
}
// FIXME: If an XMLHttpRequest object is garbage collected while its connection is still open,
// the user agent must terminate the XMLHttpRequest object’s fetch controller.
// NOTE: This would go in XMLHttpRequest::finalize().
return false;
}
}