Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-10 18:10:56 +09:00
Code Activity

LibWeb: Add API for finding NavigableContainer by content navigable

Browse source 
This is only needed because currently spec doesn't explicitly define
that navigable should have a pointer to associated container and when
this pointer should be set.
This commit is contained in:
Aliaksandr Kalenik 2023-04-23 17:50:08 +03:00 • committed by Andreas Kling
parent 85a3a1c085
commit d85bdd3ac5
Notes: sideshowbarker 2024-07-17 11:30:54 +09:00
4 changed files with 17 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWeb/HTML/Navigable.cpp
View file

@ -190,12 +190,7 @@ String Navigable::target_name() const
JS::GCPtr<NavigableContainer> Navigable::container() const
{
// The container of a navigable navigable is the navigable container whose nested navigable is navigable, or null if there is no such element.
return m_container;
}
void Navigable::set_container(JS::GCPtr<NavigableContainer> container)
{
m_container = container;
return NavigableContainer::navigable_container_with_content_navigable(const_cast<Navigable&>(*this));
}
// https://html.spec.whatwg.org/multipage/document-sequences.html#nav-traversable

1
Userland/Libraries/LibWeb/HTML/Navigable.h
View file

@ -60,7 +60,6 @@ public:
String target_name() const;
JS::GCPtr<NavigableContainer> container() const;
void set_container(JS::GCPtr<NavigableContainer>);
JS::GCPtr<TraversableNavigable> traversable_navigable() const;
JS::GCPtr<TraversableNavigable> top_level_traversable();

15
Userland/Libraries/LibWeb/HTML/NavigableContainer.cpp
View file

@ -27,9 +27,13 @@ HashTable<NavigableContainer*>& NavigableContainer::all_instances()
NavigableContainer::NavigableContainer(DOM::Document& document, DOM::QualifiedName qualified_name)
: HTMLElement(document, move(qualified_name))
{
all_instances().set(this);
}
NavigableContainer::~NavigableContainer() = default;
NavigableContainer::~NavigableContainer()
{
all_instances().remove(this);
}
void NavigableContainer::visit_edges(Cell::Visitor& visitor)
{
@ -37,6 +41,15 @@ void NavigableContainer::visit_edges(Cell::Visitor& visitor)
visitor.visit(m_nested_browsing_context);
}
JS::GCPtr<NavigableContainer> NavigableContainer::navigable_container_with_content_navigable(JS::NonnullGCPtr<Navigable> navigable)
{
for (auto* navigable_container : all_instances()) {
if (navigable_container->content_navigable() == navigable)
return navigable_container;
}
return nullptr;
}
// https://html.spec.whatwg.org/multipage/browsers.html#creating-a-new-nested-browsing-context
void NavigableContainer::create_new_nested_browsing_context()
{

2
Userland/Libraries/LibWeb/HTML/NavigableContainer.h
View file

@ -14,6 +14,8 @@ class NavigableContainer : public HTMLElement {
WEB_PLATFORM_OBJECT(NavigableContainer, HTMLElement);
public:
static JS::GCPtr<NavigableContainer> navigable_container_with_content_navigable(JS::NonnullGCPtr<Navigable> navigable);
virtual ~NavigableContainer() override;
static HashTable<NavigableContainer*>& all_instances();