mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-06-11 18:20:43 +09:00
LibJS: Add private references
This commit is contained in:
parent
d94b5e511f
commit
c7a6572789
Notes:
sideshowbarker
2024-07-18 02:08:01 +09:00
Author: https://github.com/davidot
Commit: c7a6572789
Pull-request: https://github.com/SerenityOS/serenity/pull/10470
Issue: https://github.com/SerenityOS/serenity/issues/7044
Issue: https://github.com/SerenityOS/serenity/issues/8574
Reviewed-by: https://github.com/linusg
2 changed files with 43 additions and 5 deletions
|
@ -37,6 +37,11 @@ void Reference::put_value(GlobalObject& global_object, Value value)
|
|||
return;
|
||||
auto* base_obj = base_obj_or_error.release_value();
|
||||
|
||||
if (is_private_reference()) {
|
||||
base_obj->private_set(m_private_name, value);
|
||||
return;
|
||||
}
|
||||
|
||||
auto succeeded_or_error = base_obj->internal_set(m_name, value, get_this_value());
|
||||
if (succeeded_or_error.is_error())
|
||||
return;
|
||||
|
@ -76,6 +81,10 @@ Value Reference::get_value(GlobalObject& global_object) const
|
|||
|
||||
if (is_property_reference()) {
|
||||
auto* base_obj = TRY_OR_DISCARD(m_base_value.to_object(global_object));
|
||||
|
||||
if (is_private_reference())
|
||||
return TRY_OR_DISCARD(base_obj->private_get(m_private_name));
|
||||
|
||||
return TRY_OR_DISCARD(base_obj->get(m_name));
|
||||
}
|
||||
|
||||
|
@ -111,7 +120,7 @@ bool Reference::delete_(GlobalObject& global_object)
|
|||
// 5. If IsPropertyReference(ref) is true, then
|
||||
if (is_property_reference()) {
|
||||
// a. Assert: ! IsPrivateReference(ref) is false.
|
||||
// FIXME: We don't have private references yet.
|
||||
VERIFY(!is_private_reference());
|
||||
|
||||
// b. If IsSuperReference(ref) is true, throw a ReferenceError exception.
|
||||
if (is_super_reference()) {
|
||||
|
@ -181,4 +190,12 @@ String Reference::to_string() const
|
|||
return builder.to_string();
|
||||
}
|
||||
|
||||
// 6.2.4.9 MakePrivateReference ( baseValue, privateIdentifier ), https://tc39.es/ecma262/#sec-makeprivatereference
|
||||
Reference make_private_reference(VM& vm, Value base_value, FlyString const& private_identifier)
|
||||
{
|
||||
auto* private_environment = vm.running_execution_context().private_environment;
|
||||
VERIFY(private_environment);
|
||||
return Reference { base_value, private_environment->resolve_private_identifier(private_identifier) };
|
||||
}
|
||||
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue