From c2ab0dafb2fab580e593e2bdac22bb355eab5a22 Mon Sep 17 00:00:00 2001
From: Jelle Raaijmakers <jelle@ladybird.org>
Date: Thu, 5 Jun 2025 21:57:36 +0200
Subject: [PATCH] CI: Set explicit job names for matrix strategy workflows

By default, matrix jobs generate a name for themselves by concatenating
their job name and all matrix variables into a big string. Changing the
runner labels causes the job name to change, which means we need to go
into GitHub and change the required checks since those are name-based.

Give all matrix workflows an explicit, more stable name.
---
 .github/workflows/ci.yml            | 1 +
 .github/workflows/js-artifacts.yml  | 2 ++
 .github/workflows/js-benchmarks.yml | 2 ++
 .github/workflows/nightly-lagom.yml | 1 +
 4 files changed, 6 insertions(+)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 96a99f0621d..df29187b46d 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -10,6 +10,7 @@ jobs:
   # CI matrix - runs the job in lagom-template.yml with different configurations.
   Lagom:
     if: github.repository == 'LadybirdBrowser/ladybird'
+    name: ${{ matrix.os_name }}, ${{ matrix.arch }}, ${{ matrix.build_preset }}, ${{ matrix.toolchain }}
 
     strategy:
       fail-fast: false
diff --git a/.github/workflows/js-artifacts.yml b/.github/workflows/js-artifacts.yml
index a5aa8950bf7..5a8a7bd3ab3 100644
--- a/.github/workflows/js-artifacts.yml
+++ b/.github/workflows/js-artifacts.yml
@@ -13,6 +13,8 @@ jobs:
   build-and-package:
     runs-on: ${{ fromJSON(matrix.runner_labels) }}
     if: github.repository == 'LadybirdBrowser/ladybird'
+    name: ${{ matrix.os_name }}, ${{ matrix.arch }}
+
     strategy:
       fail-fast: false
       matrix:
diff --git a/.github/workflows/js-benchmarks.yml b/.github/workflows/js-benchmarks.yml
index 375c90c34ad..3b2f4a49303 100644
--- a/.github/workflows/js-benchmarks.yml
+++ b/.github/workflows/js-benchmarks.yml
@@ -10,6 +10,8 @@ jobs:
   js-benchmarks:
     runs-on: ${{ fromJSON(matrix.runner_labels) }}
     if: ${{ github.repository == 'LadybirdBrowser/ladybird' && github.event.workflow_run.conclusion == 'success' }}
+    name: ${{ matrix.os_name }}, ${{ matrix.arch }}
+
     strategy:
       fail-fast: false
       matrix:
diff --git a/.github/workflows/nightly-lagom.yml b/.github/workflows/nightly-lagom.yml
index 620fb1ad4e3..f5e16ed48a1 100644
--- a/.github/workflows/nightly-lagom.yml
+++ b/.github/workflows/nightly-lagom.yml
@@ -13,6 +13,7 @@ jobs:
   # CI matrix - runs the job in lagom-template.yml with different configurations.
   Lagom:
     if: github.repository == 'LadybirdBrowser/ladybird'
+    name: ${{ matrix.os_name }}, ${{ matrix.arch }}, ${{ matrix.build_preset }}, ${{ matrix.toolchain }}
 
     strategy:
       fail-fast: false