Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-10 18:10:56 +09:00
Code Activity

Everywhere: Re-format with clang-format-11

Browse source 
Compared to version 10 this fixes a bunch of formatting issues, mostly
around structs/classes with attributes like [[gnu::packed]], and
incorrect insertion of spaces in parameter types ("T &"/"T &&").
I also removed a bunch of // clang-format off/on and FIXME comments that
are no longer relevant - on the other hand it tried to destroy a couple of
neatly formatted comments, so I had to add some as well.
This commit is contained in:
Linus Groh 2020-12-30 22:44:54 +01:00 • committed by Andreas Kling
parent 2568a93b5d
commit bbe787a0af
Notes: sideshowbarker 2024-07-19 00:18:21 +09:00
54 changed files with 130 additions and 230 deletions
Download patch file Download diff file Expand all files Collapse all files

6
AK/Endian.h
View file

@ -105,8 +105,7 @@ template<typename T>
OutputStream& operator<<(OutputStream&, LittleEndian<T>); OutputStream& operator<<(OutputStream&, LittleEndian<T>);
template<typename T> template<typename T>
class [[gnu::packed]] LittleEndian class [[gnu::packed]] LittleEndian {
{
public: public:
friend InputStream& operator>><T>(InputStream&, LittleEndian<T>&); friend InputStream& operator>><T>(InputStream&, LittleEndian<T>&);
friend OutputStream& operator<<<T>(OutputStream&, LittleEndian<T>); friend OutputStream& operator<<<T>(OutputStream&, LittleEndian<T>);
@ -134,8 +133,7 @@ template<typename T>
OutputStream& operator<<(OutputStream&, BigEndian<T>); OutputStream& operator<<(OutputStream&, BigEndian<T>);
template<typename T> template<typename T>
class [[gnu::packed]] BigEndian class [[gnu::packed]] BigEndian {
{
public: public:
friend InputStream& operator>><T>(InputStream&, BigEndian<T>&); friend InputStream& operator>><T>(InputStream&, BigEndian<T>&);
friend OutputStream& operator<<<T>(OutputStream&, BigEndian<T>); friend OutputStream& operator<<<T>(OutputStream&, BigEndian<T>);

3
AK/IPv4Address.h
View file

@ -35,8 +35,7 @@
namespace AK { namespace AK {
class [[gnu::packed]] IPv4Address class [[gnu::packed]] IPv4Address {
{
enum class SubnetClass : int { enum class SubnetClass : int {
A = 0, A = 0,
B, B,

3
AK/MACAddress.h
View file

@ -32,8 +32,7 @@
#include <AK/String.h> #include <AK/String.h>
#include <AK/Types.h> #include <AK/Types.h>
class [[gnu::packed]] MACAddress class [[gnu::packed]] MACAddress {
{
static constexpr size_t s_mac_address_length = 6u; static constexpr size_t s_mac_address_length = 6u;
public: public:

9
AK/Optional.h
View file

@ -35,8 +35,7 @@
namespace AK { namespace AK {
template<typename T> template<typename T>
class alignas(T) [[nodiscard]] Optional class alignas(T) [[nodiscard]] Optional {
{
public: public:
Optional() { } Optional() { }
@ -53,13 +52,13 @@ public:
new (&m_storage) T(value); new (&m_storage) T(value);
} }
Optional(T && value) Optional(T&& value)
: m_has_value(true) : m_has_value(true)
{ {
new (&m_storage) T(move(value)); new (&m_storage) T(move(value));
} }
Optional(Optional && other) Optional(Optional&& other)
: m_has_value(other.m_has_value) : m_has_value(other.m_has_value)
{ {
if (other.has_value()) { if (other.has_value()) {
@ -119,7 +118,7 @@ public:
} }
template<typename... Parameters> template<typename... Parameters>
ALWAYS_INLINE void emplace(Parameters && ... parameters) ALWAYS_INLINE void emplace(Parameters&&... parameters)
{ {
clear(); clear();
m_has_value = true; m_has_value = true;

13
AK/Result.h
View file

@ -32,14 +32,13 @@
namespace AK { namespace AK {
template<typename ValueType, typename ErrorType> template<typename ValueType, typename ErrorType>
class [[nodiscard]] Result class [[nodiscard]] Result {
{
public: public:
Result(const ValueType& res) Result(const ValueType& res)
: m_result(res) : m_result(res)
{ {
} }
Result(ValueType && res) Result(ValueType&& res)
: m_result(move(res)) : m_result(move(res))
{ {
} }
@ -47,7 +46,7 @@ public:
: m_error(error) : m_error(error)
{ {
} }
Result(ErrorType && error) Result(ErrorType&& error)
: m_error(move(error)) : m_error(move(error))
{ {
} }
@ -58,19 +57,13 @@ public:
{ {
} }
// FIXME: clang-format gets confused about Result. Why?
// clang-format off
Result(Result&& other) Result(Result&& other)
// clang-format on
: m_result(move(other.m_result)) : m_result(move(other.m_result))
, m_error(move(other.m_error)) , m_error(move(other.m_error))
{ {
} }
// FIXME: clang-format gets confused about Result. Why?
// clang-format off
Result(Result& other) Result(Result& other)
// clang-format on
: m_result(other.m_result) : m_result(other.m_result)
, m_error(other.m_error) , m_error(other.m_error)
{ {

54
Kernel/ACPI/Definitions.h
View file

@ -70,8 +70,7 @@ enum class IA_PC_Flags : u8 {
CMOS_RTC_Not_Present = 1 << 5 CMOS_RTC_Not_Present = 1 << 5
}; };
struct [[gnu::packed]] HardwareFeatures struct [[gnu::packed]] HardwareFeatures {
{
bool wbinvd : 1; bool wbinvd : 1;
bool wbinvd_flush : 1; bool wbinvd_flush : 1;
bool processor_c1 : 1; bool processor_c1 : 1;
@ -95,8 +94,7 @@ struct [[gnu::packed]] HardwareFeatures
bool hardware_reduced_acpi : 1; bool hardware_reduced_acpi : 1;
bool low_power_s0_idle_capable : 1; bool low_power_s0_idle_capable : 1;
}; };
struct [[gnu::packed]] x86_Specific_Flags struct [[gnu::packed]] x86_Specific_Flags {
{
bool legacy_devices : 1; bool legacy_devices : 1;
bool keyboard_8042 : 1; bool keyboard_8042 : 1;
bool vga_not_present : 1; bool vga_not_present : 1;
@ -132,8 +130,7 @@ enum class BitWidth {
} }
namespace Structures { namespace Structures {
struct [[gnu::packed]] RSDPDescriptor struct [[gnu::packed]] RSDPDescriptor {
{
char sig[8]; char sig[8];
u8 checksum; u8 checksum;
char oem_id[6]; char oem_id[6];
@ -141,8 +138,7 @@ struct [[gnu::packed]] RSDPDescriptor
u32 rsdt_ptr; u32 rsdt_ptr;
}; };
struct [[gnu::packed]] RSDPDescriptor20 struct [[gnu::packed]] RSDPDescriptor20 {
{
RSDPDescriptor base; RSDPDescriptor base;
u32 length; u32 length;
u64 xsdt_ptr; u64 xsdt_ptr;
@ -150,8 +146,7 @@ struct [[gnu::packed]] RSDPDescriptor20
u8 reserved[3]; u8 reserved[3];
}; };
struct [[gnu::packed]] SDTHeader struct [[gnu::packed]] SDTHeader {
{
char sig[4]; char sig[4];
u32 length; u32 length;
u8 revision; u8 revision;
@ -163,20 +158,17 @@ struct [[gnu::packed]] SDTHeader
u32 creator_revision; u32 creator_revision;
}; };
struct [[gnu::packed]] RSDT struct [[gnu::packed]] RSDT {
{
SDTHeader h; SDTHeader h;
u32 table_ptrs[]; u32 table_ptrs[];
}; };
struct [[gnu::packed]] XSDT struct [[gnu::packed]] XSDT {
{
SDTHeader h; SDTHeader h;
u64 table_ptrs[]; u64 table_ptrs[];
}; };
struct [[gnu::packed]] GenericAddressStructure struct [[gnu::packed]] GenericAddressStructure {
{
u8 address_space; u8 address_space;
u8 bit_width; u8 bit_width;
u8 bit_offset; u8 bit_offset;
@ -184,8 +176,7 @@ struct [[gnu::packed]] GenericAddressStructure
u64 address; u64 address;
}; };
struct [[gnu::packed]] HPET struct [[gnu::packed]] HPET {
{
SDTHeader h; SDTHeader h;
u8 hardware_revision_id; u8 hardware_revision_id;
u8 attributes; u8 attributes;
@ -196,8 +187,7 @@ struct [[gnu::packed]] HPET
u8 page_protection; u8 page_protection;
}; };
struct [[gnu::packed]] FADT struct [[gnu::packed]] FADT {
{
SDTHeader h; SDTHeader h;
u32 firmware_ctrl; u32 firmware_ctrl;
u32 dsdt_ptr; u32 dsdt_ptr;
@ -274,15 +264,13 @@ enum class MADTEntryType {
GIC_Interrupt_Translation = 0xF GIC_Interrupt_Translation = 0xF
}; };
struct [[gnu::packed]] MADTEntryHeader struct [[gnu::packed]] MADTEntryHeader {
{
u8 type; u8 type;
u8 length; u8 length;
}; };
namespace MADTEntries { namespace MADTEntries {
struct [[gnu::packed]] IOAPIC struct [[gnu::packed]] IOAPIC {
{
MADTEntryHeader h; MADTEntryHeader h;
u8 ioapic_id; u8 ioapic_id;
u8 reserved; u8 reserved;
@ -290,16 +278,14 @@ struct [[gnu::packed]] IOAPIC
u32 gsi_base; u32 gsi_base;
}; };
struct [[gnu::packed]] ProcessorLocalAPIC struct [[gnu::packed]] ProcessorLocalAPIC {
{
MADTEntryHeader h; MADTEntryHeader h;
u8 acpi_processor_id; u8 acpi_processor_id;
u8 apic_id; u8 apic_id;
u32 flags; u32 flags;
}; };
struct [[gnu::packed]] InterruptSourceOverride struct [[gnu::packed]] InterruptSourceOverride {
{
MADTEntryHeader h; MADTEntryHeader h;
u8 bus; u8 bus;
u8 source; u8 source;
@ -308,22 +294,19 @@ struct [[gnu::packed]] InterruptSourceOverride
}; };
} }
struct [[gnu::packed]] MADT struct [[gnu::packed]] MADT {
{
SDTHeader h; SDTHeader h;
u32 lapic_address; u32 lapic_address;
u32 flags; u32 flags;
MADTEntryHeader entries[]; MADTEntryHeader entries[];
}; };
struct [[gnu::packed]] AMLTable struct [[gnu::packed]] AMLTable {
{
SDTHeader h; SDTHeader h;
char aml_code[]; char aml_code[];
}; };
struct [[gnu::packed]] PCI_MMIO_Descriptor struct [[gnu::packed]] PCI_MMIO_Descriptor {
{
u64 base_addr; u64 base_addr;
u16 seg_group_number; u16 seg_group_number;
u8 start_pci_bus; u8 start_pci_bus;
@ -331,8 +314,7 @@ struct [[gnu::packed]] PCI_MMIO_Descriptor
u32 reserved; u32 reserved;
}; };
struct [[gnu::packed]] MCFG struct [[gnu::packed]] MCFG {
{
SDTHeader header; SDTHeader header;
u64 reserved; u64 reserved;
PCI_MMIO_Descriptor descriptors[]; PCI_MMIO_Descriptor descriptors[];

36
Kernel/ACPI/MultiProcessorParser.h
View file

@ -34,8 +34,7 @@
namespace Kernel { namespace Kernel {
namespace MultiProcessor { namespace MultiProcessor {
struct [[gnu::packed]] FloatingPointer struct [[gnu::packed]] FloatingPointer {
{
char sig[4]; char sig[4];
u32 physical_address_ptr; u32 physical_address_ptr;
u8 length; u8 length;
@ -44,13 +43,11 @@ struct [[gnu::packed]] FloatingPointer
u8 feature_info[5]; u8 feature_info[5];
}; };
struct [[gnu::packed]] EntryHeader struct [[gnu::packed]] EntryHeader {
{
u8 entry_type; u8 entry_type;
}; };
struct [[gnu::packed]] ConfigurationTableHeader struct [[gnu::packed]] ConfigurationTableHeader {
{
char sig[4]; char sig[4];
u16 length; u16 length;
u8 specification_revision; u8 specification_revision;
@ -78,14 +75,12 @@ enum class ConfigurationTableEntryType {
CompatibilityBusAddressSpaceModifier = 130 CompatibilityBusAddressSpaceModifier = 130
}; };
struct [[gnu::packed]] ExtEntryHeader struct [[gnu::packed]] ExtEntryHeader {
{
u8 entry_type; u8 entry_type;
u8 entry_length; u8 entry_length;
}; };
struct [[gnu::packed]] ProcessorEntry struct [[gnu::packed]] ProcessorEntry {
{
EntryHeader h; EntryHeader h;
u8 local_apic_id; u8 local_apic_id;
u8 local_apic_version; u8 local_apic_version;
@ -95,15 +90,13 @@ struct [[gnu::packed]] ProcessorEntry
u8 reserved[8]; u8 reserved[8];
}; };
struct [[gnu::packed]] BusEntry struct [[gnu::packed]] BusEntry {
{
EntryHeader h; EntryHeader h;
u8 bus_id; u8 bus_id;
char bus_type[6]; char bus_type[6];
}; };
struct [[gnu::packed]] IOAPICEntry struct [[gnu::packed]] IOAPICEntry {
{
EntryHeader h; EntryHeader h;
u8 ioapic_id; u8 ioapic_id;
u8 ioapic_version; u8 ioapic_version;
@ -118,8 +111,7 @@ enum class InterruptType {
ExtINT = 3, ExtINT = 3,
}; };
struct [[gnu::packed]] IOInterruptAssignmentEntry struct [[gnu::packed]] IOInterruptAssignmentEntry {
{
EntryHeader h; EntryHeader h;
u8 interrupt_type; u8 interrupt_type;
u8 polarity; u8 polarity;
@ -130,8 +122,7 @@ struct [[gnu::packed]] IOInterruptAssignmentEntry
u8 destination_ioapic_intin_pin; u8 destination_ioapic_intin_pin;
}; };
struct [[gnu::packed]] LocalInterruptAssignmentEntry struct [[gnu::packed]] LocalInterruptAssignmentEntry {
{
EntryHeader h; EntryHeader h;
u8 interrupt_type; u8 interrupt_type;
u8 polarity; u8 polarity;
@ -148,8 +139,7 @@ enum class SystemAddressType {
Prefetch = 2, Prefetch = 2,
}; };
struct [[gnu::packed]] SystemAddressSpaceMappingEntry struct [[gnu::packed]] SystemAddressSpaceMappingEntry {
{
ExtEntryHeader h; ExtEntryHeader h;
u8 bus_id; u8 bus_id;
u8 address_type; u8 address_type;
@ -157,8 +147,7 @@ struct [[gnu::packed]] SystemAddressSpaceMappingEntry
u64 length; u64 length;
}; };
struct [[gnu::packed]] BusHierarchyDescriptorEntry struct [[gnu::packed]] BusHierarchyDescriptorEntry {
{
ExtEntryHeader h; ExtEntryHeader h;
u8 bus_id; u8 bus_id;
u8 bus_info; u8 bus_info;
@ -166,8 +155,7 @@ struct [[gnu::packed]] BusHierarchyDescriptorEntry
u8 reserved[3]; u8 reserved[3];
}; };
struct [[gnu::packed]] CompatibilityBusAddressSpaceModifierEntry struct [[gnu::packed]] CompatibilityBusAddressSpaceModifierEntry {
{
ExtEntryHeader h; ExtEntryHeader h;
u8 bus_id; u8 bus_id;
u8 address_modifier; u8 address_modifier;

3
Kernel/API/InodeWatcherEvent.h
View file

@ -28,8 +28,7 @@
#include <AK/Types.h> #include <AK/Types.h>
struct [[gnu::packed]] InodeWatcherEvent struct [[gnu::packed]] InodeWatcherEvent {
{
enum class Type { enum class Type {
Invalid = 0, Invalid = 0,
Modified, Modified,

20
Kernel/Arch/i386/CPU.h
View file

@ -51,14 +51,12 @@ inline u32 get_iopl_from_eflags(u32 eflags)
return (eflags & iopl_mask) >> 12; return (eflags & iopl_mask) >> 12;
} }
struct [[gnu::packed]] DescriptorTablePointer struct [[gnu::packed]] DescriptorTablePointer {
{
u16 limit; u16 limit;
void* address; void* address;
}; };
struct [[gnu::packed]] TSS32 struct [[gnu::packed]] TSS32 {
{
u16 backlink, __blh; u16 backlink, __blh;
u32 esp0; u32 esp0;
u16 ss0, __ss0h; u16 ss0, __ss0h;
@ -78,8 +76,7 @@ struct [[gnu::packed]] TSS32
u16 trace, iomapbase; u16 trace, iomapbase;
}; };
union [[gnu::packed]] Descriptor union [[gnu::packed]] Descriptor {
{
struct { struct {
u16 limit_lo; u16 limit_lo;
u16 base_lo; u16 base_lo;
@ -347,15 +344,15 @@ inline u32 read_fs_u32(u32 offset)
u32 val; u32 val;
asm volatile( asm volatile(
"movl %%fs:%a[off], %k[val]" "movl %%fs:%a[off], %k[val]"
: [ val ] "=r"(val) : [val] "=r"(val)
: [ off ] "ir"(offset)); : [off] "ir"(offset));
return val; return val;
} }
inline void write_fs_u32(u32 offset, u32 val) inline void write_fs_u32(u32 offset, u32 val)
{ {
asm volatile( asm volatile(
"movl %k[val], %%fs:%a[off]" ::[off] "ir"(offset), [ val ] "ir"(val) "movl %k[val], %%fs:%a[off]" ::[off] "ir"(offset), [val] "ir"(val)
: "memory"); : "memory");
} }
@ -475,8 +472,7 @@ private:
VirtualAddress m_vaddr; VirtualAddress m_vaddr;
}; };
struct [[gnu::packed]] RegisterState struct [[gnu::packed]] RegisterState {
{
u32 ss; u32 ss;
u32 gs; u32 gs;
u32 fs; u32 fs;
@ -539,7 +535,7 @@ static inline bool is_kernel_mode()
u32 cs; u32 cs;
asm volatile( asm volatile(
"movl %%cs, %[cs] \n" "movl %%cs, %[cs] \n"
: [ cs ] "=g"(cs)); : [cs] "=g"(cs));
return (cs & 3) == 0; return (cs & 3) == 0;
} }

3
Kernel/FileSystem/Plan9FileSystem.cpp
View file

@ -570,8 +570,7 @@ KResult Plan9FS::do_read(u8* data, size_t size)
KResult Plan9FS::read_and_dispatch_one_message() KResult Plan9FS::read_and_dispatch_one_message()
{ {
struct [[gnu::packed]] Header struct [[gnu::packed]] Header {
{
u32 size; u32 size;
u8 type; u8 type;
u16 tag; u16 tag;

3
Kernel/Interrupts/IOAPIC.h
View file

@ -30,8 +30,7 @@
#include <Kernel/VM/TypedMapping.h> #include <Kernel/VM/TypedMapping.h>
namespace Kernel { namespace Kernel {
struct [[gnu::packed]] ioapic_mmio_regs struct [[gnu::packed]] ioapic_mmio_regs {
{
volatile u32 select; volatile u32 select;
u32 reserved[3]; u32 reserved[3];
volatile u32 window; volatile u32 window;

2
Kernel/Interrupts/PIC.cpp
View file

@ -42,6 +42,7 @@ namespace Kernel {
#define PIC1_CTL 0xA0 #define PIC1_CTL 0xA0
#define PIC1_CMD 0xA1 #define PIC1_CMD 0xA1
// clang-format off
#define ICW1_ICW4 0x01 /* ICW4 (not) needed */ #define ICW1_ICW4 0x01 /* ICW4 (not) needed */
#define ICW1_SINGLE 0x02 /* Single (cascade) mode */ #define ICW1_SINGLE 0x02 /* Single (cascade) mode */
#define ICW1_INTERVAL4 0x04 /* Call address interval 4 (8) */ #define ICW1_INTERVAL4 0x04 /* Call address interval 4 (8) */
@ -53,6 +54,7 @@ namespace Kernel {
#define ICW4_BUF_SLAVE 0x08 /* Buffered mode/slave */ #define ICW4_BUF_SLAVE 0x08 /* Buffered mode/slave */
#define ICW4_BUF_MASTER 0x0C /* Buffered mode/master */ #define ICW4_BUF_MASTER 0x0C /* Buffered mode/master */
#define ICW4_SFNM 0x10 /* Special fully nested (not) */ #define ICW4_SFNM 0x10 /* Special fully nested (not) */
// clang-format on
bool inline static is_all_masked(u16 reg) bool inline static is_all_masked(u16 reg)
{ {

12
Kernel/KResult.h
View file

@ -35,8 +35,7 @@ enum KSuccessTag {
KSuccess KSuccess
}; };
class [[nodiscard]] KResult class [[nodiscard]] KResult {
{
public: public:
ALWAYS_INLINE explicit KResult(int negative_e) ALWAYS_INLINE explicit KResult(int negative_e)
: m_error(negative_e) : m_error(negative_e)
@ -62,8 +61,7 @@ private:
}; };
template<typename T> template<typename T>
class alignas(T) [[nodiscard]] KResultOr class alignas(T) [[nodiscard]] KResultOr {
{
public: public:
KResultOr(KResult error) KResultOr(KResult error)
: m_error(error) : m_error(error)
@ -71,20 +69,14 @@ public:
{ {
} }
// FIXME: clang-format gets confused about T. Why?
// clang-format off
ALWAYS_INLINE KResultOr(T&& value) ALWAYS_INLINE KResultOr(T&& value)
// clang-format on
{ {
new (&m_storage) T(move(value)); new (&m_storage) T(move(value));
m_have_storage = true; m_have_storage = true;
} }
template<typename U> template<typename U>
// FIXME: clang-format gets confused about U. Why?
// clang-format off
ALWAYS_INLINE KResultOr(U&& value) ALWAYS_INLINE KResultOr(U&& value)
// clang-format on
{ {
new (&m_storage) T(move(value)); new (&m_storage) T(move(value));
m_have_storage = true; m_have_storage = true;

3
Kernel/Net/ARP.h
View file

@ -46,8 +46,7 @@ struct ARPHardwareType {
}; };
}; };
class [[gnu::packed]] ARPPacket class [[gnu::packed]] ARPPacket {
{
public: public:
u16 hardware_type() const { return m_hardware_type; } u16 hardware_type() const { return m_hardware_type; }
void set_hardware_type(u16 w) { m_hardware_type = w; } void set_hardware_type(u16 w) { m_hardware_type = w; }

2
Kernel/Net/E1000NetworkAdapter.cpp
View file

@ -33,6 +33,7 @@
namespace Kernel { namespace Kernel {
// clang-format off
#define REG_CTRL 0x0000 #define REG_CTRL 0x0000
#define REG_STATUS 0x0008 #define REG_STATUS 0x0008
#define REG_EEPROM 0x0014 #define REG_EEPROM 0x0014
@ -139,6 +140,7 @@ namespace Kernel {
#define INTERRUPT_PHYINT (1 << 12) #define INTERRUPT_PHYINT (1 << 12)
#define INTERRUPT_TXD_LOW (1 << 15) #define INTERRUPT_TXD_LOW (1 << 15)
#define INTERRUPT_SRPD (1 << 16) #define INTERRUPT_SRPD (1 << 16)
// clang-format on
// https://www.intel.com/content/dam/doc/manual/pci-pci-x-family-gbe-controllers-software-dev-manual.pdf Section 5.2 // https://www.intel.com/content/dam/doc/manual/pci-pci-x-family-gbe-controllers-software-dev-manual.pdf Section 5.2
static bool is_valid_device_id(u16 device_id) static bool is_valid_device_id(u16 device_id)

6
Kernel/Net/E1000NetworkAdapter.h
View file

@ -54,8 +54,7 @@ private:
virtual void handle_irq(const RegisterState&) override; virtual void handle_irq(const RegisterState&) override;
virtual const char* class_name() const override { return "E1000NetworkAdapter"; } virtual const char* class_name() const override { return "E1000NetworkAdapter"; }
struct [[gnu::packed]] e1000_rx_desc struct [[gnu::packed]] e1000_rx_desc {
{
volatile uint64_t addr { 0 }; volatile uint64_t addr { 0 };
volatile uint16_t length { 0 }; volatile uint16_t length { 0 };
volatile uint16_t checksum { 0 }; volatile uint16_t checksum { 0 };
@ -64,8 +63,7 @@ private:
volatile uint16_t special { 0 }; volatile uint16_t special { 0 };
}; };
struct [[gnu::packed]] e1000_tx_desc struct [[gnu::packed]] e1000_tx_desc {
{
volatile uint64_t addr { 0 }; volatile uint64_t addr { 0 };
volatile uint16_t length { 0 }; volatile uint16_t length { 0 };
volatile uint8_t cso { 0 }; volatile uint8_t cso { 0 };

3
Kernel/Net/EthernetFrameHeader.h
View file

@ -31,8 +31,7 @@
#pragma GCC diagnostic ignored "-Warray-bounds" #pragma GCC diagnostic ignored "-Warray-bounds"
class [[gnu::packed]] EthernetFrameHeader class [[gnu::packed]] EthernetFrameHeader {
{
public: public:
EthernetFrameHeader() { } EthernetFrameHeader() { }
~EthernetFrameHeader() { } ~EthernetFrameHeader() { }

6
Kernel/Net/ICMP.h
View file

@ -36,8 +36,7 @@ struct ICMPType {
}; };
}; };
class [[gnu::packed]] ICMPHeader class [[gnu::packed]] ICMPHeader {
{
public: public:
ICMPHeader() { } ICMPHeader() { }
~ICMPHeader() { } ~ICMPHeader() { }
@ -63,8 +62,7 @@ private:
static_assert(sizeof(ICMPHeader) == 4); static_assert(sizeof(ICMPHeader) == 4);
struct [[gnu::packed]] ICMPEchoPacket struct [[gnu::packed]] ICMPEchoPacket {
{
ICMPHeader header; ICMPHeader header;
NetworkOrdered<u16> identifier; NetworkOrdered<u16> identifier;
NetworkOrdered<u16> sequence_number; NetworkOrdered<u16> sequence_number;

3
Kernel/Net/IPv4.h
View file

@ -47,8 +47,7 @@ enum class IPv4PacketFlags : u16 {
NetworkOrdered<u16> internet_checksum(const void*, size_t); NetworkOrdered<u16> internet_checksum(const void*, size_t);
class [[gnu::packed]] IPv4Packet class [[gnu::packed]] IPv4Packet {
{
public: public:
u8 version() const { return (m_version_and_ihl >> 4) & 0xf; } u8 version() const { return (m_version_and_ihl >> 4) & 0xf; }
void set_version(u8 version) { m_version_and_ihl = (m_version_and_ihl & 0x0f) | (version << 4); } void set_version(u8 version) { m_version_and_ihl = (m_version_and_ihl & 0x0f) | (version << 4); }

3
Kernel/Net/TCP.h
View file

@ -41,8 +41,7 @@ struct TCPFlags {
}; };
}; };
class [[gnu::packed]] TCPPacket class [[gnu::packed]] TCPPacket {
{
public: public:
TCPPacket() = default; TCPPacket() = default;
~TCPPacket() = default; ~TCPPacket() = default;

3
Kernel/Net/TCPSocket.cpp
View file

@ -310,8 +310,7 @@ void TCPSocket::receive_tcp_packet(const TCPPacket& packet, u16 size)
NetworkOrdered<u16> TCPSocket::compute_tcp_checksum(const IPv4Address& source, const IPv4Address& destination, const TCPPacket& packet, u16 payload_size) NetworkOrdered<u16> TCPSocket::compute_tcp_checksum(const IPv4Address& source, const IPv4Address& destination, const TCPPacket& packet, u16 payload_size)
{ {
struct [[gnu::packed]] PseudoHeader struct [[gnu::packed]] PseudoHeader {
{
IPv4Address source; IPv4Address source;
IPv4Address destination; IPv4Address destination;
u8 zero; u8 zero;

3
Kernel/Net/UDP.h
View file

@ -30,8 +30,7 @@
namespace Kernel { namespace Kernel {
class [[gnu::packed]] UDPPacket class [[gnu::packed]] UDPPacket {
{
public: public:
UDPPacket() { } UDPPacket() { }
~UDPPacket() { } ~UDPPacket() { }

2
Kernel/PCI/Definitions.h
View file

@ -34,6 +34,7 @@
namespace Kernel { namespace Kernel {
// clang-format off
#define PCI_VENDOR_ID 0x00 // word #define PCI_VENDOR_ID 0x00 // word
#define PCI_DEVICE_ID 0x02 // word #define PCI_DEVICE_ID 0x02 // word
#define PCI_COMMAND 0x04 // word #define PCI_COMMAND 0x04 // word
@ -66,6 +67,7 @@ namespace Kernel {
#define PCI_MAX_DEVICES_PER_BUS 32 #define PCI_MAX_DEVICES_PER_BUS 32
#define PCI_MAX_BUSES 256 #define PCI_MAX_BUSES 256
#define PCI_MAX_FUNCTIONS_PER_DEVICE 8 #define PCI_MAX_FUNCTIONS_PER_DEVICE 8
// clang-format on
//#define PCI_DEBUG 1 //#define PCI_DEBUG 1

9
Kernel/PerformanceEventBuffer.h
View file

@ -31,20 +31,17 @@
namespace Kernel { namespace Kernel {
struct [[gnu::packed]] MallocPerformanceEvent struct [[gnu::packed]] MallocPerformanceEvent {
{
size_t size; size_t size;
FlatPtr ptr; FlatPtr ptr;
}; };
struct [[gnu::packed]] FreePerformanceEvent struct [[gnu::packed]] FreePerformanceEvent {
{
size_t size; size_t size;
FlatPtr ptr; FlatPtr ptr;
}; };
struct [[gnu::packed]] PerformanceEvent struct [[gnu::packed]] PerformanceEvent {
{
u8 type { 0 }; u8 type { 0 };
u8 stack_size { 0 }; u8 stack_size { 0 };
u64 timestamp; u64 timestamp;

6
Kernel/Storage/Partition/GUIDPartitionTable.cpp
View file

@ -37,8 +37,7 @@ namespace Kernel {
#define GPT_SIGNATURE 0x20494645 #define GPT_SIGNATURE 0x20494645
#define BytesPerSector 512 #define BytesPerSector 512
struct [[gnu::packed]] GPTPartitionEntry struct [[gnu::packed]] GPTPartitionEntry {
{
u8 partition_guid[16]; u8 partition_guid[16];
u8 unique_guid[16]; u8 unique_guid[16];
@ -49,8 +48,7 @@ struct [[gnu::packed]] GPTPartitionEntry
char partition_name[72]; char partition_name[72];
}; };
struct [[gnu::packed]] GUIDPartitionHeader struct [[gnu::packed]] GUIDPartitionHeader {
{
u32 sig[2]; u32 sig[2];
u32 revision; u32 revision;
u32 header_size; u32 header_size;

6
Kernel/Storage/Partition/MBRPartitionTable.h
View file

@ -36,8 +36,7 @@ namespace Kernel {
class MBRPartitionTable : public PartitionTable { class MBRPartitionTable : public PartitionTable {
public: public:
struct [[gnu::packed]] Entry struct [[gnu::packed]] Entry {
{
u8 status; u8 status;
u8 chs1[3]; u8 chs1[3];
u8 type; u8 type;
@ -45,8 +44,7 @@ public:
u32 offset; u32 offset;
u32 length; u32 length;
}; };
struct [[gnu::packed]] Header struct [[gnu::packed]] Header {
{
u8 code1[218]; u8 code1[218];
u16 ts_zero; u16 ts_zero;
u8 ts_drive; u8 ts_drive;

3
Kernel/TTY/TTY.cpp
View file

@ -171,8 +171,9 @@ void TTY::emit(u8 ch, bool do_evaluate_block_conditions)
if (ch == m_termios.c_cc[VSUSP]) { if (ch == m_termios.c_cc[VSUSP]) {
dbg() << tty_name() << ": VSUSP pressed!"; dbg() << tty_name() << ": VSUSP pressed!";
generate_signal(SIGTSTP); generate_signal(SIGTSTP);
if (auto original_process_parent = m_original_process_parent.strong_ref()) if (auto original_process_parent = m_original_process_parent.strong_ref()) {
[[maybe_unused]] auto rc = original_process_parent->send_signal(SIGCHLD, nullptr); [[maybe_unused]] auto rc = original_process_parent->send_signal(SIGCHLD, nullptr);
}
// TODO: Else send it to the session leader maybe? // TODO: Else send it to the session leader maybe?
return; return;
} }

12
Kernel/Time/HPET.cpp
View file

@ -65,14 +65,12 @@ enum class TimerConfiguration : u32 {
}; };
}; };
struct [[gnu::packed]] HPETRegister struct [[gnu::packed]] HPETRegister {
{
volatile u32 low; volatile u32 low;
volatile u32 high; volatile u32 high;
}; };
struct [[gnu::packed]] TimerStructure struct [[gnu::packed]] TimerStructure {
{
volatile u32 capabilities; volatile u32 capabilities;
volatile u32 interrupt_routing; volatile u32 interrupt_routing;
HPETRegister comparator_value; HPETRegister comparator_value;
@ -80,16 +78,14 @@ struct [[gnu::packed]] TimerStructure
u64 reserved; u64 reserved;
}; };
struct [[gnu::packed]] HPETCapabilityRegister struct [[gnu::packed]] HPETCapabilityRegister {
{
// Note: We must do a 32 bit access to offsets 0x0, or 0x4 only, according to HPET spec. // Note: We must do a 32 bit access to offsets 0x0, or 0x4 only, according to HPET spec.
volatile u32 attributes; volatile u32 attributes;
volatile u32 main_counter_tick_period; volatile u32 main_counter_tick_period;
u64 reserved; u64 reserved;
}; };
struct [[gnu::packed]] HPETRegistersBlock struct [[gnu::packed]] HPETRegistersBlock {
{
HPETCapabilityRegister capabilities; HPETCapabilityRegister capabilities;
HPETRegister configuration; HPETRegister configuration;
u64 reserved1; u64 reserved1;

3
Kernel/UnixTypes.h
View file

@ -604,6 +604,8 @@ struct ifreq {
void* ifru_data; void* ifru_data;
unsigned int ifru_index; unsigned int ifru_index;
} ifr_ifru; } ifr_ifru;
// clang-format off
#define ifr_addr ifr_ifru.ifru_addr // address #define ifr_addr ifr_ifru.ifru_addr // address
#define ifr_dstaddr ifr_ifru.ifru_dstaddr // other end of p-to-p link #define ifr_dstaddr ifr_ifru.ifru_dstaddr // other end of p-to-p link
#define ifr_broadaddr ifr_ifru.ifru_broadaddr // broadcast address #define ifr_broadaddr ifr_ifru.ifru_broadaddr // broadcast address
@ -620,6 +622,7 @@ struct ifreq {
#define ifr_index ifr_ifru.ifru_index // interface index #define ifr_index ifr_ifru.ifru_index // interface index
#define ifr_llprio ifr_ifru.ifru_metric // link layer priority #define ifr_llprio ifr_ifru.ifru_metric // link layer priority
#define ifr_hwaddr ifr_ifru.ifru_hwaddr // MAC address #define ifr_hwaddr ifr_ifru.ifru_hwaddr // MAC address
// clang-format on
}; };
struct rtentry { struct rtentry {

3
Libraries/LibC/dirent.cpp
View file

@ -64,8 +64,7 @@ int closedir(DIR* dirp)
return rc; return rc;
} }
struct [[gnu::packed]] sys_dirent struct [[gnu::packed]] sys_dirent {
{
ino_t ino; ino_t ino;
u8 file_type; u8 file_type;
size_t namelen; size_t namelen;

3
Libraries/LibC/net/if.h
View file

@ -47,6 +47,8 @@ struct ifreq {
void* ifru_data; void* ifru_data;
unsigned int ifru_index; unsigned int ifru_index;
} ifr_ifru; } ifr_ifru;
// clang-format off
#define ifr_addr ifr_ifru.ifru_addr // address #define ifr_addr ifr_ifru.ifru_addr // address
#define ifr_dstaddr ifr_ifru.ifru_dstaddr // other end of p-to-p link #define ifr_dstaddr ifr_ifru.ifru_dstaddr // other end of p-to-p link
#define ifr_broadaddr ifr_ifru.ifru_broadaddr // broadcast address #define ifr_broadaddr ifr_ifru.ifru_broadaddr // broadcast address
@ -63,6 +65,7 @@ struct ifreq {
#define ifr_index ifr_ifru.ifru_index // interface index #define ifr_index ifr_ifru.ifru_index // interface index
#define ifr_llprio ifr_ifru.ifru_metric // link layer priority #define ifr_llprio ifr_ifru.ifru_metric // link layer priority
#define ifr_hwaddr ifr_ifru.ifru_hwaddr // MAC address #define ifr_hwaddr ifr_ifru.ifru_hwaddr // MAC address
// clang-format on
}; };
__END_DECLS __END_DECLS

2
Libraries/LibC/regex.h
View file

@ -101,6 +101,7 @@ enum __RegexAllFlags {
__Regex_Last = __Regex_SkipTrimEmptyMatches __Regex_Last = __Regex_SkipTrimEmptyMatches
}; };
// clang-format off
// Values for the cflags parameter to the regcomp() function: // Values for the cflags parameter to the regcomp() function:
#define REG_EXTENDED __Regex_Extended // Use Extended Regular Expressions. #define REG_EXTENDED __Regex_Extended // Use Extended Regular Expressions.
#define REG_ICASE __Regex_Insensitive // Ignore case in match. #define REG_ICASE __Regex_Insensitive // Ignore case in match.
@ -114,6 +115,7 @@ enum __RegexAllFlags {
//static_assert (sizeof(FlagsUnderlyingType) * 8 >= regex::POSIXFlags::Last << 1), "flags type too small") //static_assert (sizeof(FlagsUnderlyingType) * 8 >= regex::POSIXFlags::Last << 1), "flags type too small")
#define REG_SEARCH __Regex_Last << 1 #define REG_SEARCH __Regex_Last << 1
// clang-format on
int regcomp(regex_t*, const char*, int); int regcomp(regex_t*, const char*, int);
int regexec(const regex_t*, const char*, size_t, regmatch_t[], int); int regexec(const regex_t*, const char*, size_t, regmatch_t[], int);

3
Libraries/LibC/sys/arch/i386/regs.h
View file

@ -28,8 +28,7 @@
#include <AK/Types.h> #include <AK/Types.h>
struct [[gnu::packed]] PtraceRegisters struct [[gnu::packed]] PtraceRegisters {
{
u32 eax; u32 eax;
u32 ecx; u32 ecx;
u32 edx; u32 edx;

3
Libraries/LibCompress/Gzip.h
View file

@ -45,8 +45,7 @@ public:
static Optional<ByteBuffer> decompress_all(ReadonlyBytes); static Optional<ByteBuffer> decompress_all(ReadonlyBytes);
private: private:
struct [[gnu::packed]] BlockHeader struct [[gnu::packed]] BlockHeader {
{
u8 identification_1; u8 identification_1;
u8 identification_2; u8 identification_2;
u8 compression_method; u8 compression_method;

6
Libraries/LibDebug/Dwarf/DwarfTypes.h
View file

@ -30,8 +30,7 @@
namespace Debug::Dwarf { namespace Debug::Dwarf {
struct [[gnu::packed]] CompilationUnitHeader struct [[gnu::packed]] CompilationUnitHeader {
{
u32 length; u32 length;
u16 version; u16 version;
u32 abbrev_offset; u32 abbrev_offset;
@ -287,8 +286,7 @@ enum class AttributeDataForm : u8 {
AddrX4 = 0x2c AddrX4 = 0x2c
}; };
struct [[gnu::packed]] AttributeSpecification struct [[gnu::packed]] AttributeSpecification {
{
Attribute attribute; Attribute attribute;
AttributeDataForm form; AttributeDataForm form;
}; };

3
Libraries/LibDebug/Dwarf/LineProgram.h
View file

@ -57,8 +57,7 @@ private:
void handle_standard_opcode(u8 opcode); void handle_standard_opcode(u8 opcode);
void handle_sepcial_opcode(u8 opcode); void handle_sepcial_opcode(u8 opcode);
struct [[gnu::packed]] UnitHeader32 struct [[gnu::packed]] UnitHeader32 {
{
u32 length; u32 length;
u16 version; u16 version;
u32 header_length; u32 header_length;

2
Libraries/LibELF/AuxiliaryVector.h
View file

@ -40,6 +40,7 @@ typedef struct
} a_un; } a_un;
} auxv_t; } auxv_t;
// clang-format off
#define AT_NULL 0 /* No length, last entry's a_type has this value */ #define AT_NULL 0 /* No length, last entry's a_type has this value */
#define AT_IGNORE 1 /* Entry has no meaning, a_un undefined */ #define AT_IGNORE 1 /* Entry has no meaning, a_un undefined */
#define AT_EXECFD 2 /* a_val contains a file descriptor of the main program image */ #define AT_EXECFD 2 /* a_val contains a file descriptor of the main program image */
@ -65,6 +66,7 @@ typedef struct
#define AT_EXECFN 31 /* a_ptr points to file name of executed program */ #define AT_EXECFN 31 /* a_ptr points to file name of executed program */
#define AT_EXE_BASE 32 /* a_ptr holds base address where main program was loaded into memory */ #define AT_EXE_BASE 32 /* a_ptr holds base address where main program was loaded into memory */
#define AT_EXE_SIZE 33 /* a_val holds the size of the main program in memory */ #define AT_EXE_SIZE 33 /* a_val holds the size of the main program in memory */
// clang-format on
namespace ELF { namespace ELF {

18
Libraries/LibELF/CoreDump.h
View file

@ -32,8 +32,7 @@
namespace ELF::Core { namespace ELF::Core {
struct [[gnu::packed]] NotesEntryHeader struct [[gnu::packed]] NotesEntryHeader {
{
enum Type : u8 { enum Type : u8 {
Null = 0, // Terminates segment Null = 0, // Terminates segment
ProcessInfo, ProcessInfo,
@ -44,28 +43,24 @@ struct [[gnu::packed]] NotesEntryHeader
Type type; Type type;
}; };
struct [[gnu::packed]] NotesEntry struct [[gnu::packed]] NotesEntry {
{
NotesEntryHeader header; NotesEntryHeader header;
char data[]; char data[];
}; };
struct [[gnu::packed]] ProcessInfo struct [[gnu::packed]] ProcessInfo {
{
NotesEntryHeader header; NotesEntryHeader header;
int pid; int pid;
char executable_path[]; // Null terminated char executable_path[]; // Null terminated
}; };
struct [[gnu::packed]] ThreadInfo struct [[gnu::packed]] ThreadInfo {
{
NotesEntryHeader header; NotesEntryHeader header;
int tid; int tid;
PtraceRegisters regs; PtraceRegisters regs;
}; };
struct [[gnu::packed]] MemoryRegionInfo struct [[gnu::packed]] MemoryRegionInfo {
{
NotesEntryHeader header; NotesEntryHeader header;
uint32_t region_start; uint32_t region_start;
uint32_t region_end; uint32_t region_end;
@ -83,8 +78,7 @@ struct [[gnu::packed]] MemoryRegionInfo
} }
}; };
struct [[gnu::packed]] Metadata struct [[gnu::packed]] Metadata {
{
NotesEntryHeader header; NotesEntryHeader header;
char json_data[]; // Null terminated char json_data[]; // Null terminated
}; };

3
Libraries/LibGfx/Font.cpp
View file

@ -44,8 +44,7 @@
namespace Gfx { namespace Gfx {
struct [[gnu::packed]] FontFileHeader struct [[gnu::packed]] FontFileHeader {
{
char magic[4]; char magic[4];
u8 glyph_width; u8 glyph_width;
u8 glyph_height; u8 glyph_height;

6
Libraries/LibGfx/ICOLoader.cpp
View file

@ -60,8 +60,7 @@ struct ICONDIRENTRY {
}; };
static_assert(sizeof(ICONDIRENTRY) == 16); static_assert(sizeof(ICONDIRENTRY) == 16);
struct [[gnu::packed]] BMPFILEHEADER struct [[gnu::packed]] BMPFILEHEADER {
{
u8 signature[2]; u8 signature[2];
u32 size; u32 size;
u16 reserved1; u16 reserved1;
@ -85,8 +84,7 @@ struct BITMAPINFOHEADER {
}; };
static_assert(sizeof(BITMAPINFOHEADER) == 40); static_assert(sizeof(BITMAPINFOHEADER) == 40);
struct [[gnu::packed]] BMP_ARGB struct [[gnu::packed]] BMP_ARGB {
{
u8 b; u8 b;
u8 g; u8 g;
u8 r; u8 r;

15
Libraries/LibGfx/PNGLoader.cpp
View file

@ -64,8 +64,7 @@ struct Scanline {
ReadonlyBytes data {}; ReadonlyBytes data {};
}; };
struct [[gnu::packed]] PaletteEntry struct [[gnu::packed]] PaletteEntry {
{
u8 r; u8 r;
u8 g; u8 g;
u8 b; u8 b;
@ -73,23 +72,20 @@ struct [[gnu::packed]] PaletteEntry
}; };
template<typename T> template<typename T>
struct [[gnu::packed]] Tuple struct [[gnu::packed]] Tuple {
{
T gray; T gray;
T a; T a;
}; };
template<typename T> template<typename T>
struct [[gnu::packed]] Triplet struct [[gnu::packed]] Triplet {
{
T r; T r;
T g; T g;
T b; T b;
}; };
template<typename T> template<typename T>
struct [[gnu::packed]] Quad struct [[gnu::packed]] Quad {
{
T r; T r;
T g; T g;
T b; T b;
@ -227,8 +223,7 @@ ALWAYS_INLINE static u8 paeth_predictor(int a, int b, int c)
return c; return c;
} }
union [[gnu::packed]] Pixel union [[gnu::packed]] Pixel {
{
RGBA32 rgba { 0 }; RGBA32 rgba { 0 };
u8 v[4]; u8 v[4];
struct { struct {

3
Libraries/LibLine/Editor.cpp
View file

@ -856,7 +856,8 @@ void Editor::handle_read_event()
} }
reverse_tab = false; reverse_tab = false;
auto completion_mode = m_times_tab_pressed == 1 ? SuggestionManager::CompletePrefix : m_times_tab_pressed == 2 ? SuggestionManager::ShowSuggestions : SuggestionManager::CycleSuggestions; auto completion_mode = m_times_tab_pressed == 1 ? SuggestionManager::CompletePrefix : m_times_tab_pressed == 2 ? SuggestionManager::ShowSuggestions
: SuggestionManager::CycleSuggestions;
auto completion_result = m_suggestion_manager.attempt_completion(completion_mode, token_start); auto completion_result = m_suggestion_manager.attempt_completion(completion_mode, token_start);

3
Libraries/LibWeb/HTML/AttributeNames.cpp
View file

@ -34,10 +34,7 @@ namespace AttributeNames {
ENUMERATE_HTML_ATTRIBUTES ENUMERATE_HTML_ATTRIBUTES
#undef __ENUMERATE_HTML_ATTRIBUTE #undef __ENUMERATE_HTML_ATTRIBUTE
// clang-format off
// FIXME: clang-format gets confused here. Why?
[[gnu::constructor]] static void initialize() [[gnu::constructor]] static void initialize()
// clang-format off
{ {
static bool s_initialized = false; static bool s_initialized = false;
if (s_initialized) if (s_initialized)

3
Libraries/LibWeb/HTML/EventNames.cpp
View file

@ -32,10 +32,7 @@ namespace Web::HTML::EventNames {
ENUMERATE_HTML_EVENTS ENUMERATE_HTML_EVENTS
#undef __ENUMERATE_HTML_EVENT #undef __ENUMERATE_HTML_EVENT
// clang-format off
// FIXME: clang-format gets confused here. Why?
[[gnu::constructor]] static void initialize() [[gnu::constructor]] static void initialize()
// clang-format on
{ {
static bool s_initialized = false; static bool s_initialized = false;
if (s_initialized) if (s_initialized)

3
Libraries/LibWeb/HTML/TagNames.cpp
View file

@ -32,10 +32,7 @@ namespace Web::HTML::TagNames {
ENUMERATE_HTML_TAGS ENUMERATE_HTML_TAGS
#undef __ENUMERATE_HTML_TAG #undef __ENUMERATE_HTML_TAG
// clang-format off
// FIXME: clang-format gets confused here. Why?
[[gnu::constructor]] static void initialize() [[gnu::constructor]] static void initialize()
// clang-format on
{ {
static bool s_initialized = false; static bool s_initialized = false;
if (s_initialized) if (s_initialized)

3
Libraries/LibWeb/Namespace.cpp
View file

@ -32,10 +32,7 @@ namespace Web::Namespace {
ENUMERATE_NAMESPACES ENUMERATE_NAMESPACES
#undef __ENUMERATE_NAMESPACE #undef __ENUMERATE_NAMESPACE
// clang-format off
// FIXME: clang-format gets confused here. Why?
[[gnu::constructor]] static void initialize() [[gnu::constructor]] static void initialize()
// clang-format on
{ {
static bool s_initialized = false; static bool s_initialized = false;
if (s_initialized) if (s_initialized)

3
Libraries/LibWeb/SVG/TagNames.cpp
View file

@ -32,10 +32,7 @@ namespace Web::SVG::TagNames {
ENUMERATE_SVG_TAGS ENUMERATE_SVG_TAGS
#undef __ENUMERATE_SVG_TAG #undef __ENUMERATE_SVG_TAG
// clang-format off
// FIXME: clang-format gets confused here. Why?
[[gnu::constructor]] static void initialize() [[gnu::constructor]] static void initialize()
// clang-format on
{ {
static bool s_initialized = false; static bool s_initialized = false;
if (s_initialized) if (s_initialized)

3
Libraries/LibWeb/UIEvents/EventNames.cpp
View file

@ -32,10 +32,7 @@ namespace Web::UIEvents::EventNames {
ENUMERATE_UI_EVENTS ENUMERATE_UI_EVENTS
#undef __ENUMERATE_UI_EVENT #undef __ENUMERATE_UI_EVENT
// clang-format off
// FIXME: clang-format gets confused here. Why?
[[gnu::constructor]] static void initialize() [[gnu::constructor]] static void initialize()
// clang-format on
{ {
static bool s_initialized = false; static bool s_initialized = false;
if (s_initialized) if (s_initialized)

3
Services/DHCPClient/DHCPv4.h
View file

@ -194,8 +194,7 @@ struct ParsedDHCPv4Options {
constexpr auto DHCPV4_OPTION_FIELD_MAX_LENGTH = 312; constexpr auto DHCPV4_OPTION_FIELD_MAX_LENGTH = 312;
class [[gnu::packed]] DHCPv4Packet class [[gnu::packed]] DHCPv4Packet {
{
public: public:
u8 op() const { return m_op; } u8 op() const { return m_op; }
void set_op(DHCPv4Op op) { m_op = (u8)op; } void set_op(DHCPv4Op op) { m_op = (u8)op; }

3
Services/LookupServer/DNSPacket.h
View file

@ -29,8 +29,7 @@
#include <AK/Endian.h> #include <AK/Endian.h>
#include <AK/Types.h> #include <AK/Types.h>
class [[gnu::packed]] DNSPacket class [[gnu::packed]] DNSPacket {
{
public: public:
DNSPacket() DNSPacket()
: m_recursion_desired(false) : m_recursion_desired(false)

3
Services/LookupServer/DNSResponse.cpp
View file

@ -32,8 +32,7 @@
static String parse_dns_name(const u8* data, size_t& offset, size_t max_offset, size_t recursion_level = 0); static String parse_dns_name(const u8* data, size_t& offset, size_t max_offset, size_t recursion_level = 0);
class [[gnu::packed]] DNSRecordWithoutName class [[gnu::packed]] DNSRecordWithoutName {
{
public: public:
DNSRecordWithoutName() { } DNSRecordWithoutName() { }

6
Userland/Tests/LibC/accuracy-strtod.cpp
View file

@ -314,10 +314,12 @@ static bool is_strtod_close(strtod_fn_t strtod_fn, const char* test_string, cons
bool wrong_cns = !error_cns && (actual_consume != expect_consume); bool wrong_cns = !error_cns && (actual_consume != expect_consume);
printf(" %s%s%s(%s%2u%s)", printf(" %s%s%s(%s%2u%s)",
ofby1_hex ? TEXT_OFBY1 : wrong_hex ? TEXT_WRONG : "", ofby1_hex ? TEXT_OFBY1 : wrong_hex ? TEXT_WRONG
: "",
actual_hex, actual_hex,
(ofby1_hex || wrong_hex) ? TEXT_RESET : "", (ofby1_hex || wrong_hex) ? TEXT_RESET : "",
error_cns ? TEXT_ERROR : wrong_cns ? TEXT_WRONG : "", error_cns ? TEXT_ERROR : wrong_cns ? TEXT_WRONG
: "",
actual_consume, actual_consume,
(error_cns || wrong_cns) ? TEXT_RESET : ""); (error_cns || wrong_cns) ? TEXT_RESET : "");

3
Userland/ntpquery.cpp
View file

@ -46,8 +46,7 @@
// The fractional part in the lower 32 bits stores fractional bits times 2 ** 32. // The fractional part in the lower 32 bits stores fractional bits times 2 ** 32.
typedef uint64_t NtpTimestamp; typedef uint64_t NtpTimestamp;
struct [[gnu::packed]] NtpPacket struct [[gnu::packed]] NtpPacket {
{
uint8_t li_vn_mode; uint8_t li_vn_mode;
uint8_t stratum; uint8_t stratum;
int8_t poll; int8_t poll;