Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-09 17:44:56 +09:00
Code Activity

Revert "LibWeb: Skip "overlay" paint phase when there's no inspected node"

Browse source 
This reverts commit dc56435ecd.

It broke overlay scrollbars.
This commit is contained in:
Andreas Kling 2025-03-28 20:08:43 +00:00
parent b688fe0396
commit ba8aabdeb0
Notes: github-actions[bot] 2025-03-28 20:10:44 +00:00
1 changed files with 3 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Libraries/LibWeb/Painting/StackingContext.cpp
View file

@ -93,8 +93,7 @@ void StackingContext::paint_node_as_stacking_context(Paintable const& paintable,
paint_node(paintable, context, PaintPhase::Foreground);
paint_descendants(context, paintable, StackingContextPaintPhase::Foreground);
paint_node(paintable, context, PaintPhase::Outline);
if (paintable.document().highlighted_layout_node())
paint_node(paintable, context, PaintPhase::Overlay);
paint_node(paintable, context, PaintPhase::Overlay);
paint_descendants(context, paintable, StackingContextPaintPhase::FocusAndOverlay);
}
@ -187,8 +186,7 @@ void StackingContext::paint_descendants(PaintContext& context, Paintable const&
break;
case StackingContextPaintPhase::FocusAndOverlay:
paint_node(child, context, PaintPhase::Outline);
if (child.document().highlighted_layout_node())
paint_node(child, context, PaintPhase::Overlay);
paint_node(child, context, PaintPhase::Overlay);
paint_descendants(context, child, phase);
break;
}
@ -280,8 +278,7 @@ void StackingContext::paint_internal(PaintContext& context) const
paint_node(paintable_box(), context, PaintPhase::Outline);
if (context.should_paint_overlay()) {
if (paintable_box().document().highlighted_layout_node())
paint_node(paintable_box(), context, PaintPhase::Overlay);
paint_node(paintable_box(), context, PaintPhase::Overlay);
paint_descendants(context, paintable_box(), StackingContextPaintPhase::FocusAndOverlay);
}
}