From b8bb8345a9d229c6d4a4a104fadff22972c413c0 Mon Sep 17 00:00:00 2001 From: stelar7 Date: Tue, 13 May 2025 22:46:23 +0200 Subject: [PATCH] LibWeb/IDB: Implement IDBIndex::getAllKeys --- Libraries/LibWeb/IndexedDB/IDBIndex.cpp | 31 +++++++++++++++++++ Libraries/LibWeb/IndexedDB/IDBIndex.h | 1 + Libraries/LibWeb/IndexedDB/IDBIndex.idl | 2 +- .../LibWeb/IndexedDB/Internal/Algorithms.cpp | 28 +++++++++++++++++ .../LibWeb/IndexedDB/Internal/Algorithms.h | 1 + 5 files changed, 62 insertions(+), 1 deletion(-) diff --git a/Libraries/LibWeb/IndexedDB/IDBIndex.cpp b/Libraries/LibWeb/IndexedDB/IDBIndex.cpp index de71ac37e61..d0212b88c68 100644 --- a/Libraries/LibWeb/IndexedDB/IDBIndex.cpp +++ b/Libraries/LibWeb/IndexedDB/IDBIndex.cpp @@ -234,4 +234,35 @@ WebIDL::ExceptionOr> IDBIndex::get_all(Optional q return result; } +// https://w3c.github.io/IndexedDB/#dom-idbindex-getallkeys +WebIDL::ExceptionOr> IDBIndex::get_all_keys(Optional query, Optional count) +{ + auto& realm = this->realm(); + + // 1. Let transaction be this’s transaction. + auto transaction = this->transaction(); + + // 2. Let index be this’s index. + auto index = this->index(); + + // FIXME: 3. If index or index’s object store has been deleted, throw an "InvalidStateError" DOMException. + + // 4. If transaction’s state is not active, then throw a "TransactionInactiveError" DOMException. + if (transaction->state() != IDBTransaction::TransactionState::Active) + return WebIDL::TransactionInactiveError::create(realm, "Transaction is not active while getting all keys"_string); + + // 5. Let range be the result of converting a value to a key range with query. Rethrow any exceptions. + auto range = TRY(convert_a_value_to_a_key_range(realm, query)); + + // 6. Let operation be an algorithm to run retrieve multiple values from an index with index, range, and count if given. + auto operation = GC::Function()>::create(realm.heap(), [&realm, index, range, count] -> WebIDL::ExceptionOr { + return retrieve_multiple_values_from_an_index(realm, index, range, count); + }); + + // 7. Return the result (an IDBRequest) of running asynchronously execute a request with this and operation. + auto result = asynchronously_execute_a_request(realm, GC::Ref(*this), operation); + dbgln_if(IDB_DEBUG, "Executing request for get all keys with uuid {}", result->uuid()); + return result; +} + } diff --git a/Libraries/LibWeb/IndexedDB/IDBIndex.h b/Libraries/LibWeb/IndexedDB/IDBIndex.h index 90bdf696828..c1e1585570d 100644 --- a/Libraries/LibWeb/IndexedDB/IDBIndex.h +++ b/Libraries/LibWeb/IndexedDB/IDBIndex.h @@ -32,6 +32,7 @@ public: [[nodiscard]] WebIDL::ExceptionOr> get(JS::Value); [[nodiscard]] WebIDL::ExceptionOr> get_key(JS::Value); [[nodiscard]] WebIDL::ExceptionOr> get_all(Optional, Optional); + [[nodiscard]] WebIDL::ExceptionOr> get_all_keys(Optional, Optional); [[nodiscard]] WebIDL::ExceptionOr> open_cursor(JS::Value, Bindings::IDBCursorDirection = Bindings::IDBCursorDirection::Next); // The transaction of an index handle is the transaction of its associated object store handle. diff --git a/Libraries/LibWeb/IndexedDB/IDBIndex.idl b/Libraries/LibWeb/IndexedDB/IDBIndex.idl index b904ac1b236..38f314f316b 100644 --- a/Libraries/LibWeb/IndexedDB/IDBIndex.idl +++ b/Libraries/LibWeb/IndexedDB/IDBIndex.idl @@ -10,7 +10,7 @@ interface IDBIndex { [NewObject] IDBRequest get(any query); [NewObject] IDBRequest getKey(any query); [NewObject] IDBRequest getAll(optional any query, optional [EnforceRange] unsigned long count); - [FIXME, NewObject] IDBRequest getAllKeys(optional any query, optional [EnforceRange] unsigned long count); + [NewObject] IDBRequest getAllKeys(optional any query, optional [EnforceRange] unsigned long count); [FIXME, NewObject] IDBRequest count(optional any query); [NewObject] IDBRequest openCursor(optional any query, optional IDBCursorDirection direction = "next"); [FIXME, NewObject] IDBRequest openKeyCursor(optional any query, optional IDBCursorDirection direction = "next"); diff --git a/Libraries/LibWeb/IndexedDB/Internal/Algorithms.cpp b/Libraries/LibWeb/IndexedDB/Internal/Algorithms.cpp index db2027a73d3..73e24d6f9c3 100644 --- a/Libraries/LibWeb/IndexedDB/Internal/Algorithms.cpp +++ b/Libraries/LibWeb/IndexedDB/Internal/Algorithms.cpp @@ -1991,4 +1991,32 @@ GC::Ref retrieve_multiple_referenced_values_from_an_index(JS::Realm& return list; } +// https://w3c.github.io/IndexedDB/#retrieve-multiple-values-from-an-index +GC::Ref retrieve_multiple_values_from_an_index(JS::Realm& realm, GC::Ref index, GC::Ref range, Optional count) +{ + // 1. If count is not given or is 0 (zero), let count be infinity. + if (count.has_value() && *count == 0) + count = OptionalNone(); + + // 2. Let records be a list containing the first count records in index’s list of records whose key is in range. + auto records = index->first_n_in_range(range, count); + + // 3. Let list be an empty list. + auto list = MUST(JS::Array::create(realm, records.size())); + + // 4. For each record of records: + for (u32 i = 0; i < records.size(); ++i) { + auto& record = records[i]; + + // 1. Let entry be the result of converting a key to a value with record’s value. + auto entry = convert_a_key_to_a_value(realm, record.value); + + // 2. Append entry to list. + MUST(list->create_data_property_or_throw(i, entry)); + } + + // 7. Return list converted to a sequence. + return list; +} + } diff --git a/Libraries/LibWeb/IndexedDB/Internal/Algorithms.h b/Libraries/LibWeb/IndexedDB/Internal/Algorithms.h index d32cd13aaea..10b88e91e91 100644 --- a/Libraries/LibWeb/IndexedDB/Internal/Algorithms.h +++ b/Libraries/LibWeb/IndexedDB/Internal/Algorithms.h @@ -54,5 +54,6 @@ GC::Ref retrieve_multiple_keys_from_an_object_store(JS::Realm&, GC::R JS::Value retrieve_a_referenced_value_from_an_index(JS::Realm&, GC::Ref, GC::Ref); JS::Value retrieve_a_value_from_an_index(JS::Realm&, GC::Ref, GC::Ref); GC::Ref retrieve_multiple_referenced_values_from_an_index(JS::Realm&, GC::Ref, GC::Ref, Optional); +GC::Ref retrieve_multiple_values_from_an_index(JS::Realm&, GC::Ref, GC::Ref, Optional); }