From af26b76e0accf6eb7ef673b02501ba2c235a991b Mon Sep 17 00:00:00 2001 From: martinfalisse Date: Mon, 8 May 2023 13:17:16 +0200 Subject: [PATCH] LibWebView: Use Vector for arguments to WebContent In a future commit will add some more conditional arguments to the array and so it's easier to have it be a Vector. --- Userland/Libraries/LibWebView/ViewImplementation.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Userland/Libraries/LibWebView/ViewImplementation.cpp b/Userland/Libraries/LibWebView/ViewImplementation.cpp index 0686544921d..7ad00295f4d 100644 --- a/Userland/Libraries/LibWebView/ViewImplementation.cpp +++ b/Userland/Libraries/LibWebView/ViewImplementation.cpp @@ -152,7 +152,7 @@ ErrorOr> ViewImplementation::launch_web ErrorOr result; for (auto const& path : candidate_web_content_paths) { constexpr auto callgrind_prefix_length = 3; - auto arguments_with_callgrind_prefix = Array { + auto arguments = Vector { "valgrind"sv, "--tool=callgrind"sv, "--instr-atstart=no"sv, @@ -160,11 +160,10 @@ ErrorOr> ViewImplementation::launch_web "--webcontent-fd-passing-socket"sv, webcontent_fd_passing_socket_string }; - auto arguments = arguments_with_callgrind_prefix.span(); if (enable_callgrind_profiling == EnableCallgrindProfiling::No) - arguments = arguments.slice(callgrind_prefix_length); + arguments.remove(0, callgrind_prefix_length); - result = Core::System::exec(arguments[0], arguments, Core::System::SearchInPath::Yes); + result = Core::System::exec(arguments[0], arguments.span(), Core::System::SearchInPath::Yes); if (!result.is_error()) break; }