From a821fc03be50b6b06c2d774906c0a8a747b8c64e Mon Sep 17 00:00:00 2001 From: stasoid Date: Sat, 15 Feb 2025 19:20:58 +0500 Subject: [PATCH] Headless: Compile on Windows --- UI/Headless/Fixture.cpp | 13 +++++++++++++ UI/Headless/Test.cpp | 4 ++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/UI/Headless/Fixture.cpp b/UI/Headless/Fixture.cpp index d17281e599b..1a32a3573d5 100644 --- a/UI/Headless/Fixture.cpp +++ b/UI/Headless/Fixture.cpp @@ -45,6 +45,18 @@ private: Optional m_process; }; +#ifdef AK_OS_WINDOWS +// FIXME: Implement Ladybird::HttpEchoServerFixture::setup on Windows +ErrorOr HttpEchoServerFixture::setup(WebView::WebContentOptions&) +{ + VERIFY(0 && "Ladybird::HttpEchoServerFixture::setup is not implemented"); +} +// FIXME: Implement Ladybird::HttpEchoServerFixture::teardown_impl on Windows +void HttpEchoServerFixture::teardown_impl() +{ + VERIFY(0 && "Ladybird::HttpEchoServerFixture::teardown_impl is not implemented"); +} +#else ErrorOr HttpEchoServerFixture::setup(WebView::WebContentOptions& web_content_options) { auto const script_path = LexicalPath::join(s_fixtures_path, m_script_path); @@ -99,6 +111,7 @@ void HttpEchoServerFixture::teardown_impl() m_process = {}; } +#endif void Fixture::initialize_fixtures() { diff --git a/UI/Headless/Test.cpp b/UI/Headless/Test.cpp index e66d3176db6..b887a688f19 100644 --- a/UI/Headless/Test.cpp +++ b/UI/Headless/Test.cpp @@ -183,7 +183,7 @@ void run_dump_test(HeadlessWebView& view, Test& test, URL::URL const& url, int t return TestResult::Pass; } - auto const color_output = isatty(STDOUT_FILENO) ? Diff::ColorOutput::Yes : Diff::ColorOutput::No; + auto const color_output = TRY(Core::System::isatty(STDOUT_FILENO)) ? Diff::ColorOutput::Yes : Diff::ColorOutput::No; if (color_output == Diff::ColorOutput::Yes) outln("\n\033[33;1mTest failed\033[0m: {}", url); @@ -558,7 +558,7 @@ ErrorOr run_tests(Core::AnonymousBuffer const& theme, Web::DevicePixelSize bool all_tests_ok = true; // Keep clearing and reusing the same line if stdout is a TTY. - bool log_on_one_line = app.verbosity < Application::VERBOSITY_LEVEL_LOG_TEST_DURATION && isatty(STDOUT_FILENO) == 1; + bool log_on_one_line = app.verbosity < Application::VERBOSITY_LEVEL_LOG_TEST_DURATION && TRY(Core::System::isatty(STDOUT_FILENO)); outln("Running {} tests...", tests.size()); auto all_tests_complete = Core::Promise::construct();