Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-08 05:27:14 +09:00
Code Activity

Everywhere: Fix trivial -Wunnecessary-virtual-specifier instances

Browse source 
- `Threading::Thread` is not polymorphic, there is no need for a virtual
  destructor.
- `HTMLAnchorElement::has_download_preference` isn't overridden by
  anything.

This warning was introduced in llvm/llvm-project#131188.
This commit is contained in:
Daniel Bertalan 2025-05-12 15:31:17 +02:00 • committed by Andrew Kaster
parent 456d750539
commit a2167f126d
Notes: github-actions[bot] 2025-05-12 17:41:45 +00:00
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibThreading/Thread.h
View file

@ -55,7 +55,7 @@ public:
return adopt_nonnull_ref_or_enomem(new (nothrow) Thread(move(action), thread_name)); return adopt_nonnull_ref_or_enomem(new (nothrow) Thread(move(action), thread_name));
} }
virtual ~Thread(); ~Thread();
ErrorOr<void> set_priority(int priority); ErrorOr<void> set_priority(int priority);
ErrorOr<int> get_priority() const; ErrorOr<int> get_priority() const;

4
Libraries/LibWeb/HTML/HTMLAnchorElement.h
View file

@ -38,12 +38,14 @@ public:
private: private:
HTMLAnchorElement(DOM::Document&, DOM::QualifiedName); HTMLAnchorElement(DOM::Document&, DOM::QualifiedName);
bool has_download_preference() const;
virtual void initialize(JS::Realm&) override; virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override; virtual void visit_edges(Cell::Visitor&) override;
// ^DOM::EventTarget
virtual bool has_activation_behavior() const override; virtual bool has_activation_behavior() const override;
virtual void activation_behavior(Web::DOM::Event const&) override; virtual void activation_behavior(Web::DOM::Event const&) override;
virtual bool has_download_preference() const;
// ^DOM::Element // ^DOM::Element
virtual void attribute_changed(FlyString const& name, Optional<String> const& old_value, Optional<String> const& value, Optional<FlyString> const& namespace_) override; virtual void attribute_changed(FlyString const& name, Optional<String> const& old_value, Optional<String> const& value, Optional<FlyString> const& namespace_) override;