Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-09 09:34:57 +09:00
Code Activity

LibCore: Improve support for the macOS file watcher with actual files

Browse source 
When asked to monitor a file (not a directory), we often need to instead
monitor the parent directory to receive FS events. For example, when a
symbolic link is deleted/created, we don't receive any events unless we
are watching the parent.
This commit is contained in:
Timothy Flynn 2024-08-23 14:23:57 -04:00 • committed by Andreas Kling
parent 574b4be433
commit 9f496a9c65
Notes: github-actions[bot] 2024-08-25 07:48:58 +00:00
2 changed files with 74 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

46
Tests/LibCore/TestLibCoreFileWatcher.cpp
View file

@ -4,9 +4,13 @@
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <AK/LexicalPath.h>
#include <LibCore/EventLoop.h>
#include <LibCore/File.h>
#include <LibCore/FileWatcher.h>
#include <LibCore/System.h>
#include <LibCore/Timer.h>
#include <LibFileSystem/FileSystem.h>
#include <LibTest/TestCase.h>
#include <fcntl.h>
#include <unistd.h>
@ -61,3 +65,45 @@ TEST_CASE(file_watcher_child_events)
event_loop.exec();
}
TEST_CASE(contents_changed)
{
auto event_loop = Core::EventLoop();
auto temp_path = MUST(FileSystem::real_path("/tmp"sv));
auto test_path = LexicalPath::join(temp_path, "testfile"sv);
auto write_file = [&](auto contents) {
auto file = MUST(Core::File::open(test_path.string(), Core::File::OpenMode::Write));
MUST(file->write_until_depleted(contents));
};
write_file("line1\n"sv);
auto file_watcher = MUST(Core::FileWatcher::create());
MUST(file_watcher->add_watch(test_path.string(), Core::FileWatcherEvent::Type::ContentModified));
int event_count = 0;
file_watcher->on_change = [&](Core::FileWatcherEvent const& event) {
EXPECT_EQ(event.event_path, test_path.string());
EXPECT(has_flag(event.type, Core::FileWatcherEvent::Type::ContentModified));
if (++event_count == 2) {
MUST(Core::System::unlink(test_path.string()));
event_loop.quit(0);
}
};
auto timer1 = Core::Timer::create_single_shot(500, [&] { write_file("line2\n"sv); });
timer1->start();
auto timer2 = Core::Timer::create_single_shot(1000, [&] { write_file("line3\n"sv); });
timer2->start();
auto catchall_timer = Core::Timer::create_single_shot(2000, [&] {
VERIFY_NOT_REACHED();
});
catchall_timer->start();
event_loop.exec();
}