From 9b59dc5e8b88d311089e57fe134a1377a39242cb Mon Sep 17 00:00:00 2001 From: Shannon Booth Date: Thu, 25 Jul 2024 17:36:10 +1200 Subject: [PATCH] Bindings: Remove exception handling for named_item_value --- .../LibWeb/BindingsGenerator/IDLGenerators.cpp | 3 +-- Userland/Libraries/LibWeb/Bindings/PlatformObject.cpp | 8 +++----- Userland/Libraries/LibWeb/Bindings/PlatformObject.h | 2 +- Userland/Libraries/LibWeb/DOM/Document.cpp | 2 +- Userland/Libraries/LibWeb/DOM/Document.h | 2 +- Userland/Libraries/LibWeb/DOM/HTMLCollection.cpp | 2 +- Userland/Libraries/LibWeb/DOM/HTMLCollection.h | 2 +- .../Libraries/LibWeb/DOM/HTMLFormControlsCollection.cpp | 2 +- .../Libraries/LibWeb/DOM/HTMLFormControlsCollection.h | 2 +- Userland/Libraries/LibWeb/DOM/NamedNodeMap.cpp | 2 +- Userland/Libraries/LibWeb/DOM/NamedNodeMap.h | 2 +- Userland/Libraries/LibWeb/HTML/DOMStringMap.cpp | 2 +- Userland/Libraries/LibWeb/HTML/DOMStringMap.h | 2 +- Userland/Libraries/LibWeb/HTML/HTMLAllCollection.cpp | 2 +- Userland/Libraries/LibWeb/HTML/HTMLAllCollection.h | 2 +- Userland/Libraries/LibWeb/HTML/HTMLFormElement.cpp | 2 +- Userland/Libraries/LibWeb/HTML/HTMLFormElement.h | 2 +- Userland/Libraries/LibWeb/HTML/MimeTypeArray.cpp | 2 +- Userland/Libraries/LibWeb/HTML/MimeTypeArray.h | 2 +- Userland/Libraries/LibWeb/HTML/Plugin.cpp | 2 +- Userland/Libraries/LibWeb/HTML/Plugin.h | 2 +- Userland/Libraries/LibWeb/HTML/PluginArray.cpp | 2 +- Userland/Libraries/LibWeb/HTML/PluginArray.h | 2 +- Userland/Libraries/LibWeb/HTML/Storage.cpp | 2 +- Userland/Libraries/LibWeb/HTML/Storage.h | 2 +- Userland/Libraries/LibWeb/HTML/Window.cpp | 2 +- Userland/Libraries/LibWeb/HTML/Window.h | 2 +- 27 files changed, 29 insertions(+), 32 deletions(-) diff --git a/Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp b/Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp index c863dfce056..faaee9400ce 100644 --- a/Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp +++ b/Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp @@ -3015,7 +3015,6 @@ void @named_properties_class@::initialize(JS::Realm& realm) // https://webidl.spec.whatwg.org/#named-properties-object-getownproperty JS::ThrowCompletionOr> @named_properties_class@::internal_get_own_property(JS::PropertyKey const& property_name) const { - auto& vm = this->vm(); auto& realm = this->realm(); // 1. Let A be the interface for the named properties object O. @@ -3033,7 +3032,7 @@ JS::ThrowCompletionOr> @named_properties_class@ // 2. Let value be an uninitialized variable. // 3. If operation was defined without an identifier, then set value to the result of performing the steps listed in the interface description to determine the value of a named property with P as the name. // 4. Otherwise, operation was defined with an identifier. Set value to the result of performing the method steps of operation with « P » as the only argument value. - auto value = TRY(throw_dom_exception_if_needed(vm, [&] { return object.named_item_value(property_name_string); })); + auto value = object.named_item_value(property_name_string); // 5. Let desc be a newly created Property Descriptor with no fields. JS::PropertyDescriptor descriptor; diff --git a/Userland/Libraries/LibWeb/Bindings/PlatformObject.cpp b/Userland/Libraries/LibWeb/Bindings/PlatformObject.cpp index edca8c8ef79..2f47536f3d8 100644 --- a/Userland/Libraries/LibWeb/Bindings/PlatformObject.cpp +++ b/Userland/Libraries/LibWeb/Bindings/PlatformObject.cpp @@ -85,8 +85,6 @@ JS::ThrowCompletionOr PlatformObject::is_named_property_exposed_on_object( // https://webidl.spec.whatwg.org/#PlatformObjectGetOwnProperty JS::ThrowCompletionOr> PlatformObject::legacy_platform_object_get_own_property(JS::PropertyKey const& property_name, IgnoreNamedProps ignore_named_props) const { - auto& vm = this->vm(); - // 1. If O supports indexed properties and P is an array index, then: if (m_legacy_platform_object_flags->supports_indexed_properties && property_name.is_number()) { // 1. Let index be the result of calling ToUint32(P). @@ -98,7 +96,7 @@ JS::ThrowCompletionOr> PlatformObject::legacy_p // 2. Let value be an uninitialized variable. // 3. If operation was defined without an identifier, then set value to the result of performing the steps listed in the interface description to determine the value of an indexed property with index as the index. // 4. Otherwise, operation was defined with an identifier. Set value to the result of performing the method steps of operation with O as this and « index » as the argument values. - auto value item_value(index); + auto value = item_value(index); // 5. Let desc be a newly created Property Descriptor with no fields. JS::PropertyDescriptor descriptor; @@ -132,7 +130,7 @@ JS::ThrowCompletionOr> PlatformObject::legacy_p // 2. Let value be an uninitialized variable. // 3. If operation was defined without an identifier, then set value to the result of performing the steps listed in the interface description to determine the value of a named property with P as the name. // 4. Otherwise, operation was defined with an identifier. Set value to the result of performing the method steps of operation with O as this and « P » as the argument values. - auto value = TRY(throw_dom_exception_if_needed(vm, [&] { return named_item_value(property_name_string); })); + auto value = named_item_value(property_name_string); // 5. Let desc be a newly created Property Descriptor with no fields. JS::PropertyDescriptor descriptor; @@ -488,7 +486,7 @@ JS::Value PlatformObject::item_value(size_t) const return JS::js_undefined(); } -WebIDL::ExceptionOr PlatformObject::named_item_value(FlyString const&) const +JS::Value PlatformObject::named_item_value(FlyString const&) const { return JS::js_undefined(); } diff --git a/Userland/Libraries/LibWeb/Bindings/PlatformObject.h b/Userland/Libraries/LibWeb/Bindings/PlatformObject.h index b65f36a5d53..aba42c0ed66 100644 --- a/Userland/Libraries/LibWeb/Bindings/PlatformObject.h +++ b/Userland/Libraries/LibWeb/Bindings/PlatformObject.h @@ -73,7 +73,7 @@ protected: JS::ThrowCompletionOr> legacy_platform_object_get_own_property(JS::PropertyKey const&, IgnoreNamedProps ignore_named_props) const; virtual JS::Value item_value(size_t index) const; - virtual WebIDL::ExceptionOr named_item_value(FlyString const& name) const; + virtual JS::Value named_item_value(FlyString const& name) const; virtual Vector supported_property_names() const; virtual bool is_supported_property_name(FlyString const&) const; virtual bool is_supported_property_index(u32) const; diff --git a/Userland/Libraries/LibWeb/DOM/Document.cpp b/Userland/Libraries/LibWeb/DOM/Document.cpp index e13bba6a454..2a19b21d7b5 100644 --- a/Userland/Libraries/LibWeb/DOM/Document.cpp +++ b/Userland/Libraries/LibWeb/DOM/Document.cpp @@ -4837,7 +4837,7 @@ static Vector> named_elements_with_name(Document } // https://html.spec.whatwg.org/multipage/dom.html#dom-document-nameditem -WebIDL::ExceptionOr Document::named_item_value(FlyString const& name) const +JS::Value Document::named_item_value(FlyString const& name) const { // 1. Let elements be the list of named elements with the name name that are in a document tree with the Document as their root. // NOTE: There will be at least one such element, since the algorithm would otherwise not have been invoked by Web IDL. diff --git a/Userland/Libraries/LibWeb/DOM/Document.h b/Userland/Libraries/LibWeb/DOM/Document.h index 569fe1455e0..61dbdc6e960 100644 --- a/Userland/Libraries/LibWeb/DOM/Document.h +++ b/Userland/Libraries/LibWeb/DOM/Document.h @@ -646,7 +646,7 @@ public: void set_needs_to_resolve_paint_only_properties() { m_needs_to_resolve_paint_only_properties = true; } void set_needs_animated_style_update() { m_needs_animated_style_update = true; } - virtual WebIDL::ExceptionOr named_item_value(FlyString const& name) const override; + virtual JS::Value named_item_value(FlyString const& name) const override; virtual Vector supported_property_names() const override; Vector> const& potentially_named_elements() const { return m_potentially_named_elements; } diff --git a/Userland/Libraries/LibWeb/DOM/HTMLCollection.cpp b/Userland/Libraries/LibWeb/DOM/HTMLCollection.cpp index 907cf7b0704..2b6ad82cef8 100644 --- a/Userland/Libraries/LibWeb/DOM/HTMLCollection.cpp +++ b/Userland/Libraries/LibWeb/DOM/HTMLCollection.cpp @@ -177,7 +177,7 @@ JS::Value HTMLCollection::item_value(size_t index) const return element; } -WebIDL::ExceptionOr HTMLCollection::named_item_value(FlyString const& name) const +JS::Value HTMLCollection::named_item_value(FlyString const& name) const { auto* element = named_item(name); if (!element) diff --git a/Userland/Libraries/LibWeb/DOM/HTMLCollection.h b/Userland/Libraries/LibWeb/DOM/HTMLCollection.h index 3c64a4285f7..b516ce1aa4b 100644 --- a/Userland/Libraries/LibWeb/DOM/HTMLCollection.h +++ b/Userland/Libraries/LibWeb/DOM/HTMLCollection.h @@ -41,7 +41,7 @@ public: JS::MarkedVector> collect_matching_elements() const; virtual JS::Value item_value(size_t index) const override; - virtual WebIDL::ExceptionOr named_item_value(FlyString const& name) const override; + virtual JS::Value named_item_value(FlyString const& name) const override; virtual Vector supported_property_names() const override; virtual bool is_supported_property_name(FlyString const&) const override; virtual bool is_supported_property_index(u32) const override; diff --git a/Userland/Libraries/LibWeb/DOM/HTMLFormControlsCollection.cpp b/Userland/Libraries/LibWeb/DOM/HTMLFormControlsCollection.cpp index 151f39388ea..7a8234029a0 100644 --- a/Userland/Libraries/LibWeb/DOM/HTMLFormControlsCollection.cpp +++ b/Userland/Libraries/LibWeb/DOM/HTMLFormControlsCollection.cpp @@ -76,7 +76,7 @@ Variant> HTMLFormControlsCollection:: })); } -WebIDL::ExceptionOr HTMLFormControlsCollection::named_item_value(FlyString const& name) const +JS::Value HTMLFormControlsCollection::named_item_value(FlyString const& name) const { return named_item_or_radio_node_list(name).visit( [](Empty) -> JS::Value { return JS::js_undefined(); }, diff --git a/Userland/Libraries/LibWeb/DOM/HTMLFormControlsCollection.h b/Userland/Libraries/LibWeb/DOM/HTMLFormControlsCollection.h index 809bbff4238..3c77c620d43 100644 --- a/Userland/Libraries/LibWeb/DOM/HTMLFormControlsCollection.h +++ b/Userland/Libraries/LibWeb/DOM/HTMLFormControlsCollection.h @@ -25,7 +25,7 @@ public: protected: virtual void initialize(JS::Realm&) override; - virtual WebIDL::ExceptionOr named_item_value(FlyString const& name) const final; + virtual JS::Value named_item_value(FlyString const& name) const final; private: HTMLFormControlsCollection(ParentNode& root, Scope, ESCAPING Function filter); diff --git a/Userland/Libraries/LibWeb/DOM/NamedNodeMap.cpp b/Userland/Libraries/LibWeb/DOM/NamedNodeMap.cpp index 7f2188862a6..f3f7999b7a5 100644 --- a/Userland/Libraries/LibWeb/DOM/NamedNodeMap.cpp +++ b/Userland/Libraries/LibWeb/DOM/NamedNodeMap.cpp @@ -334,7 +334,7 @@ JS::Value NamedNodeMap::item_value(size_t index) const return node; } -WebIDL::ExceptionOr NamedNodeMap::named_item_value(FlyString const& name) const +JS::Value NamedNodeMap::named_item_value(FlyString const& name) const { auto const* node = get_named_item(name); if (!node) diff --git a/Userland/Libraries/LibWeb/DOM/NamedNodeMap.h b/Userland/Libraries/LibWeb/DOM/NamedNodeMap.h index 8091ffac221..2a70da45698 100644 --- a/Userland/Libraries/LibWeb/DOM/NamedNodeMap.h +++ b/Userland/Libraries/LibWeb/DOM/NamedNodeMap.h @@ -27,7 +27,7 @@ public: virtual bool is_supported_property_index(u32 index) const override; virtual Vector supported_property_names() const override; virtual JS::Value item_value(size_t index) const override; - virtual WebIDL::ExceptionOr named_item_value(FlyString const& name) const override; + virtual JS::Value named_item_value(FlyString const& name) const override; size_t length() const { return m_attributes.size(); } bool is_empty() const { return m_attributes.is_empty(); } diff --git a/Userland/Libraries/LibWeb/HTML/DOMStringMap.cpp b/Userland/Libraries/LibWeb/HTML/DOMStringMap.cpp index 1c7532860d5..c1a49a522ed 100644 --- a/Userland/Libraries/LibWeb/HTML/DOMStringMap.cpp +++ b/Userland/Libraries/LibWeb/HTML/DOMStringMap.cpp @@ -204,7 +204,7 @@ WebIDL::ExceptionOr DOMStringMap::del return DidDeletionFail::No; } -WebIDL::ExceptionOr DOMStringMap::named_item_value(FlyString const& name) const +JS::Value DOMStringMap::named_item_value(FlyString const& name) const { return JS::PrimitiveString::create(vm(), determine_value_of_named_property(name)); } diff --git a/Userland/Libraries/LibWeb/HTML/DOMStringMap.h b/Userland/Libraries/LibWeb/HTML/DOMStringMap.h index 36505468d0b..522733c18f3 100644 --- a/Userland/Libraries/LibWeb/HTML/DOMStringMap.h +++ b/Userland/Libraries/LibWeb/HTML/DOMStringMap.h @@ -36,7 +36,7 @@ private: virtual void visit_edges(Cell::Visitor&) override; // ^PlatformObject - virtual WebIDL::ExceptionOr named_item_value(FlyString const&) const override; + virtual JS::Value named_item_value(FlyString const&) const override; virtual Vector supported_property_names() const override; struct NameValuePair { diff --git a/Userland/Libraries/LibWeb/HTML/HTMLAllCollection.cpp b/Userland/Libraries/LibWeb/HTML/HTMLAllCollection.cpp index 3049cd0f4c8..9ce787ee9e8 100644 --- a/Userland/Libraries/LibWeb/HTML/HTMLAllCollection.cpp +++ b/Userland/Libraries/LibWeb/HTML/HTMLAllCollection.cpp @@ -224,7 +224,7 @@ JS::Value HTMLAllCollection::item_value(size_t index) const return get_the_all_indexed_element(index); } -WebIDL::ExceptionOr HTMLAllCollection::named_item_value(FlyString const& name) const +JS::Value HTMLAllCollection::named_item_value(FlyString const& name) const { return named_item(name).visit( [](Empty) -> JS::Value { return JS::js_undefined(); }, diff --git a/Userland/Libraries/LibWeb/HTML/HTMLAllCollection.h b/Userland/Libraries/LibWeb/HTML/HTMLAllCollection.h index b6cd1595af4..fcb9ce9a323 100644 --- a/Userland/Libraries/LibWeb/HTML/HTMLAllCollection.h +++ b/Userland/Libraries/LibWeb/HTML/HTMLAllCollection.h @@ -35,7 +35,7 @@ public: JS::MarkedVector> collect_matching_elements() const; virtual JS::Value item_value(size_t index) const override; - virtual WebIDL::ExceptionOr named_item_value(FlyString const& name) const override; + virtual JS::Value named_item_value(FlyString const& name) const override; virtual Vector supported_property_names() const override; virtual bool is_supported_property_index(u32) const override; diff --git a/Userland/Libraries/LibWeb/HTML/HTMLFormElement.cpp b/Userland/Libraries/LibWeb/HTML/HTMLFormElement.cpp index fb0afdd4796..ca56bc337a6 100644 --- a/Userland/Libraries/LibWeb/HTML/HTMLFormElement.cpp +++ b/Userland/Libraries/LibWeb/HTML/HTMLFormElement.cpp @@ -1036,7 +1036,7 @@ Vector HTMLFormElement::supported_property_names() const } // https://html.spec.whatwg.org/multipage/forms.html#dom-form-nameditem -WebIDL::ExceptionOr HTMLFormElement::named_item_value(FlyString const& name) const +JS::Value HTMLFormElement::named_item_value(FlyString const& name) const { auto& realm = this->realm(); auto& root = verify_cast(this->root()); diff --git a/Userland/Libraries/LibWeb/HTML/HTMLFormElement.h b/Userland/Libraries/LibWeb/HTML/HTMLFormElement.h index ec5c23aaee3..cca12f0f46d 100644 --- a/Userland/Libraries/LibWeb/HTML/HTMLFormElement.h +++ b/Userland/Libraries/LibWeb/HTML/HTMLFormElement.h @@ -107,7 +107,7 @@ private: // ^PlatformObject virtual JS::Value item_value(size_t index) const override; - virtual WebIDL::ExceptionOr named_item_value(FlyString const& name) const override; + virtual JS::Value named_item_value(FlyString const& name) const override; virtual Vector supported_property_names() const override; virtual bool is_supported_property_index(u32) const override; diff --git a/Userland/Libraries/LibWeb/HTML/MimeTypeArray.cpp b/Userland/Libraries/LibWeb/HTML/MimeTypeArray.cpp index 20126caef6f..d7445065ac8 100644 --- a/Userland/Libraries/LibWeb/HTML/MimeTypeArray.cpp +++ b/Userland/Libraries/LibWeb/HTML/MimeTypeArray.cpp @@ -105,7 +105,7 @@ JS::Value MimeTypeArray::item_value(size_t index) const return return_value.ptr(); } -WebIDL::ExceptionOr MimeTypeArray::named_item_value(FlyString const& name) const +JS::Value MimeTypeArray::named_item_value(FlyString const& name) const { auto return_value = named_item(name); if (!return_value) diff --git a/Userland/Libraries/LibWeb/HTML/MimeTypeArray.h b/Userland/Libraries/LibWeb/HTML/MimeTypeArray.h index 24f54d74f3c..0f7776db9ed 100644 --- a/Userland/Libraries/LibWeb/HTML/MimeTypeArray.h +++ b/Userland/Libraries/LibWeb/HTML/MimeTypeArray.h @@ -30,7 +30,7 @@ private: // ^Bindings::PlatformObject virtual Vector supported_property_names() const override; virtual JS::Value item_value(size_t index) const override; - virtual WebIDL::ExceptionOr named_item_value(FlyString const& name) const override; + virtual JS::Value named_item_value(FlyString const& name) const override; virtual bool is_supported_property_index(u32) const override; }; diff --git a/Userland/Libraries/LibWeb/HTML/Plugin.cpp b/Userland/Libraries/LibWeb/HTML/Plugin.cpp index 7b9efa04f86..44f6be7fba6 100644 --- a/Userland/Libraries/LibWeb/HTML/Plugin.cpp +++ b/Userland/Libraries/LibWeb/HTML/Plugin.cpp @@ -128,7 +128,7 @@ JS::Value Plugin::item_value(size_t index) const return return_value.ptr(); } -WebIDL::ExceptionOr Plugin::named_item_value(FlyString const& name) const +JS::Value Plugin::named_item_value(FlyString const& name) const { auto return_value = named_item(name); if (!return_value) diff --git a/Userland/Libraries/LibWeb/HTML/Plugin.h b/Userland/Libraries/LibWeb/HTML/Plugin.h index c8fac06f8cb..61b6bc1ab14 100644 --- a/Userland/Libraries/LibWeb/HTML/Plugin.h +++ b/Userland/Libraries/LibWeb/HTML/Plugin.h @@ -36,7 +36,7 @@ private: // ^Bindings::PlatformObject virtual Vector supported_property_names() const override; virtual JS::Value item_value(size_t index) const override; - virtual WebIDL::ExceptionOr named_item_value(FlyString const& name) const override; + virtual JS::Value named_item_value(FlyString const& name) const override; virtual bool is_supported_property_index(u32) const override; }; diff --git a/Userland/Libraries/LibWeb/HTML/PluginArray.cpp b/Userland/Libraries/LibWeb/HTML/PluginArray.cpp index 8115ab9ccf2..734c2948dc5 100644 --- a/Userland/Libraries/LibWeb/HTML/PluginArray.cpp +++ b/Userland/Libraries/LibWeb/HTML/PluginArray.cpp @@ -114,7 +114,7 @@ JS::Value PluginArray::item_value(size_t index) const return return_value.ptr(); } -WebIDL::ExceptionOr PluginArray::named_item_value(FlyString const& name) const +JS::Value PluginArray::named_item_value(FlyString const& name) const { auto return_value = named_item(name); if (!return_value) diff --git a/Userland/Libraries/LibWeb/HTML/PluginArray.h b/Userland/Libraries/LibWeb/HTML/PluginArray.h index 0f0dfcd37f4..c37e93d50cc 100644 --- a/Userland/Libraries/LibWeb/HTML/PluginArray.h +++ b/Userland/Libraries/LibWeb/HTML/PluginArray.h @@ -31,7 +31,7 @@ private: // ^Bindings::PlatformObject virtual Vector supported_property_names() const override; virtual JS::Value item_value(size_t index) const override; - virtual WebIDL::ExceptionOr named_item_value(FlyString const& name) const override; + virtual JS::Value named_item_value(FlyString const& name) const override; virtual bool is_supported_property_index(u32) const override; }; diff --git a/Userland/Libraries/LibWeb/HTML/Storage.cpp b/Userland/Libraries/LibWeb/HTML/Storage.cpp index 71eaa4eb707..fc0dfd65ba3 100644 --- a/Userland/Libraries/LibWeb/HTML/Storage.cpp +++ b/Userland/Libraries/LibWeb/HTML/Storage.cpp @@ -168,7 +168,7 @@ Vector Storage::supported_property_names() const return names; } -WebIDL::ExceptionOr Storage::named_item_value(FlyString const& name) const +JS::Value Storage::named_item_value(FlyString const& name) const { auto value = get_item(name); if (!value.has_value()) diff --git a/Userland/Libraries/LibWeb/HTML/Storage.h b/Userland/Libraries/LibWeb/HTML/Storage.h index d74eeae306b..71b6f925722 100644 --- a/Userland/Libraries/LibWeb/HTML/Storage.h +++ b/Userland/Libraries/LibWeb/HTML/Storage.h @@ -38,7 +38,7 @@ private: virtual void initialize(JS::Realm&) override; // ^PlatformObject - virtual WebIDL::ExceptionOr named_item_value(FlyString const&) const override; + virtual JS::Value named_item_value(FlyString const&) const override; virtual WebIDL::ExceptionOr delete_value(String const&) override; virtual Vector supported_property_names() const override; virtual WebIDL::ExceptionOr set_value_of_named_property(String const& key, JS::Value value) override; diff --git a/Userland/Libraries/LibWeb/HTML/Window.cpp b/Userland/Libraries/LibWeb/HTML/Window.cpp index a8ce90b5312..d3c55ecfbdb 100644 --- a/Userland/Libraries/LibWeb/HTML/Window.cpp +++ b/Userland/Libraries/LibWeb/HTML/Window.cpp @@ -1635,7 +1635,7 @@ Vector Window::supported_property_names() const } // https://html.spec.whatwg.org/#named-access-on-the-window-object -WebIDL::ExceptionOr Window::named_item_value(FlyString const& name) const +JS::Value Window::named_item_value(FlyString const& name) const { // FIXME: Make the const-correctness of the methods this method calls less cowboy. auto& mutable_this = const_cast(*this); diff --git a/Userland/Libraries/LibWeb/HTML/Window.h b/Userland/Libraries/LibWeb/HTML/Window.h index 51ab20ced3c..c9f6053ceec 100644 --- a/Userland/Libraries/LibWeb/HTML/Window.h +++ b/Userland/Libraries/LibWeb/HTML/Window.h @@ -232,7 +232,7 @@ public: [[nodiscard]] OrderedHashMap> document_tree_child_navigable_target_name_property_set(); [[nodiscard]] Vector supported_property_names() const override; - [[nodiscard]] WebIDL::ExceptionOr named_item_value(FlyString const&) const override; + [[nodiscard]] JS::Value named_item_value(FlyString const&) const override; bool find(String const& string);