Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-08 05:27:14 +09:00
Code Activity

LibCore: Remove ErrorOr return type from read_long_version_string

Browse source 
Nothing in this function is fallible.
This commit is contained in:
Timothy Flynn 2025-02-12 08:57:20 -05:00 • committed by Tim Flynn
parent 6e61cc5a1e
commit 9a4bb958ac
Notes: github-actions[bot] 2025-02-13 13:28:03 +00:00
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibCore/ArgsParser.cpp
View file

@ -384,7 +384,7 @@ void ArgsParser::print_version(FILE* file)
{
// FIXME: Allow applications to override version string for --version.
// Especially useful for Lagom applications
outln(file, Core::Version::read_long_version_string().release_value_but_fixme_should_propagate_errors());
outln(file, Core::Version::read_long_version_string());
}
void ArgsParser::add_option(Option&& option)

2
Libraries/LibCore/Version.cpp
View file

@ -10,7 +10,7 @@
namespace Core::Version {
ErrorOr<String> read_long_version_string()
String read_long_version_string()
{
auto validate_git_hash = [](auto hash) {
if (hash.length() < 4 || hash.length() > 40)

2
Libraries/LibCore/Version.h
View file

@ -11,6 +11,6 @@
namespace Core::Version {
ErrorOr<String> read_long_version_string();
String read_long_version_string();
}