LibWebView+UI: Remove native do-not-track setting

Author: https://github.com/trflynn89
Commit: 920170f60a
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4194
Reviewed-by: https://github.com/AtkinsSJ

Libraries/LibWebView/ViewImplementation.cpp

@@ -257,11 +257,6 @@ void ViewImplementation::set_preferred_languages(ReadonlySpan<String> preferred_
     client().async_set_preferred_languages(page_id(), preferred_languages);
 }
 
-void ViewImplementation::set_enable_do_not_track(bool enable)
-{
-    client().async_set_enable_do_not_track(page_id(), enable);
-}
-
 ByteString ViewImplementation::selected_text()
 {
     return client().get_selected_text(page_id());

Libraries/LibWebView/ViewImplementation.h

@@ -82,8 +82,6 @@ public:
 
     void set_preferred_languages(ReadonlySpan<String>);
 
-    void set_enable_do_not_track(bool);
-
     ByteString selected_text();
     Optional<String> selected_text_with_whitespace_collapsed();
     void select_all();

UI/Qt/BrowserWindow.cpp

@@ -97,12 +97,6 @@ BrowserWindow::BrowserWindow(Vector<URL::URL> const& initial_urls, IsPopupWindow
         });
     }
 
-    QObject::connect(Settings::the(), &Settings::enable_do_not_track_changed, this, [this](bool enable) {
-        for_each_tab([enable](auto& tab) {
-            tab.set_enable_do_not_track(enable);
-        });
-    });
-
     QObject::connect(Settings::the(), &Settings::preferred_languages_changed, this, [this](QStringList languages) {
         Vector<String> preferred_languages;
         preferred_languages.ensure_capacity(languages.length());
@@ -873,7 +867,6 @@ void BrowserWindow::initialize_tab(Tab* tab)
     tab->set_user_agent_string(user_agent_string());
     tab->set_preferred_languages(preferred_languages);
     tab->set_navigator_compatibility_mode(navigator_compatibility_mode());
-    tab->set_enable_do_not_track(Settings::the()->enable_do_not_track());
     tab->view().set_preferred_color_scheme(m_preferred_color_scheme);
 }
 

UI/Qt/Settings.cpp

@@ -65,17 +65,6 @@ void Settings::set_preferred_languages(QStringList const& languages)
     emit preferred_languages_changed(languages);
 }
 
-bool Settings::enable_do_not_track()
-{
-    return m_qsettings->value("enable_do_not_track", false).toBool();
-}
-
-void Settings::set_enable_do_not_track(bool enable)
-{
-    m_qsettings->setValue("enable_do_not_track", enable);
-    emit enable_do_not_track_changed(enable);
-}
-
 bool Settings::show_menubar()
 {
     return m_qsettings->value("show_menubar", false).toBool();

UI/Qt/Settings.h

@@ -44,9 +44,6 @@ public:
     QStringList preferred_languages();
     void set_preferred_languages(QStringList const& languages);
 
-    bool enable_do_not_track();
-    void set_enable_do_not_track(bool enable);
-
     bool show_menubar();
     void set_show_menubar(bool show_menubar);
 

UI/Qt/SettingsDialog.cpp

@@ -32,18 +32,7 @@ SettingsDialog::SettingsDialog(QMainWindow* window)
         close();
     });
 
-    m_enable_do_not_track = new QCheckBox(this);
-    m_enable_do_not_track->setChecked(Settings::the()->enable_do_not_track());
-#if (QT_VERSION > QT_VERSION_CHECK(6, 7, 0))
-    QObject::connect(m_enable_do_not_track, &QCheckBox::checkStateChanged, this, [&](int state) {
-#else
-    QObject::connect(m_enable_do_not_track, &QCheckBox::stateChanged, this, [&](int state) {
-#endif
-        Settings::the()->set_enable_do_not_track(state == Qt::Checked);
-    });
-
     m_layout->addRow(new QLabel("Preferred Language(s)", this), m_preferred_languages);
-    m_layout->addRow(new QLabel("Send web sites a \"Do Not Track\" request", this), m_enable_do_not_track);
 
     setWindowTitle("Settings");
     setLayout(m_layout);

UI/Qt/SettingsDialog.h

@@ -26,7 +26,6 @@ private:
     QFormLayout* m_layout;
     QMainWindow* m_window { nullptr };
     QLineEdit* m_preferred_languages { nullptr };
-    QCheckBox* m_enable_do_not_track { nullptr };
 };
 
 }

UI/Qt/Tab.cpp

@@ -943,9 +943,4 @@ void Tab::set_preferred_languages(ReadonlySpan<String> preferred_languages)
     m_view->set_preferred_languages(preferred_languages);
 }
 
-void Tab::set_enable_do_not_track(bool enable)
-{
-    m_view->set_enable_do_not_track(enable);
-}
-
 }

UI/Qt/Tab.h

@@ -90,8 +90,6 @@ public:
 
     void set_preferred_languages(ReadonlySpan<String> preferred_languages);
 
-    void set_enable_do_not_track(bool);
-
     bool url_is_hidden() const { return m_location_edit->url_is_hidden(); }
     void set_url_is_hidden(bool url_is_hidden) { m_location_edit->set_url_is_hidden(url_is_hidden); }