Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-09 17:44:56 +09:00
Code Activity

WebContent: Remove unused private member

Browse source 
This commit removes the unused m_heap member from ConnectionFromClient.
This also works around an issue where some cmake version doesn't apply
compiler options from within a subdirectory globally.
This commit is contained in:
R-Goc 2025-04-04 09:35:20 +02:00 • committed by Jelle Raaijmakers
parent 67848a8c51
commit 8f1a7934e1
Notes: github-actions[bot] 2025-04-04 08:10:40 +00:00
3 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Services/WebContent/ConnectionFromClient.cpp
View file

@ -56,9 +56,8 @@
namespace WebContent {
ConnectionFromClient::ConnectionFromClient(GC::Heap& heap, IPC::Transport transport)
ConnectionFromClient::ConnectionFromClient(IPC::Transport transport)
: IPC::ConnectionFromClient<WebContentClientEndpoint, WebContentServerEndpoint>(*this, move(transport), 1)
, m_heap(heap)
, m_page_host(PageHost::create(*this))
{
}

3
Services/WebContent/ConnectionFromClient.h
View file

@ -51,7 +51,7 @@ public:
Queue<Web::QueuedInputEvent>& input_event_queue() { return m_input_event_queue; }
private:
explicit ConnectionFromClient(GC::Heap&, IPC::Transport);
explicit ConnectionFromClient(IPC::Transport);
Optional<PageClient&> page(u64 index, SourceLocation = SourceLocation::current());
Optional<PageClient const&> page(u64 index, SourceLocation = SourceLocation::current()) const;
@ -157,7 +157,6 @@ private:
virtual void system_time_zone_changed() override;
GC::Heap& m_heap;
NonnullOwnPtr<PageHost> m_page_host;
HashMap<int, Web::FileRequest> m_requested_files {};

2
Services/WebContent/main.cpp
View file

@ -213,7 +213,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
static_assert(IsSame<IPC::Transport, IPC::TransportSocket>, "Need to handle other IPC transports here");
auto webcontent_socket = TRY(Core::take_over_socket_from_system_server("WebContent"sv));
auto webcontent_client = TRY(WebContent::ConnectionFromClient::try_create(Web::Bindings::main_thread_vm().heap(), IPC::Transport(move(webcontent_socket))));
auto webcontent_client = TRY(WebContent::ConnectionFromClient::try_create(IPC::Transport(move(webcontent_socket))));
webcontent_client->on_image_decoder_connection = [&](auto& socket_file) {
auto maybe_error = reinitialize_image_decoder(socket_file);