Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-09 17:44:56 +09:00
Code Activity

AK: Move String::ends_with implementation to StringUtils

Browse source 
Centralizing so it can be used by other string implementations
This commit is contained in:
Brian Gianforcaro 2020-05-26 02:58:34 -07:00 • committed by Andreas Kling
parent d98e743568
commit 8e4b858b3f
Notes: sideshowbarker 2024-07-19 06:07:44 +09:00
3 changed files with 15 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
AK/String.cpp
View file

@ -280,13 +280,7 @@ bool String::starts_with(char ch) const
bool String::ends_with(const StringView& str) const bool String::ends_with(const StringView& str) const
{ {
if (str.is_empty()) return StringUtils::ends_with(*this, str);
return true;
if (is_empty())
return false;
if (str.length() > length())
return false;
return !memcmp(characters() + (length() - str.length()), str.characters_without_null_termination(), str.length());
} }
bool String::ends_with(char ch) const bool String::ends_with(char ch) const

12
AK/StringUtils.cpp
View file

@ -25,6 +25,7 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/ */
#include <AK/Memory.h>
#include <AK/String.h> #include <AK/String.h>
#include <AK/StringUtils.h> #include <AK/StringUtils.h>
#include <AK/StringView.h> #include <AK/StringView.h>
@ -195,6 +196,17 @@ bool equals_ignoring_case(const StringView& a, const StringView& b)
return true; return true;
} }
bool ends_with(const StringView& str, const StringView& end)
{
if (end.is_empty())
return true;
if (str.is_empty())
return false;
if (end.length() > str.length())
return false;
return !memcmp(str.characters_without_null_termination() + (str.length() - end.length()), end.characters_without_null_termination(), end.length());
}
} }
} }

2
AK/StringUtils.h
View file

@ -43,6 +43,8 @@ int convert_to_int(const StringView&, bool& ok);
unsigned convert_to_uint(const StringView&, bool& ok); unsigned convert_to_uint(const StringView&, bool& ok);
unsigned convert_to_uint_from_hex(const StringView&, bool& ok); unsigned convert_to_uint_from_hex(const StringView&, bool& ok);
bool equals_ignoring_case(const StringView&, const StringView&); bool equals_ignoring_case(const StringView&, const StringView&);
bool ends_with(const StringView& str, const StringView& end);
} }
} }