1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-09 09:34:57 +09:00

Everywhere: Switch from (void) to [[maybe_unused]] (#4473)

Problem:
- `(void)` simply casts the expression to void. This is understood to
  indicate that it is ignored, but this is really a compiler trick to
  get the compiler to not generate a warning.

Solution:
- Use the `[[maybe_unused]]` attribute to indicate the value is unused.

Note:
- Functions taking a `(void)` argument list have also been changed to
  `()` because this is not needed and shows up in the same grep
  command.
This commit is contained in:
Lenny Maiorani 2020-12-20 16:09:48 -07:00 committed by GitHub
parent 4421d98e30
commit 765936ebae
Signed by: github
GPG key ID: 4AEE18F83AFDEB23
Notes: sideshowbarker 2024-07-19 00:43:22 +09:00
103 changed files with 219 additions and 362 deletions

View file

@ -43,16 +43,13 @@
namespace AK {
inline void fill_with_random(void* buffer, size_t length)
inline void fill_with_random([[maybe_unused]] void* buffer, [[maybe_unused]] size_t length)
{
#if defined(__serenity__)
arc4random_buf(buffer, length);
#elif defined(OSS_FUZZ)
(void)buffer;
(void)length;
#elif defined(__unix__) or defined(__APPLE__)
int rc = getentropy(buffer, length);
(void)rc;
[[maybe_unused]] int rc = getentropy(buffer, length);
#endif
}