Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-10 18:10:56 +09:00
Code Activity

AK+Everywhere: Rename String to DeprecatedString

Browse source 
We have a new, improved string type coming up in AK (OOM aware, no null
state), and while it's going to use UTF-8, the name UTF8String is a
mouthful - so let's free up the String name by renaming the existing
class.
Making the old one have an annoying name will hopefully also help with
quick adoption :^)
This commit is contained in:
Linus Groh 2022-12-04 18:02:33 +00:00 • committed by Andreas Kling
parent f74251606d
commit 6e19ab2bbc
Notes: sideshowbarker 2024-07-18 04:38:32 +09:00
2006 changed files with 11635 additions and 11636 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Userland/Applications/Browser/BookmarksBarWidget.cpp
View file

@ -74,12 +74,12 @@ private:
};
}
String title() const
DeprecatedString title() const
{
return m_title_textbox->text();
}
String url() const
DeprecatedString url() const
{
return m_url_textbox->text();
}
@ -97,7 +97,7 @@ BookmarksBarWidget& BookmarksBarWidget::the()
return *s_the;
}
BookmarksBarWidget::BookmarksBarWidget(String const& bookmarks_file, bool enabled)
BookmarksBarWidget::BookmarksBarWidget(DeprecatedString const& bookmarks_file, bool enabled)
{
s_the = this;
set_layout<GUI::HorizontalBoxLayout>();
@ -259,7 +259,7 @@ void BookmarksBarWidget::update_content_size()
}
}
bool BookmarksBarWidget::contains_bookmark(String const& url)
bool BookmarksBarWidget::contains_bookmark(DeprecatedString const& url)
{
for (int item_index = 0; item_index < model()->row_count(); ++item_index) {
@ -272,7 +272,7 @@ bool BookmarksBarWidget::contains_bookmark(String const& url)
return false;
}
bool BookmarksBarWidget::remove_bookmark(String const& url)
bool BookmarksBarWidget::remove_bookmark(DeprecatedString const& url)
{
for (int item_index = 0; item_index < model()->row_count(); ++item_index) {
@ -292,7 +292,7 @@ bool BookmarksBarWidget::remove_bookmark(String const& url)
return false;
}
bool BookmarksBarWidget::add_bookmark(String const& url, String const& title)
bool BookmarksBarWidget::add_bookmark(DeprecatedString const& url, DeprecatedString const& title)
{
Vector<JsonValue> values;
values.append(title);
@ -306,7 +306,7 @@ bool BookmarksBarWidget::add_bookmark(String const& url, String const& title)
return false;
}
bool BookmarksBarWidget::edit_bookmark(String const& url)
bool BookmarksBarWidget::edit_bookmark(DeprecatedString const& url)
{
for (int item_index = 0; item_index < model()->row_count(); ++item_index) {
auto item_title = model()->index(item_index, 0).data().to_string();