From 6a1b3f740ccdd8dc2db5ce089d7b7be845c0cafe Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Wed, 21 May 2025 16:49:07 -0400 Subject: [PATCH] Meta: Avoid double-access of LADYBIRD_SOURCE_DIR environment variable The `ensure_ladybird_source_dir` function returns the source directory. Let's just use it. This silences a pyright warning. --- Meta/ladybird.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Meta/ladybird.py b/Meta/ladybird.py index 805266593b6..45cde958417 100755 --- a/Meta/ladybird.py +++ b/Meta/ladybird.py @@ -288,9 +288,8 @@ def configure_build_env(preset: str, cc: str, cxx: str) -> tuple[Path, Path, lis f"-DCMAKE_CXX_COMPILER={cxx}", ] ) - ensure_ladybird_source_dir() - lb_source_dir = Path(os.environ.get("LADYBIRD_SOURCE_DIR")) + lb_source_dir = ensure_ladybird_source_dir() build_root_dir = lb_source_dir / "Build" known_presets = {