Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-09 09:34:57 +09:00
Code Activity

LibWeb: Separate adding to performance buffers and queueing to observers

Browse source 
The User Timing, Resource Timing and Navigation Timing specifications
have not been updated to account for the queue method to also append to
the underlying performance buffer and it's method of checking it's
full.

This separates the functionality into a different function, with a flag
to indicate whether to use the custom full buffer logic or not.
This commit is contained in:
Luke Wilde 2025-02-26 14:58:17 +00:00 • committed by Andrew Kaster
parent 209b10e53e
commit 67cfb64d07
Notes: github-actions[bot] 2025-03-06 16:02:20 +00:00
3 changed files with 41 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/HighResolutionTime/Performance.cpp
View file

@ -89,7 +89,7 @@ WebIDL::ExceptionOr<GC::Ref<UserTiming::PerformanceMark>> Performance::mark(Stri
window_or_worker().queue_performance_entry(entry);
// 3. Add entry to the performance entry buffer.
// FIXME: This seems to be a holdover from moving to the `queue` structure for PerformanceObserver, as this would cause a double append.
window_or_worker().add_performance_entry(entry);
// 4. Return entry.
return entry;
@ -309,7 +309,7 @@ WebIDL::ExceptionOr<GC::Ref<UserTiming::PerformanceMeasure>> Performance::measur
window_or_worker().queue_performance_entry(entry);
// 11. Add entry to the performance entry buffer.
// FIXME: This seems to be a holdover from moving to the `queue` structure for PerformanceObserver, as this would cause a double append.
window_or_worker().add_performance_entry(entry);
// 12. Return entry.
return entry;