Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-09 09:34:57 +09:00
Code Activity

Meta: Link with OpenSSL explicitly

Browse source 
Explicitly link final targets with OpenSSL to ensure that the vcpkg
version is loaded instead of the system one.

Before this change we would inherit `libcrypto.so` and `libssl.so` from
other dependencies, like Qt, that do not have their RPATH rewritten.
This would cause the loader to prefer the system libraries over the
vcpkg ones causing all sorts of version mismatch issues.

The effectiveness of this change can be verified with
`readelf -d ./bin/Ladybird` showing `libcrypto.so` and `libssl.so` as
direct dependencies, before they would not appear. Additionally, `ldd`
will show `libcrypto.so` and `libssl.so` pointing to the vcpkg builds.
This commit is contained in:
devgianlu 2025-02-14 09:34:33 +01:00 • committed by Jelle Raaijmakers
parent 41c6f93aa8
commit 62cd358fab
Notes: github-actions[bot] 2025-02-17 11:37:34 +00:00
6 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
CMakeLists.txt
View file

@ -82,6 +82,9 @@ if (ENABLE_QT AND ENABLE_GUI_TARGETS)
find_package(Qt6 REQUIRED COMPONENTS Core Widgets Network)
endif()
# We need to find OpenSSL in order to link it explicitly with all targets.
find_package(OpenSSL REQUIRED)
include(CTest) # for BUILD_TESTING option, default ON
if (ENABLE_GUI_TARGETS)