Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-11 18:20:43 +09:00
Code Activity

Userland: Consolidate most PATH resolving into a single implementation

Browse source 
We previously had at least three different implementations for resolving
executables in the PATH, all of which had slightly different
characteristics.

Merge those into a single implementation to keep the behaviour
consistent, and maybe to make that implementation more configurable in
the future.
This commit is contained in:
Tim Schumacher 2022-08-20 18:31:03 +02:00 • committed by Linus Groh
parent 39a3775f48
commit 5f99934dce
Notes: sideshowbarker 2024-07-17 07:52:20 +09:00
13 changed files with 74 additions and 95 deletions
Download patch file Download diff file Expand all files Collapse all files

22
Userland/Libraries/LibCore/DirIterator.cpp
View file

@ -95,28 +95,6 @@ String DirIterator::next_full_path()
return builder.to_string();
}
String find_executable_in_path(String filename)
{
if (filename.is_empty())
return {};
if (filename.starts_with('/')) {
if (access(filename.characters(), X_OK) == 0)
return filename;
return {};
}
for (auto directory : String { getenv("PATH") }.split(':')) {
auto fullpath = String::formatted("{}/{}", directory, filename);
if (access(fullpath.characters(), X_OK) == 0)
return fullpath;
}
return {};
}
int DirIterator::fd() const
{
if (!m_dir)