Ladybird/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-09 17:44:56 +09:00
Code Activity

LibTLS: Fix TestTLSHandshake by correctly reading the CA certificates

Browse source
This commit is contained in:
Michiel Visser 2022-02-23 12:34:07 +01:00 • committed by Ali Mohammad Pur
parent 976bb715e0
commit 5a60bed88b
Notes: sideshowbarker 2024-07-17 11:45:06 +09:00
1 changed files with 19 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

29
Tests/LibTLS/TestTLSHandshake.cpp
View file

@ -4,6 +4,7 @@
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
#include <AK/Base64.h>
#include <LibCore/ConfigFile.h> #include <LibCore/ConfigFile.h>
#include <LibCore/EventLoop.h> #include <LibCore/EventLoop.h>
#include <LibCore/File.h> #include <LibCore/File.h>
@ -46,17 +47,25 @@ Vector<Certificate> load_certificates()
} }
auto config = Core::ConfigFile::open(ca_certs_filepath).release_value_but_fixme_should_propagate_errors(); auto config = Core::ConfigFile::open(ca_certs_filepath).release_value_but_fixme_should_propagate_errors();
auto now = Core::DateTime::now();
auto last_year = Core::DateTime::create(now.year() - 1);
auto next_year = Core::DateTime::create(now.year() + 1);
for (auto& entity : config->groups()) { for (auto& entity : config->groups()) {
Certificate cert; for (auto& subject : config->keys(entity)) {
cert.subject.subject = entity; auto certificate_base64 = config->read_entry(entity, subject);
cert.issuer.subject = config->read_entry(entity, "issuer_subject", entity); auto certificate_data_result = decode_base64(certificate_base64);
cert.subject.country = config->read_entry(entity, "country"); if (certificate_data_result.is_error()) {
cert.not_before = Crypto::ASN1::parse_generalized_time(config->read_entry(entity, "not_before", "")).value_or(last_year); dbgln("Skipping CA Certificate {} {}: out of memory", entity, subject);
cert.not_after = Crypto::ASN1::parse_generalized_time(config->read_entry(entity, "not_after", "")).value_or(next_year); continue;
certificates.append(move(cert)); }
auto certificate_data = certificate_data_result.release_value();
auto certificate_result = Certificate::parse_asn1(certificate_data.bytes());
// If the certificate does not parse it is likely using elliptic curve keys/signatures, which are not
// supported right now. Currently, ca_certs.ini should only contain certificates with RSA keys/signatures.
if (!certificate_result.has_value()) {
dbgln("Skipping CA Certificate {} {}: unable to parse", entity, subject);
continue;
}
auto certificate = certificate_result.release_value();
certificates.append(move(certificate));
}
} }
return certificates; return certificates;
} }